Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-04-04 11:01:20 -05:00
Code Issues Activity

✨ Add some minor performance improvements to dashboard components

Browse source
This commit is contained in:
Andrey Antukh 2023-05-09 14:05:19 +02:00
parent 35969e9f26
commit bf3888585a
4 changed files with 32 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frontend/src/app/main/data/dashboard.cljs
View file

@ -893,8 +893,8 @@
(update [_ state]
(let [origin-project (get-in state [:dashboard-files (first ids) :project-id])]
(-> state
(d/update-in-when [:dashboard-projects origin-project :count] #(- % (count ids)))
(d/update-in-when [:dashboard-projects project-id :count] #(+ % (count ids))))))
(d/update-in-when [:dashboard-projects origin-project] update :count #(- % (count ids)))
(d/update-in-when [:dashboard-projects project-id] update :count #(+ % (count ids))))))
ptk/WatchEvent
(watch [_ _ _]

43
frontend/src/app/main/ui/dashboard.cljs
View file

@ -159,8 +159,8 @@
[:span (tr "dashboard.libraries-and-templates")]
[:span.icon (if collapsed i/arrow-up i/arrow-down)]]]
[:div.content {:ref content-ref
:style {:left @card-offset :width (str container-size "px")}}
:style {:left @card-offset :width (str container-size "px")}}
(for [num-item (range (count templates)) :let [item (nth templates num-item)]]
(let [is-visible? (and (>= num-item first-visible-card) (<= num-item last-visible-card))]
[:a.card-container {:tab-index (if (or (not is-visible?) collapsed)
@ -227,25 +227,31 @@
[{:keys [team projects project section search-term profile] :as props}]
(let [container (mf/use-ref)
content-width (mf/use-state 0)
default-project-id
(->> (vals projects)
(d/seek :is-default)
(:id))
on-resize
(fn [_]
(let [dom (mf/ref-val container)
width (obj/get dom "clientWidth")]
(reset! content-width width)))]
(mf/use-effect
#(let [key1 (events/listen js/window "resize" on-resize)]
(fn []
(events/unlistenByKey key1))))
default-project-id
(mf/with-memo [projects]
(->> (vals projects)
(d/seek :is-default)
(:id)))
on-resize
(mf/use-fn
(fn [_]
(let [dom (mf/ref-val container)
width (obj/get dom "clientWidth")]
(reset! content-width width))))
clear-selected-fn
(mf/use-fn
#(st/emit! (dd/clear-selected-files)))]
(mf/with-effect []
(let [key1 (events/listen js/window "resize" on-resize)]
#(events/unlistenByKey key1)))
(mf/use-effect on-resize)
[:div.dashboard-content {:on-click #(st/emit! (dd/clear-selected-files))
:ref container}
[:div.dashboard-content {:on-click clear-selected-fn :ref container}
(case section
:dashboard-projects
[:*
@ -280,8 +286,7 @@
:search-term search-term}]
:dashboard-libraries
[*
[:& libraries-page {:team team}]]
[:& libraries-page {:team team}]
:dashboard-team-members
[:& team-members-page {:team team :profile profile}]

4
frontend/src/app/main/ui/dashboard/file_menu.cljs
View file

@ -131,7 +131,7 @@
on-move
(fn [team-id project-id]
(let [params {:ids (set (map :id files))
(let [params {:ids (into #{} (map :id) files)
:project-id project-id}]
(fn []
(st/emit! (dd/move-files
@ -213,7 +213,7 @@
(rx/map group-by-team)
(rx/subs #(when (mf/ref-val mounted-ref)
(reset! teams %)))))))
(when current-team
(let [sub-options (concat (vec (for [project current-projects]
{:option-name (get-project-name project)

8
frontend/src/app/main/ui/dashboard/files.cljs
View file

@ -39,7 +39,7 @@
on-menu-click
(mf/use-fn
(fn [event]
(let [position (dom/get-client-position event)]
(let [position (dom/get-client-position event)]
(dom/prevent-default event)
(swap! local assoc :menu-open true :menu-pos position))))
@ -64,7 +64,7 @@
[:header.dashboard-header
(if (:is-default project)
[:div.dashboard-title#dashboard-drafts-title
[:div.dashboard-title#dashboard-drafts-title
[:h1 (tr "labels.drafts")]]
(if (:edition @local)
@ -90,7 +90,7 @@
:on-import on-import}]
[:div.dashboard-header-actions
[:a.btn-secondary.btn-small
[:a.btn-secondary.btn-small
{:tab-index "0"
:on-click on-create-click
:data-test "new-file"
@ -114,7 +114,7 @@
[:div.icon.tooltip.tooltip-bottom-left
{:tab-index "0"
:on-click on-menu-click
:on-click on-menu-click
:alt (tr "dashboard.options")
:on-key-down (fn [event]
(when (kbd/enter? event)