Merge pull request #2455 from penpot/superalex-fix-notification-for-newsletter-shown-in-all-cases

🐛 Fix notification for newsletter shown in all cases

CHANGES.md

@@ -56,6 +56,7 @@
 
 - Fix artboard border radius [Taiga #4291](https://tree.taiga.io/project/penpot/issue/4291)
 - Fix copied & pasted layer is not visible [Taiga #4283](https://tree.taiga.io/project/penpot/issue/4283)
+- Fix notification to newsletter is shown in all cases [Taiga #4367](https://tree.taiga.io/project/penpot/issue/4367)
 
 ## 1.15.4-beta
 

frontend/src/app/main/ui/onboarding/newsletter.cljs

@@ -30,9 +30,10 @@
         (mf/use-callback
          (mf/deps @newsletter-updates @newsletter-news)
          (fn []
-           (st/emit! (dm/success message)
-                       (modal/show {:type :onboarding-team})
-                       (du/update-profile-props {:newsletter-updates @newsletter-updates :newsletter-news @newsletter-news}))))]
+           (st/emit! (when (or @newsletter-updates @newsletter-news)
+                       (dm/success message))
+                     (modal/show {:type :onboarding-team})
+                     (du/update-profile-props {:newsletter-updates @newsletter-updates :newsletter-news @newsletter-news}))))]
 
     [:div.modal-overlay
      [:div.modal-container.onboarding.newsletter.animated.fadeInDown