From b05ca4bb82aaa31345c28f8f33bd2e44baef882f Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sat, 4 Feb 2023 11:33:27 +0100 Subject: [PATCH] :bug: Fix undefined name RuntimeException on manage.py script Python defines [`RuntimeError`](https://docs.python.org/3.7/library/exceptions.html#RuntimeError) but it does not define `RuntimeException` so a `NameError` will be raised when any of these lines are executed. % `python3 -c "RuntimeException('This is a test...')"` ``` Traceback (most recent call last): File "", line 1, in NameError: name 'RuntimeException' is not defined ``` % `flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics` ``` ./backend/scripts/manage.py:22:15: F821 undefined name 'RuntimeException' raise RuntimeException(f"invalid PREPL_URI: {PREPL_URI}") ^ ./backend/scripts/manage.py:25:15: F821 undefined name 'RuntimeException' raise RuntimeException(f"invalid PREPL_URI: {PREPL_URI}") ^ ./backend/scripts/manage.py:49:23: F821 undefined name 'RuntimeException' raise RuntimeException("unexpected response from PREPL") ^ 3 F821 undefined name 'RuntimeException' 3 ``` --- backend/scripts/manage.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/backend/scripts/manage.py b/backend/scripts/manage.py index fd78d1a91..ea90d3e86 100755 --- a/backend/scripts/manage.py +++ b/backend/scripts/manage.py @@ -19,10 +19,10 @@ PREPL_URI = "tcp://localhost:6063" def get_prepl_conninfo(): uri_data = urlparse(PREPL_URI) if uri_data.scheme != "tcp": - raise RuntimeException(f"invalid PREPL_URI: {PREPL_URI}") + raise RuntimeError(f"invalid PREPL_URI: {PREPL_URI}") if not isinstance(uri_data.netloc, str): - raise RuntimeException(f"invalid PREPL_URI: {PREPL_URI}") + raise RuntimeError(f"invalid PREPL_URI: {PREPL_URI}") host, port = uri_data.netloc.split(":", 2) @@ -46,7 +46,7 @@ def send_eval(expr): result = json.load(f) tag = result.get("tag", None) if tag != "ret": - raise RuntimeException("unexpected response from PREPL") + raise RuntimeError("unexpected response from PREPL") return result.get("val", None), result.get("exception", None) def encode(val):