Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-01-26 08:29:42 -05:00
Code Issues Activity

🐛 Fix bug in firefox when a text box is inside a mask

Browse source
This commit is contained in:
alonso.torres 2021-10-11 12:15:38 +02:00
parent d2d506dbf0
commit ad18604552
2 changed files with 19 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGES.md
View file

@ -37,6 +37,7 @@
- Fix shift+wheel to horizontal scrolling in MacOS [#1217](https://github.com/penpot/penpot/issues/1217) - Fix shift+wheel to horizontal scrolling in MacOS [#1217](https://github.com/penpot/penpot/issues/1217)
- Fix path stroke is not working properly with high thickness [Taiga #2154](https://tree.taiga.io/project/penpot/issue/2154) - Fix path stroke is not working properly with high thickness [Taiga #2154](https://tree.taiga.io/project/penpot/issue/2154)
- Fix bug with transformation operations [Taiga #2155](https://tree.taiga.io/project/penpot/issue/2155) - Fix bug with transformation operations [Taiga #2155](https://tree.taiga.io/project/penpot/issue/2155)
- Fix bug in firefox when a text box is inside a mask [Taiga #2152](https://tree.taiga.io/project/penpot/issue/2152)
### :arrow_up: Deps updates ### :arrow_up: Deps updates

26
frontend/src/app/main/ui/shapes/group.cljs
View file

@ -27,21 +27,31 @@
[(first childs) (rest childs)] [(first childs) (rest childs)]
[nil childs]) [nil childs])
;; We need to separate mask and clip into two because a bug in Firefox
;; breaks when the group has clip+mask+foreignObject
;; Clip and mask separated will work in every platform
; Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1734805
[clip-wrapper clip-props]
(if masked-group?
["g" (-> (obj/new)
(obj/set! "clipPath" (clip-url render-id mask)))]
[mf/Fragment nil])
[mask-wrapper mask-props] [mask-wrapper mask-props]
(if masked-group? (if masked-group?
["g" (-> (obj/new) ["g" (-> (obj/new)
(obj/set! "clipPath" (clip-url render-id mask))
(obj/set! "mask" (mask-url render-id mask)))] (obj/set! "mask" (mask-url render-id mask)))]
[mf/Fragment nil])] [mf/Fragment nil])]
[:> mask-wrapper mask-props [:> clip-wrapper clip-props
(when masked-group? [:> mask-wrapper mask-props
[:> render-mask #js {:frame frame :mask mask}]) (when masked-group?
[:> render-mask #js {:frame frame :mask mask}])
(for [item childs] (for [item childs]
[:& shape-wrapper {:frame frame [:& shape-wrapper {:frame frame
:shape item :shape item
:key (:id item)}])])))) :key (:id item)}])]]))))