Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-01-20 13:42:59 -05:00
Code Issues Activity

🐛 Fix missing active sets in set groups showing partial selection

Browse source
This commit is contained in:
Florian Schroedl 2024-12-10 14:04:32 +01:00
parent 5ff3469da7
commit aa292e4829
2 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
common/src/app/common/types/tokens_lib.cljc
View file

@ -882,9 +882,10 @@ Will return a value that matches this schema:
(map :name) (map :name)
(into #{})) (into #{}))
difference (set/difference path-active-set-names active-set-names)] difference (set/difference path-active-set-names active-set-names)]
(if (empty? difference) (cond
:all (empty? difference) :all
:partial)) (seq (set/intersection path-active-set-names active-set-names)) :partial
:else :none))
:none))) :none)))
(get-active-themes-set-tokens [this] (get-active-themes-set-tokens [this]

12
common/test/common_tests/types/tokens_lib_test.cljc
View file

@ -412,7 +412,9 @@
:sets #{"foo/bar/baz"})) :sets #{"foo/bar/baz"}))
(ctob/add-theme (ctob/make-token-theme :name "all" (ctob/add-theme (ctob/make-token-theme :name "all"
:sets #{"foo/bar/baz" :sets #{"foo/bar/baz"
"foo/bar/bam"}))) "foo/bar/bam"}))
(ctob/add-theme (ctob/make-token-theme :name "invalid"
:sets #{"foo/missing"})))
expected-none (-> tokens-lib expected-none (-> tokens-lib
(ctob/set-active-themes #{"/none"}) (ctob/set-active-themes #{"/none"})
@ -422,10 +424,14 @@
(ctob/sets-at-path-all-active? "G-foo")) (ctob/sets-at-path-all-active? "G-foo"))
expected-partial (-> tokens-lib expected-partial (-> tokens-lib
(ctob/set-active-themes #{"/partial"}) (ctob/set-active-themes #{"/partial"})
(ctob/sets-at-path-all-active? "G-foo"))] (ctob/sets-at-path-all-active? "G-foo"))
expected-invalid-none (-> tokens-lib
(ctob/set-active-themes #{"/invalid"})
(ctob/sets-at-path-all-active? "G-foo"))]
(t/is (= :none expected-none)) (t/is (= :none expected-none))
(t/is (= :all expected-all)) (t/is (= :all expected-all))
(t/is (= :partial expected-partial))))) (t/is (= :partial expected-partial))
(t/is (= :none expected-invalid-none)))))
(t/deftest token-theme-in-a-lib (t/deftest token-theme-in-a-lib
(t/testing "add-token-theme" (t/testing "add-token-theme"