From a549d783ba435e8d03b9c5b91ef567e635fc8c74 Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Tue, 25 Feb 2025 12:49:33 +0100 Subject: [PATCH] :sparkles: Downgrade s3 sdk for compatibility with minio (#5946) * :books: Add `:arrow_down:` emoji to the contributing guide For cases where we need to downgrade dependencies * :sparkles: Downgrade S3 SDK version Mainly for minio and other S3-compatible services --- .github/workflows/commit-checker.yml | 2 +- CONTRIBUTING.md | 1 + backend/deps.edn | 3 +-- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/commit-checker.yml b/.github/workflows/commit-checker.yml index 7ad5c1101..b5e0efbbe 100644 --- a/.github/workflows/commit-checker.yml +++ b/.github/workflows/commit-checker.yml @@ -26,7 +26,7 @@ jobs: - name: Check Commit Type uses: gsactions/commit-message-checker@v2 with: - pattern: '^:(lipstick|globe_with_meridians|wrench|books|arrow_up|zap|ambulance|construction|boom|fire|whale|bug|sparkles|paperclip|tada|recycle):\s[A-Z].*[^.]$' + pattern: '^:(lipstick|globe_with_meridians|wrench|books|arrow_up|arrow_down|zap|ambulance|construction|boom|fire|whale|bug|sparkles|paperclip|tada|recycle):\s[A-Z].*[^.]$' flags: 'gm' error: 'Commit should match CONTRIBUTING.md guideline' checkAllCommitMessages: 'true' # optional: this checks all commits associated with a pull request diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f183b34d6..58a4bf68a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -84,6 +84,7 @@ Where type is: - :whale: `:whale:` a commit for docker related stuff - :paperclip: `:paperclip:` a commit with other not relevant changes - :arrow_up: `:arrow_up:` a commit with dependencies updates +- :arrow_down: `:arrow_down:` a commit with dependencies downgrades - :fire: `:fire:` a commit that removes files or code More info: diff --git a/backend/deps.edn b/backend/deps.edn index 52c8f0dee..75187d746 100644 --- a/backend/deps.edn +++ b/backend/deps.edn @@ -59,8 +59,7 @@ ;; Pretty Print specs pretty-spec/pretty-spec {:mvn/version "0.1.4"} - software.amazon.awssdk/s3 {:mvn/version "2.30.26"} - } + software.amazon.awssdk/s3 {:mvn/version "2.28.26"}} :paths ["src" "resources" "target/classes"] :aliases