Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-02-11 01:28:30 -05:00
Code Issues Activity

📎 Add some FIXME comments for future refactors

Browse source
This commit is contained in:
Andrey Antukh 2024-02-29 16:12:59 +01:00 • committed by Alonso Torres
parent 97e7806bdb
commit a3faca910f
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frontend/src/app/main/refs.cljs
View file

@ -539,6 +539,7 @@
(every? (partial ctl/grid-layout-immediate-child? objects)))) (every? (partial ctl/grid-layout-immediate-child? objects))))
workspace-page-objects =)) workspace-page-objects =))
;; FIXME: move to viewer.inspect.code
(defn get-flex-child-viewer (defn get-flex-child-viewer
[ids page-id] [ids page-id]
(l/derived (l/derived
@ -550,7 +551,7 @@
ids))) ids)))
st/state =)) st/state =))
;; FIXME: move to viewer.inspect.code
(defn get-viewer-objects (defn get-viewer-objects
([] ([]
(let [route (deref route) (let [route (deref route)

5
frontend/src/app/main/ui/viewer/inspect/code.cljs
View file

@ -50,7 +50,9 @@
</body> </body>
</html>") </html>")
(defn get-flex-elements [page-id shapes from] ;; FIXME: rename to hook naming convention
(defn get-flex-elements
[page-id shapes from]
(let [ids (mapv :id shapes) (let [ids (mapv :id shapes)
ids (hooks/use-equal-memo ids) ids (hooks/use-equal-memo ids)
@ -63,6 +65,7 @@
(mf/deref get-layout-children-refs))) (mf/deref get-layout-children-refs)))
;; FIXME: rename to hook naming convention
(defn get-objects [from] (defn get-objects [from]
(let [page-objects-ref (let [page-objects-ref
(mf/use-memo (mf/use-memo