Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-01-21 06:02:32 -05:00
Code Issues Activity

Parse values with unit

Browse source
This commit is contained in:
Florian Schroedl 2024-08-08 15:12:28 +02:00
parent 2d67a92d64
commit 8b8b909fb7
3 changed files with 29 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
frontend/src/app/main/ui/workspace/tokens/style_dictionary.cljs
View file

@ -6,8 +6,7 @@
[app.main.ui.workspace.tokens.token :as wtt]
[cuerdas.core :as str]
[promesa.core :as p]
[rumext.v2 :as mf]
[shadow.resource]))
[rumext.v2 :as mf]))
(def StyleDictionary
"The global StyleDictionary instance used as an external library for now,
@ -82,10 +81,12 @@
(fn [acc ^js cur]
(let [id (uuid (.-uuid (.-id cur)))
origin-token (get tokens id)
resolved-value (wtt/parse-token-value (.-value cur))
resolved-token (if (not resolved-value)
parsed-value (wtt/parse-token-value (.-value cur))
resolved-token (if (not parsed-value)
(assoc origin-token :errors [:style-dictionary/missing-reference])
(assoc origin-token :resolved-value resolved-value))]
(assoc origin-token
:resolved-value (:value parsed-value)
:resolved-unit (:unit parsed-value)))]
(assoc acc (wtt/token-identifier resolved-token) resolved-token)))
{} sd-tokens)]
(when debug?
@ -157,9 +158,12 @@
(#(resolve-sd-tokens+ % {:debug? true})))
(defonce output (atom nil))
(require '[shadow.resource])
(let [example (-> (shadow.resource/inline "./data/example-tokens-set.json")
(js/JSON.parse)
.-core)]
(resolve-sd-tokens+ example {:debug? true}))
(.then (resolve-sd-tokens+ example {:debug? true})
#(reset! output %)))
nil)

11
frontend/src/app/main/ui/workspace/tokens/token.cljs
View file

@ -5,14 +5,15 @@
[cuerdas.core :as str]))
(def parseable-token-value-regexp
#"^\s*(-?[0-9]+\.?[0-9]*)\s*$")
#"^\s*(-?[0-9]+\.?[0-9]*)(px|%)?\s*$")
(defn parse-token-value [value]
(cond
(number? value) value
(string? value) (when-let [double-str (-> (re-find parseable-token-value-regexp value)
(last))]
(d/parse-double double-str))))
(number? value) {:value value}
(string? value) (when-let [[_ value unit] (re-find parseable-token-value-regexp value)]
(when-let [parsed-value (d/parse-double value)]
{:value parsed-value
:unit unit}))))
(defn find-token-references
"Finds token reference values in `value-string` and returns a set with all contained namespaces."

21
frontend/test/token_tests/token_test.cljs
View file

@ -11,14 +11,19 @@
(t/deftest test-parse-token-value
(t/testing "parses double from a token value"
(t/is (= 100.1 (wtt/parse-token-value "100.1")))
(t/is (= -9 (wtt/parse-token-value "-9")))
(t/testing "trims white-space"
(t/is (= -1.3 (wtt/parse-token-value " -1.3 "))))
(t/testing "returns nil for any invalid characters"
(t/is (nil? (wtt/parse-token-value " -1.3a "))))
(t/testing "doesnt accept invalid double"
(t/is (nil? (wtt/parse-token-value ".3"))))))
(t/is (= {:value 100.1 :unit nil} (wtt/parse-token-value "100.1")))
(t/is (= {:value -9 :unit nil} (wtt/parse-token-value "-9"))))
(t/testing "trims white-space"
(t/is (= {:value -1.3 :unit nil} (wtt/parse-token-value " -1.3 "))))
(t/testing "parses unit: px"
(t/is (= {:value 70.3 :unit "px"} (wtt/parse-token-value " 70.3px "))))
(t/testing "parses unit: %"
(t/is (= {:value -10 :unit "%"} (wtt/parse-token-value "-10%"))))
(t/testing "parses unit: px")
(t/testing "returns nil for any invalid characters"
(t/is (nil? (wtt/parse-token-value " -1.3a "))))
(t/testing "doesnt accept invalid double"
(t/is (nil? (wtt/parse-token-value ".3")))))
(t/deftest find-token-references
(t/testing "finds references inside curly braces in a string"