From 80ef69c7106934a8dbe8601c48f15e5252fae7c7 Mon Sep 17 00:00:00 2001 From: Alejandro Alonso Date: Wed, 23 Mar 2022 14:07:15 +0100 Subject: [PATCH 1/2] :bug: Fix sorting on multiple export --- frontend/src/app/main/data/exports.cljs | 2 +- frontend/src/app/main/ui/workspace/header.cljs | 2 +- .../app/main/ui/workspace/sidebar/options/menus/exports.cljs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/src/app/main/data/exports.cljs b/frontend/src/app/main/data/exports.cljs index d9d787dc4..44946090f 100644 --- a/frontend/src/app/main/data/exports.cljs +++ b/frontend/src/app/main/data/exports.cljs @@ -61,7 +61,7 @@ shapes (if (seq selected) (wsh/lookup-shapes state selected) - (wsh/filter-shapes state #(pos? (count (:exports %))))) + (reverse (wsh/filter-shapes state #(pos? (count (:exports %)))))) exports (for [shape shapes export (:exports shape)] diff --git a/frontend/src/app/main/ui/workspace/header.cljs b/frontend/src/app/main/ui/workspace/header.cljs index b3c60a0a5..28a4831cd 100644 --- a/frontend/src/app/main/ui/workspace/header.cljs +++ b/frontend/src/app/main/ui/workspace/header.cljs @@ -186,7 +186,7 @@ (mf/use-callback (mf/deps file frames) (fn [_] - (st/emit! (de/show-workspace-export-frames-dialog frames)))) + (st/emit! (de/show-workspace-export-frames-dialog (reverse frames))))) on-item-hover (mf/use-callback diff --git a/frontend/src/app/main/ui/workspace/sidebar/options/menus/exports.cljs b/frontend/src/app/main/ui/workspace/sidebar/options/menus/exports.cljs index c28bcccb1..27bb3fd6a 100644 --- a/frontend/src/app/main/ui/workspace/sidebar/options/menus/exports.cljs +++ b/frontend/src/app/main/ui/workspace/sidebar/options/menus/exports.cljs @@ -49,7 +49,7 @@ (fn [event] (dom/prevent-default event) (if (= :multiple type) - (st/emit! (de/show-workspace-export-dialog {:selected ids})) + (st/emit! (de/show-workspace-export-dialog {:selected (reverse ids)})) ;; In other all cases we only allowed to have a single ;; shape-id because multiple shape-ids are handled From 88ad68069c75ec6b16d9070eb7ed3325d2c9ee34 Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Wed, 23 Mar 2022 14:15:46 +0100 Subject: [PATCH 2/2] :books: Update contributing file --- CONTRIBUTING.md | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f716777a1..d28328cca 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -93,12 +93,24 @@ More info: Each commit should have: - A concise subject using imperative mood. -- The subject should have capitalized the first letter and without - period at the end. +- The subject should have capitalized the first letter, without period + at the end and no larger than 65 characters. - A blank line between the subject line and the body. - An entry on the CHANGES.md file if applicable, referencing the github or taiga issue/user-story using the these same rules. +Examples of good commit messags: + +- :bug: Fix unexpected error on launching modal +- :bug: Set proper error message on generic error +- :sparkles: Enable new modal for profile +- :zap: Improve performance of dashboard navigation +- :wrench: Update default backend configuration +- :books: Add more documentation for authentication process +- :ambulance: Fix critical bug on user registration process +- :tada: Add new approach for user registration + + ## Code of conduct ## As contributors and maintainers of this project, we pledge to respect