Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-01-24 07:29:08 -05:00
Code Issues Activity

✨ Minor api improvements on dropdown component.

Browse source
This commit is contained in:
Andrey Antukh 2020-04-02 17:06:29 +02:00
parent ec04bb4160
commit 759530ea58
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frontend/src/uxbox/main/ui/components/context_menu.cljs
View file

@ -2,7 +2,7 @@
(:require
[rumext.alpha :as mf]
[goog.object :as gobj]
[uxbox.main.ui.components.dropdown :refer [dropdown-container]]
[uxbox.main.ui.components.dropdown :refer [dropdown']]
[uxbox.util.uuid :as uuid]
[uxbox.util.data :refer [classnames]]))
@ -18,7 +18,7 @@
is-selectable (gobj/get props "selectable")
selected (gobj/get props "selected")]
(when open?
[:> dropdown-container props
[:> dropdown' props
[:div.context-menu {:class (classnames :is-open open?
:is-selectable is-selectable)}
[:ul.context-menu-items

13
frontend/src/uxbox/main/ui/components/dropdown.cljs
View file

@ -2,20 +2,27 @@
(:require
[rumext.alpha :as mf]
[uxbox.util.uuid :as uuid]
[uxbox.util.dom :as dom]
[goog.events :as events]
[goog.object :as gobj])
(:import goog.events.EventType
goog.events.KeyCodes))
(mf/defc dropdown-container
(mf/defc dropdown'
{::mf/wrap-props false}
[props]
(let [children (gobj/get props "children")
on-close (gobj/get props "on-close")
ref (gobj/get props "container")
on-click
(fn [event]
(on-close))
(if ref
(let [target (dom/get-target event)
parent (mf/ref-val ref)]
(when-not (.contains parent target)
(on-close)))
(on-close)))
on-keyup
(fn [event]
@ -40,4 +47,4 @@
(assert (boolean? (gobj/get props "show")) "missing `show` prop")
(when (gobj/get props "show")
(mf/element dropdown-container props)))
(mf/element dropdown' props)))