Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-04-04 11:01:20 -05:00
Code Issues Activity

🐛 Add workaround for unexpected exception on fix-broken-shapes

Browse source 
which happens when we have a component shape tree with an ephimeral
shape with id ZERO (unused and with invalid children)
This commit is contained in:
Andrey Antukh 2023-08-07 11:12:27 +02:00
parent 7afaa9d31f
commit 6e313dff84
1 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
frontend/src/app/main/data/workspace/fix_broken_shape_links.cljs
View file

@ -11,13 +11,28 @@
[potok.core :as ptk]))
(defn- generate-changes
[attr {:keys [objects id]}]
[attr {:keys [objects id] :as container}]
(let [base {:type :fix-obj attr id}
contains? (partial contains? objects)
xform (comp
(remove #(every? contains? (:shapes %)))
(map #(assoc base :id (:id %))))]
(sequence xform (vals objects))))
;; FIXME: Ensure all obj have id field (this is needed
;; because some bug adds an ephimeral shape with id ZERO,
;; with a single attr `:shapes` having a vector of ids
;; pointing to not existing shapes). That happens on
;; components. THIS IS A WORKAOURD
(map (fn [[id obj]]
(if (some? (:id obj))
obj
(assoc obj :id id))))
;; Remove all valid shapes
(remove (fn [obj]
(every? contains? (:shapes obj))))
(map (fn [obj]
(assoc base :id (:id obj)))))]
(sequence xform objects)))
(defn fix-broken-shapes
[]