Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-01-21 14:12:36 -05:00
Code Issues Activity

Merge pull request #133 from tokens-studio/editing-tokens

Browse source 
:feat editing tokens
This commit is contained in:
Akshay Gupta 2024-05-24 18:13:00 +05:30 • committed by GitHub
commit 65563e2d3c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 33 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
frontend/src/app/main/ui/workspace/tokens/context_menu.cljs
View file

@ -10,6 +10,7 @@
[app.common.data :as d] [app.common.data :as d]
[app.common.data.macros :as dm] [app.common.data.macros :as dm]
[app.main.data.events :as ev] [app.main.data.events :as ev]
[app.main.data.modal :as modal]
[app.main.data.shortcuts :as scd] [app.main.data.shortcuts :as scd]
[app.main.data.tokens :as dt] [app.main.data.tokens :as dt]
[app.main.data.workspace :as dw] [app.main.data.workspace :as dw]
@ -27,10 +28,20 @@
(l/derived :token-context-menu refs/workspace-local)) (l/derived :token-context-menu refs/workspace-local))
(mf/defc token-pill-context-menu (mf/defc token-pill-context-menu
[{:keys [token-id]}] [{:keys [token-id token-type-props]}]
(let [do-delete #(st/emit! (dt/delete-token token-id)) (let [{:keys [modal attributes title]} token-type-props
do-delete #(st/emit! (dt/delete-token token-id))
do-duplicate #(st/emit! (dt/duplicate-token token-id)) do-duplicate #(st/emit! (dt/duplicate-token token-id))
do-edit #(js/console.log "Editing")] do-edit (fn [event]
(let [{:keys [key fields]} modal
token (dt/get-token-data-from-token-id token-id)]
(st/emit! dt/hide-token-context-menu)
(dom/stop-propagation event)
(modal/show! key {:x (.-clientX ^js event)
:y (.-clientY ^js event)
:position :right
:fields fields
:token token})))]
[:* [:*
[:& menu-entry {:title "Delete Token" :on-click do-delete}] [:& menu-entry {:title "Delete Token" :on-click do-delete}]
[:& menu-entry {:title "Duplicate Token" :on-click do-duplicate}] [:& menu-entry {:title "Duplicate Token" :on-click do-duplicate}]
@ -64,4 +75,5 @@
:on-context-menu prevent-default} :on-context-menu prevent-default}
(when (= :token (:type mdata)) (when (= :token (:type mdata))
[:ul {:class (stl/css :context-list)} [:ul {:class (stl/css :context-list)}
[:& token-pill-context-menu {:token-id (:token-id mdata)}]])]])) [:& token-pill-context-menu {:token-id (:token-id mdata)
:token-type-props (:token-type-props mdata)}]])]]))

22
frontend/src/app/main/ui/workspace/tokens/modal.cljs
View file

@ -43,18 +43,24 @@
(mf/defc tokens-properties-form (mf/defc tokens-properties-form
{::mf/wrap-props false} {::mf/wrap-props false}
[{:keys [token-type x y position fields]}] [{:keys [token-type x y position fields token]}]
(let [vport (mf/deref viewport) (let [vport (mf/deref viewport)
style (calculate-position vport position x y) style (calculate-position vport position x y)
name (mf/use-var nil) name (mf/use-var (or (:name token) ""))
on-update-name #(reset! name (dom/get-target-val %)) on-update-name #(reset! name (dom/get-target-val %))
name-ref (mf/use-ref) name-ref (mf/use-ref)
description (mf/use-var nil) token-value (mf/use-var (or (:value token) ""))
description (mf/use-var (or (:description token) ""))
on-update-description #(reset! description (dom/get-target-val %)) on-update-description #(reset! description (dom/get-target-val %))
state (mf/use-state fields) initial-fields (mapv (fn [field]
(assoc field :value (or (:value token) "")))
fields)
state (mf/use-state initial-fields)
on-update-state-field (fn [idx e] on-update-state-field (fn [idx e]
(->> (dom/get-target-val e) (->> (dom/get-target-val e)
(assoc-in @state [idx :value]) (assoc-in @state [idx :value])
@ -66,9 +72,10 @@
(first) (first)
(val)) (val))
token (cond-> {:name @name token (cond-> {:name @name
:type token-type :type (or (:type token) token-type)
:value token-value} :value token-value}
@description (assoc :description @description))] @description (assoc :description @description)
(:id token) (assoc :id (:id token)))]
(st/emit! (dt/add-token token)) (st/emit! (dt/add-token token))
(modal/hide!)))] (modal/hide!)))]
@ -82,6 +89,7 @@
:on-submit on-submit} :on-submit on-submit}
[:div {:class (stl/css :token-rows)} [:div {:class (stl/css :token-rows)}
[:& tokens.common/labeled-input {:label "Name" [:& tokens.common/labeled-input {:label "Name"
:default-value @name
:on-change on-update-name :on-change on-update-name
:input-ref name-ref}] :input-ref name-ref}]
(for [[idx {:keys [type label]}] (d/enumerate @state)] (for [[idx {:keys [type label]}] (d/enumerate @state)]
@ -89,8 +97,10 @@
(case type (case type
:box-shadow [:p "TODO BOX SHADOW"] :box-shadow [:p "TODO BOX SHADOW"]
[:& tokens.common/labeled-input {:label label [:& tokens.common/labeled-input {:label label
:default-value @token-value
:on-change #(on-update-state-field idx %)}])]) :on-change #(on-update-state-field idx %)}])])
[:& tokens.common/labeled-input {:label "Description" [:& tokens.common/labeled-input {:label "Description"
:default-value @description
:on-change #(on-update-description %)}] :on-change #(on-update-description %)}]
[:div {:class (stl/css :button-row)} [:div {:class (stl/css :button-row)}
[:button {:class (stl/css :button) [:button {:class (stl/css :button)

1
frontend/src/app/main/ui/workspace/tokens/sidebar.cljs
View file

@ -67,6 +67,7 @@
(dom/stop-propagation event) (dom/stop-propagation event)
(st/emit! (dt/show-token-context-menu {:type :token (st/emit! (dt/show-token-context-menu {:type :token
:position (dom/get-client-position event) :position (dom/get-client-position event)
:token-type-props token-type-props
:token-id (:id token)})))) :token-id (:id token)}))))
on-toggle-open-click (mf/use-fn on-toggle-open-click (mf/use-fn