From 21ec8bfdacc5af2e85e95b74c99376c14a01fad6 Mon Sep 17 00:00:00 2001 From: Pablo Alba Date: Wed, 7 Sep 2022 16:57:22 +0200 Subject: [PATCH 01/10] :bug: Fix undo after moving layers will wrongly order the layers --- CHANGES.md | 1 + common/src/app/common/pages/changes_builder.cljc | 9 ++++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 887eec0a8..ea6e12899 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -9,6 +9,7 @@ - Fix problem when hovering over nested frames [Taiga #4018](https://tree.taiga.io/project/penpot/issue/4018) - Fix problem editing rotated texts [Taiga #4026](https://tree.taiga.io/project/penpot/issue/4026) - Fix problem with texts for non existing fonts [Taiga #4087](https://tree.taiga.io/project/penpot/issue/4087) +- Fix undo after moving layers will wrongly order the layers [Taiga #3344](https://tree.taiga.io/project/penpot/issue/3344) ## 1.15.2-beta diff --git a/common/src/app/common/pages/changes_builder.cljc b/common/src/app/common/pages/changes_builder.cljc index 25808b136..db3a1c7f8 100644 --- a/common/src/app/common/pages/changes_builder.cljc +++ b/common/src/app/common/pages/changes_builder.cljc @@ -243,13 +243,20 @@ mk-undo-change (fn [change-set shape] + (let [idx (or (cph/get-position-on-parent objects (:id shape)) 0) + ;; Different index if the movement was from top to bottom or the other way + ;; Similar that on frontend/src/app/main/ui/workspace/sidebar/layers.cljs + ;; with the 'side' property of the on-drop + idx (if (< index idx) + (inc idx) + idx)] (d/preconj change-set {:type :mov-objects :page-id (::page-id (meta changes)) :parent-id (:parent-id shape) :shapes [(:id shape)] - :index (cph/get-position-on-parent objects (:id shape))}))] + :index idx})))] (-> changes (update :redo-changes conj set-parent-change) From f7aba14f7613d83b5ac35d1fa40e4c5ad2f9b6f1 Mon Sep 17 00:00:00 2001 From: Pablo Alba Date: Tue, 6 Sep 2022 11:29:18 +0200 Subject: [PATCH 02/10] bug: Fix Grouping typographies by drag & drop does not work (again) --- CHANGES.md | 1 + .../app/main/data/workspace/libraries.cljs | 12 ++++++++-- .../app/main/ui/workspace/sidebar/assets.cljs | 24 ++----------------- 3 files changed, 13 insertions(+), 24 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index ea6e12899..81657efec 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -10,6 +10,7 @@ - Fix problem editing rotated texts [Taiga #4026](https://tree.taiga.io/project/penpot/issue/4026) - Fix problem with texts for non existing fonts [Taiga #4087](https://tree.taiga.io/project/penpot/issue/4087) - Fix undo after moving layers will wrongly order the layers [Taiga #3344](https://tree.taiga.io/project/penpot/issue/3344) +- Fix Grouping typographies by drag & drop does not work (again) [#2203](https://github.com/penpot/penpot/issues/2203) ## 1.15.2-beta diff --git a/frontend/src/app/main/data/workspace/libraries.cljs b/frontend/src/app/main/data/workspace/libraries.cljs index de23cd4b2..92f3fea28 100644 --- a/frontend/src/app/main/data/workspace/libraries.cljs +++ b/frontend/src/app/main/data/workspace/libraries.cljs @@ -87,6 +87,15 @@ (update [_ state] (assoc-in state [:workspace-global :assets-files-open file-id :groups box path] open?)))) +(defn extract-path-if-missing + [item] + (let [[path name] (cph/parse-path-name (:name item))] + (if (and + (= (:name item) name) + (contains? item :path)) + item + (assoc item :path path :name name)))) + (defn default-color-name [color] (or (:color color) (case (get-in color [:gradient :type]) @@ -235,8 +244,7 @@ (defn- do-update-tipography [it state typography file-id] (let [data (get state :workspace-data) - [path name] (cph/parse-path-name (:name typography)) - typography (assoc typography :path path :name name) + typography (extract-path-if-missing typography) changes (-> (pcb/empty-changes it) (pcb/with-library-data data) (pcb/update-typography typography))] diff --git a/frontend/src/app/main/ui/workspace/sidebar/assets.cljs b/frontend/src/app/main/ui/workspace/sidebar/assets.cljs index ed2dcc426..0c730fbe5 100644 --- a/frontend/src/app/main/ui/workspace/sidebar/assets.cljs +++ b/frontend/src/app/main/ui/workspace/sidebar/assets.cljs @@ -891,18 +891,8 @@ multi-assets? (or (seq (:components selected-assets)) (seq (:colors selected-assets)) (seq (:typographies selected-assets))) - - extract-path-if-missing - (fn [graphic] - (let [[path name] (cph/parse-path-name (:name graphic))] - (if (and - (= (:name graphic) name) - (contains? graphic :path)) - graphic - (assoc graphic :path path :name name)))) - objects (->> objects - (map extract-path-if-missing)) + (map dwl/extract-path-if-missing)) groups (group-assets objects reverse-sort?) @@ -1633,18 +1623,8 @@ local-data (mf/deref typography-data) menu-state (mf/use-state auto-pos-menu-state) - - extract-path-if-missing - (fn [typography] - (let [[path name] (cph/parse-path-name (:name typography))] - (if (and - (= (:name typography) name) - (contains? typography :path)) - typography - (assoc typography :path path :name name)))) - typographies (->> typographies - (map extract-path-if-missing)) + (map dwl/extract-path-if-missing)) groups (group-assets typographies reverse-sort?) From 726f55bd045f2ec3a82eaf1cba698b370ead760c Mon Sep 17 00:00:00 2001 From: Alejandro Alonso Date: Fri, 9 Sep 2022 12:13:59 +0200 Subject: [PATCH 03/10] :bug: Fix weird text align --- frontend/resources/styles/main/partials/texts.scss | 2 +- frontend/src/app/main/ui/shapes/text/styles.cljs | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/frontend/resources/styles/main/partials/texts.scss b/frontend/resources/styles/main/partials/texts.scss index 0bece2924..54a1d234e 100644 --- a/frontend/resources/styles/main/partials/texts.scss +++ b/frontend/resources/styles/main/partials/texts.scss @@ -16,7 +16,7 @@ .text-editor { .DraftEditor-root { - height: 100%; + height: auto; display: flex; flex-direction: column; } diff --git a/frontend/src/app/main/ui/shapes/text/styles.cljs b/frontend/src/app/main/ui/shapes/text/styles.cljs index 44d23ee39..3cb594b87 100644 --- a/frontend/src/app/main/ui/shapes/text/styles.cljs +++ b/frontend/src/app/main/ui/shapes/text/styles.cljs @@ -21,7 +21,8 @@ :width width :fontFamily "sourcesanspro" :display "flex" - :whiteSpace "break-spaces"}] + :whiteSpace "break-spaces" + :flex-wrap "wrap"}] (cond-> base (= valign "top") (obj/set! "alignItems" "flex-start") (= valign "center") (obj/set! "alignItems" "center") From 8b29767932bce11f9470714920d3c81e7a8f9405 Mon Sep 17 00:00:00 2001 From: Pablo Alba Date: Fri, 9 Sep 2022 09:45:40 +0200 Subject: [PATCH 04/10] :bug: Fix items selected while ungrouping --- CHANGES.md | 3 ++- frontend/src/app/main/data/workspace/groups.cljs | 16 +++++++++++----- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 81657efec..8e2807b77 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -10,7 +10,8 @@ - Fix problem editing rotated texts [Taiga #4026](https://tree.taiga.io/project/penpot/issue/4026) - Fix problem with texts for non existing fonts [Taiga #4087](https://tree.taiga.io/project/penpot/issue/4087) - Fix undo after moving layers will wrongly order the layers [Taiga #3344](https://tree.taiga.io/project/penpot/issue/3344) -- Fix Grouping typographies by drag & drop does not work (again) [#2203](https://github.com/penpot/penpot/issues/2203) +- Fix grouping typographies by drag & drop does not work (again) [#2203](https://github.com/penpot/penpot/issues/2203) +- Fix when ungrouping, the items previously grouped should ALWAYS remain selected [Taiga #4064](https://tree.taiga.io/project/penpot/issue/4064) ## 1.15.2-beta diff --git a/frontend/src/app/main/data/workspace/groups.cljs b/frontend/src/app/main/data/workspace/groups.cljs index 2b315fc5e..e2609fcba 100644 --- a/frontend/src/app/main/data/workspace/groups.cljs +++ b/frontend/src/app/main/data/workspace/groups.cljs @@ -154,18 +154,24 @@ is-group? #(or (= :bool (:type %)) (= :group (:type %))) lookup #(get objects %) prepare #(prepare-remove-group it page-id % objects) + selected (wsh/lookup-selected state) + children (into (d/ordered-set) + (mapcat #(->> % + lookup + :shapes) selected)) changes-list (sequence - (comp (map lookup) - (filter is-group?) - (map prepare)) - (wsh/lookup-selected state)) + (comp (map lookup) + (filter is-group?) + (map prepare)) + selected) changes {:redo-changes (vec (mapcat :redo-changes changes-list)) :undo-changes (vec (mapcat :undo-changes changes-list)) :origin it}] - (rx/of (dch/commit-changes changes)))))) + (rx/of (dch/commit-changes changes) + (dws/select-shapes children)))))) (def mask-group (ptk/reify ::mask-group From dc6afb46bfe9b37ecc5afbb05519029f43773706 Mon Sep 17 00:00:00 2001 From: Eva Date: Tue, 6 Sep 2022 12:54:53 +0200 Subject: [PATCH 05/10] :bug: Fix overlay remain open on frame change --- frontend/src/app/main/data/viewer.cljs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/frontend/src/app/main/data/viewer.cljs b/frontend/src/app/main/data/viewer.cljs index c8061dac6..2ab6de140 100644 --- a/frontend/src/app/main/data/viewer.cljs +++ b/frontend/src/app/main/data/viewer.cljs @@ -274,6 +274,11 @@ (def select-prev-frame (ptk/reify ::select-prev-frame + ptk/UpdateEvent + (update [_ state] + (-> state + (dissoc :viewer-animation) + (assoc :viewer-overlays []))) ptk/WatchEvent (watch [_ state _] (let [route (:route state) @@ -287,6 +292,11 @@ (def select-next-frame (ptk/reify ::select-next-frame + ptk/UpdateEvent + (update [_ state] + (-> state + (dissoc :viewer-animation) + (assoc :viewer-overlays []))) ptk/WatchEvent (watch [_ state _] (let [route (:route state) From 67cbfc631d74201dd89e3f517a755093a44efe99 Mon Sep 17 00:00:00 2001 From: Eva Date: Tue, 6 Sep 2022 12:55:15 +0200 Subject: [PATCH 06/10] :bug: Fix toggle overlay position --- frontend/src/app/main/ui/viewer/shapes.cljs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frontend/src/app/main/ui/viewer/shapes.cljs b/frontend/src/app/main/ui/viewer/shapes.cljs index ae280e215..6c2599091 100644 --- a/frontend/src/app/main/ui/viewer/shapes.cljs +++ b/frontend/src/app/main/ui/viewer/shapes.cljs @@ -69,7 +69,11 @@ :toggle-overlay (let [frame-id (:destination interaction) - position (:overlay-position interaction) + dest-frame (get objects frame-id) + position (ctsi/calc-overlay-position interaction + base-frame + dest-frame + frame-offset) close-click-outside (:close-click-outside interaction) background-overlay (:background-overlay interaction)] (when frame-id From 7599b7abc6928e5f8337b97450282f4ff0a3a466 Mon Sep 17 00:00:00 2001 From: Eva Date: Tue, 6 Sep 2022 13:30:54 +0200 Subject: [PATCH 07/10] :bug: Fix overlay close when click --- frontend/src/app/main/ui/viewer.cljs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/frontend/src/app/main/ui/viewer.cljs b/frontend/src/app/main/ui/viewer.cljs index 22ee371f0..566efa3d1 100644 --- a/frontend/src/app/main/ui/viewer.cljs +++ b/frontend/src/app/main/ui/viewer.cljs @@ -101,7 +101,7 @@ :page page}])])) (mf/defc viewer-overlay - [{:keys [overlay page frame zoom wrapper-size close-overlay interactions-mode]}] + [{:keys [overlay page frame zoom wrapper-size interactions-mode]}] (let [close-click-outside? (:close-click-outside overlay) background-overlay? (:background-overlay overlay) overlay-frame (:frame overlay) @@ -113,10 +113,10 @@ on-click (mf/use-fn - (mf/deps overlay close-overlay close-click-outside?) + (mf/deps overlay close-click-outside?) (fn [_] (when close-click-outside? - (close-overlay (:frame overlay)))))] + (st/emit! (dv/close-overlay (:id overlay))))))] [:* (when (or close-click-outside? background-overlay?) @@ -147,7 +147,7 @@ (mf/defc viewer-wrapper [{:keys [wrapper-size orig-frame orig-viewport-ref orig-size page file users current-viewport-ref - size frame interactions-mode overlays zoom close-overlay section index] :as props}] + size frame interactions-mode overlays zoom section index] :as props}] [:* [:& viewer-pagination-and-sidebar {:section section @@ -197,7 +197,6 @@ :frame frame :zoom zoom :wrapper-size wrapper-size - :close-overlay close-overlay :interactions-mode interactions-mode}]) ]] From 7618fcade0938d45475548f6bdf754b5087a6545 Mon Sep 17 00:00:00 2001 From: Eva Date: Thu, 8 Sep 2022 12:34:28 +0200 Subject: [PATCH 08/10] :bug: Fix several transitions on same frame --- CHANGES.md | 9 +++ frontend/src/app/main/data/viewer.cljs | 27 ++++---- frontend/src/app/main/ui/viewer.cljs | 88 +++++++++++++------------- 3 files changed, 68 insertions(+), 56 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 8e2807b77..7990d40e3 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,14 @@ # CHANGELOG +## 1.15.4-beta + +### :bug: Bugs fixed + +- Fix overlay remains open on frame change [Taiga #4066](https://tree.taiga.io/project/penpot/issue/4066) +- Fix toggle overlay position [Taiga #4091](https://tree.taiga.io/project/penpot/issue/4091) +- Fix overlay closed on clicked outside [Taiga #4027](https://tree.taiga.io/project/penpot/issue/4027) +- Fix animate multiple overlays [Taiga #3993](https://tree.taiga.io/project/penpot/issue/3993) + ## 1.15.3-beta ### :bug: Bugs fixed diff --git a/frontend/src/app/main/data/viewer.cljs b/frontend/src/app/main/data/viewer.cljs index 2ab6de140..4e8dd1f03 100644 --- a/frontend/src/app/main/data/viewer.cljs +++ b/frontend/src/app/main/data/viewer.cljs @@ -277,7 +277,7 @@ ptk/UpdateEvent (update [_ state] (-> state - (dissoc :viewer-animation) + (dissoc :viewer-animations) (assoc :viewer-overlays []))) ptk/WatchEvent (watch [_ state _] @@ -295,7 +295,7 @@ ptk/UpdateEvent (update [_ state] (-> state - (dissoc :viewer-animation) + (dissoc :viewer-animations) (assoc :viewer-overlays []))) ptk/WatchEvent (watch [_ state _] @@ -381,7 +381,7 @@ (ptk/reify ::complete-animation ptk/UpdateEvent (update [_ state] - (dissoc state :viewer-animation)))) + (dissoc state :viewer-animations)))) ;; --- Navigation inside page @@ -422,7 +422,7 @@ (assoc :viewer-overlays []) (some? animation) - (assoc :viewer-animation + (assoc-in [:viewer-animations (:id frame)] {:kind :go-to-frame :orig-frame-id (:id frame) :animation animation})))) @@ -475,13 +475,14 @@ :id (:id frame) :position position :close-click-outside close-click-outside - :background-overlay background-overlay}) + :background-overlay background-overlay + :animation animation}) (some? animation) - (assoc :viewer-animation - {:kind :open-overlay - :overlay-id (:id frame) - :animation animation}))) + (assoc-in [:viewer-animations (:id frame)] + {:kind :open-overlay + :overlay-id (:id frame) + :animation animation}))) (defn- close-overlay* [state frame-id animation] @@ -489,10 +490,10 @@ (update state :viewer-overlays (fn [overlays] (d/removev #(= (:id (:frame %)) frame-id) overlays))) - (assoc state :viewer-animation - {:kind :close-overlay - :overlay-id frame-id - :animation animation}))) + (assoc-in state [:viewer-animations frame-id] + {:kind :close-overlay + :overlay-id frame-id + :animation animation}))) (defn open-overlay [frame-id position close-click-outside background-overlay animation] diff --git a/frontend/src/app/main/ui/viewer.cljs b/frontend/src/app/main/ui/viewer.cljs index 566efa3d1..4880504ef 100644 --- a/frontend/src/app/main/ui/viewer.cljs +++ b/frontend/src/app/main/ui/viewer.cljs @@ -14,6 +14,7 @@ [app.common.geom.shapes.bounds :as gsb] [app.common.pages.helpers :as cph] [app.common.text :as txt] + [app.common.types.shape.interactions :as ctsi] [app.main.data.comments :as dcm] [app.main.data.viewer :as dv] [app.main.data.viewer.shortcuts :as sc] @@ -41,8 +42,8 @@ [okulary.core :as l] [rumext.alpha :as mf])) -(def current-animation-ref - (l/derived :viewer-animation st/state)) +(def current-animations-ref + (l/derived :viewer-animations st/state)) (def current-overlays-ref (l/derived :viewer-overlays st/state)) @@ -116,7 +117,9 @@ (mf/deps overlay close-click-outside?) (fn [_] (when close-click-outside? - (st/emit! (dv/close-overlay (:id overlay))))))] + (if-let [animation (:animation overlay)] + (st/emit! (dv/close-overlay (:id overlay) (ctsi/invert-direction animation))) + (st/emit! (dv/close-overlay (:id overlay)))))))] [:* (when (or close-click-outside? background-overlay?) @@ -197,9 +200,7 @@ :frame frame :zoom zoom :wrapper-size wrapper-size - :interactions-mode interactions-mode}]) - - ]] + :interactions-mode interactions-mode}])]] (when (= section :comments) @@ -233,7 +234,8 @@ current-viewport-ref (mf/use-ref nil) viewer-section-ref (mf/use-ref nil) - current-animation (mf/deref current-animation-ref) + current-animations (mf/deref current-animations-ref) + first-animation (first (vals current-animations)) page-id (or page-id (-> file :data :pages first)) @@ -257,8 +259,8 @@ scroll (mf/use-state nil) orig-frame - (when (:orig-frame-id current-animation) - (d/seek #(= (:id %) (:orig-frame-id current-animation)) frames)) + (when (:orig-frame-id first-animation) + (d/seek #(= (:id %) (:orig-frame-id first-animation)) frames)) size (mf/with-memo [frame zoom] @@ -387,12 +389,12 @@ (fn [] ;; Navigate animation needs to be started after navigation ;; is complete, and we have the next page index. - (when (and current-animation - (= (:kind current-animation) :go-to-frame)) + (when (and first-animation + (= (:kind first-animation) :go-to-frame)) (let [orig-viewport (mf/ref-val orig-viewport-ref) current-viewport (mf/ref-val current-viewport-ref)] (interactions/animate-go-to-frame - (:animation current-animation) + (:animation first-animation) current-viewport orig-viewport size @@ -400,42 +402,42 @@ wrapper-size))))) (mf/use-layout-effect - (mf/deps current-animation) + (mf/deps current-animations) (fn [] ;; Overlay animations may be started when needed. - (when current-animation - (case (:kind current-animation) - - :open-overlay - (let [overlay-viewport (dom/get-element (str "overlay-" (str (:overlay-id current-animation)))) - overlay (d/seek #(= (:id (:frame %)) (:overlay-id current-animation)) - overlays) - overlay-size (calculate-size (:objects page) (:frame overlay) zoom) + (when current-animations + (doseq [[overlay-frame-id animation-vals] current-animations] + (let [overlay-viewport (dom/get-element (str "overlay-" (str (:overlay-id animation-vals)))) + overlay (d/seek #(= (:id (:frame %)) overlay-frame-id) + overlays) + overlay-size (calculate-size (:objects page) (:frame overlay) zoom) overlay-position {:x (* (:x (:position overlay)) zoom) - :y (* (:y (:position overlay)) zoom)}] - (interactions/animate-open-overlay - (:animation current-animation) - overlay-viewport - wrapper-size - overlay-size - overlay-position)) + :y (* (:y (:position overlay)) zoom)} + orig-frame (when (:orig-frame-id animation-vals) + (d/seek #(= (:id %) (:orig-frame-id animation-vals)) frames)) + size (calculate-size (:objects page) frame zoom) + orig-size (when orig-frame + (calculate-size (:objects page) orig-frame zoom)) + wrapper-size (calculate-wrapper size orig-size zoom)] + (case (:kind animation-vals) + :open-overlay + (interactions/animate-open-overlay + (:animation animation-vals) + overlay-viewport + wrapper-size + overlay-size + overlay-position) - :close-overlay - (let [overlay-viewport (dom/get-element (str "overlay-" (str (:overlay-id current-animation)))) - overlay (d/seek #(= (:id (:frame %)) (:overlay-id current-animation)) - overlays) - overlay-size (calculate-size (:objects page) (:frame overlay) zoom) - overlay-position {:x (* (:x (:position overlay)) zoom) - :y (* (:y (:position overlay)) zoom)}] - (interactions/animate-close-overlay - (:animation current-animation) - overlay-viewport - wrapper-size - overlay-size - overlay-position - (:id (:frame overlay)))) + :close-overlay + (interactions/animate-close-overlay + (:animation animation-vals) + overlay-viewport + wrapper-size + overlay-size + overlay-position + (:id (:frame overlay))) - nil)))) + nil)))))) (mf/use-effect (mf/deps text-shapes) From f736ec813e67108131abcde4bb9d7d93b41a35ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20Moya?= Date: Fri, 9 Sep 2022 12:01:06 +0200 Subject: [PATCH 09/10] :bug: Fix origin-frame calculation --- frontend/src/app/main/ui/viewer.cljs | 34 ++++++++++++--------- frontend/src/app/main/ui/viewer/shapes.cljs | 2 +- 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/frontend/src/app/main/ui/viewer.cljs b/frontend/src/app/main/ui/viewer.cljs index 4880504ef..5eef0464d 100644 --- a/frontend/src/app/main/ui/viewer.cljs +++ b/frontend/src/app/main/ui/viewer.cljs @@ -235,7 +235,6 @@ viewer-section-ref (mf/use-ref nil) current-animations (mf/deref current-animations-ref) - first-animation (first (vals current-animations)) page-id (or page-id (-> file :data :pages first)) @@ -259,8 +258,13 @@ scroll (mf/use-state nil) orig-frame - (when (:orig-frame-id first-animation) - (d/seek #(= (:id %) (:orig-frame-id first-animation)) frames)) + (mf/with-memo [current-animations] + ;; We assume there can only be one animation with origin (this is used only in + ;; navigation animations, and we cannot navigate to two different destinations + ;; at the same time). + (let [animation-with-origin (d/seek :orig-frame-id (vals current-animations))] + (when animation-with-origin + (d/seek #(= (:id %) (:orig-frame-id animation-with-origin)) frames)))) size (mf/with-memo [frame zoom] @@ -385,21 +389,21 @@ (wapi/exit-fullscreen)))))) (mf/use-layout-effect - (mf/deps index) + (mf/deps index current-animations) (fn [] ;; Navigate animation needs to be started after navigation ;; is complete, and we have the next page index. - (when (and first-animation - (= (:kind first-animation) :go-to-frame)) - (let [orig-viewport (mf/ref-val orig-viewport-ref) - current-viewport (mf/ref-val current-viewport-ref)] - (interactions/animate-go-to-frame - (:animation first-animation) - current-viewport - orig-viewport - size - orig-size - wrapper-size))))) + (let [nav-animation (d/seek #(= (:kind %) :go-to-frame) (vals current-animations))] + (when nav-animation + (let [orig-viewport (mf/ref-val orig-viewport-ref) + current-viewport (mf/ref-val current-viewport-ref)] + (interactions/animate-go-to-frame + (:animation nav-animation) + current-viewport + orig-viewport + size + orig-size + wrapper-size)))))) (mf/use-layout-effect (mf/deps current-animations) diff --git a/frontend/src/app/main/ui/viewer/shapes.cljs b/frontend/src/app/main/ui/viewer/shapes.cljs index 6c2599091..d0609383f 100644 --- a/frontend/src/app/main/ui/viewer/shapes.cljs +++ b/frontend/src/app/main/ui/viewer/shapes.cljs @@ -69,7 +69,7 @@ :toggle-overlay (let [frame-id (:destination interaction) - dest-frame (get objects frame-id) + dest-frame (get objects frame-id) position (ctsi/calc-overlay-position interaction base-frame dest-frame From 108cdcecbb58be6ad4d8bbda4b58da749263558c Mon Sep 17 00:00:00 2001 From: Alejandro Alonso Date: Mon, 5 Sep 2022 11:56:51 +0200 Subject: [PATCH 10/10] :tada: Improve viewer performance degradation because of fixed position --- .../styles/main/partials/viewer.scss | 14 ++++ frontend/src/app/main/ui/shapes/group.cljs | 12 +--- frontend/src/app/main/ui/shapes/mask.cljs | 6 -- frontend/src/app/main/ui/viewer.cljs | 48 ++++++------- .../app/main/ui/viewer/handoff/render.cljs | 2 +- .../src/app/main/ui/viewer/interactions.cljs | 67 ++++++++++++++----- frontend/src/app/main/ui/viewer/shapes.cljs | 27 +------- 7 files changed, 91 insertions(+), 85 deletions(-) diff --git a/frontend/resources/styles/main/partials/viewer.scss b/frontend/resources/styles/main/partials/viewer.scss index 4fa9b3de1..0f1ddcdf9 100644 --- a/frontend/resources/styles/main/partials/viewer.scss +++ b/frontend/resources/styles/main/partials/viewer.scss @@ -171,6 +171,20 @@ } .viewport-container { + clip-path: inset(0 0 0 0); grid-column: 1 / 1; grid-row: 1 / 1; + + .not-fixed { + position: absolute; + } + + .fixed { + position: fixed; + pointer-events: none; + + .frame-children g { + pointer-events: auto; + } + } } diff --git a/frontend/src/app/main/ui/shapes/group.cljs b/frontend/src/app/main/ui/shapes/group.cljs index 664c4e834..bf792757e 100644 --- a/frontend/src/app/main/ui/shapes/group.cljs +++ b/frontend/src/app/main/ui/shapes/group.cljs @@ -42,21 +42,13 @@ (if masked-group? ["g" (-> (obj/create) (obj/set! "mask" (mask-url render-id mask)))] - [mf/Fragment nil]) - - ;; This factory is generic, it's used for viewer, workspace and handoff. - ;; These props are generated in viewer wrappers only, in the rest of the - ;; cases these props will be nil, not affecting the code. - delta (unchecked-get props "delta") - fixed? (unchecked-get props "fixed?")] + [mf/Fragment nil])] [:> clip-wrapper clip-props [:> mask-wrapper mask-props (when masked-group? [:> render-mask #js {:mask mask - :objects objects - :delta delta - :fixed? fixed?}]) + :objects objects}]) (for [item childs] [:& shape-wrapper {:shape item diff --git a/frontend/src/app/main/ui/shapes/mask.cljs b/frontend/src/app/main/ui/shapes/mask.cljs index c43b12a60..a06098173 100644 --- a/frontend/src/app/main/ui/shapes/mask.cljs +++ b/frontend/src/app/main/ui/shapes/mask.cljs @@ -50,13 +50,7 @@ render-id (mf/use-ctx muc/render-id) svg-text? (and (= :text (:type mask)) (some? (:position-data mask))) - ;; This factory is generic, it's used for viewer, workspace and handoff. - ;; These props are generated in viewer wrappers only, in the rest of the - ;; cases these props will be nil, not affecting the code. - fixed? (unchecked-get props "fixed?") - delta (unchecked-get props "delta") mask-bb (-> (gsh/transform-shape mask) - (cond-> fixed? (gsh/move delta)) (:points)) mask-bb-rect (gsh/points->rect mask-bb)] diff --git a/frontend/src/app/main/ui/viewer.cljs b/frontend/src/app/main/ui/viewer.cljs index 5eef0464d..872bb5345 100644 --- a/frontend/src/app/main/ui/viewer.cljs +++ b/frontend/src/app/main/ui/viewer.cljs @@ -255,7 +255,6 @@ fullscreen? (mf/deref header/fullscreen-ref) overlays (mf/deref current-overlays-ref) - scroll (mf/use-state nil) orig-frame (mf/with-memo [current-animations] @@ -309,11 +308,6 @@ size (dom/get-client-size viewer-section)] (st/emit! (dv/set-viewport-size {:size size}))))) - on-scroll - (mf/use-fn - (fn [event] - (reset! scroll (dom/get-target-scroll event)))) - on-wheel (mf/use-fn (fn [event] @@ -354,12 +348,10 @@ (mf/with-effect [] (dom/set-html-theme-color clr/gray-50 "dark") (let [key1 (events/listen js/window "click" on-click) - key2 (events/listen (mf/ref-val viewer-section-ref) "scroll" on-scroll #js {"passive" true}) - key3 (events/listen (mf/ref-val viewer-section-ref) "wheel" on-wheel #js {"passive" false})] + key2 (events/listen (mf/ref-val viewer-section-ref) "wheel" on-wheel #js {"passive" false})] (fn [] (events/unlistenByKey key1) - (events/unlistenByKey key2) - (events/unlistenByKey key3)))) + (events/unlistenByKey key2)))) (mf/use-layout-effect (fn [] @@ -499,24 +491,24 @@ :index index :viewer-pagination viewer-pagination}] - [:& (mf/provider ctx/current-scroll) {:value @scroll} - [:& (mf/provider ctx/current-zoom) {:value zoom} - [:& viewer-wrapper - {:wrapper-size wrapper-size - :orig-frame orig-frame - :orig-viewport-ref orig-viewport-ref - :orig-size orig-size - :page page - :file file - :users users - :current-viewport-ref current-viewport-ref - :size size - :frame frame - :interactions-mode interactions-mode - :overlays overlays - :zoom zoom - :section section - :index index}]]]))]]])) + + [:& (mf/provider ctx/current-zoom) {:value zoom} + [:& viewer-wrapper + {:wrapper-size wrapper-size + :orig-frame orig-frame + :orig-viewport-ref orig-viewport-ref + :orig-size orig-size + :page page + :file file + :users users + :current-viewport-ref current-viewport-ref + :size size + :frame frame + :interactions-mode interactions-mode + :overlays overlays + :zoom zoom + :section section + :index index}]]))]]])) ;; --- Component: Viewer Page diff --git a/frontend/src/app/main/ui/viewer/handoff/render.cljs b/frontend/src/app/main/ui/viewer/handoff/render.cljs index 61d982910..1b90da72c 100644 --- a/frontend/src/app/main/ui/viewer/handoff/render.cljs +++ b/frontend/src/app/main/ui/viewer/handoff/render.cljs @@ -189,7 +189,7 @@ (mf/defc render-frame-svg [{:keys [page frame local size]}] (let [objects (mf/with-memo [page frame size] - (prepare-objects page frame size)) + (prepare-objects frame size (:objects page))) ;; Retrieve frame again with correct modifier frame (get objects (:id frame)) diff --git a/frontend/src/app/main/ui/viewer/interactions.cljs b/frontend/src/app/main/ui/viewer/interactions.cljs index aa479c9cb..6260f32be 100644 --- a/frontend/src/app/main/ui/viewer/interactions.cljs +++ b/frontend/src/app/main/ui/viewer/interactions.cljs @@ -12,6 +12,7 @@ [app.common.geom.point :as gpt] [app.common.pages.helpers :as cph] [app.common.types.page :as ctp] + [app.common.uuid :as uuid] [app.main.data.comments :as dcm] [app.main.data.viewer :as dv] [app.main.refs :as refs] @@ -27,8 +28,8 @@ [rumext.alpha :as mf])) (defn prepare-objects - [page frame size] - (let [objects (:objects page) + [frame size objects] + (let [ frame-id (:id frame) modifier (-> (gpt/point (:x size) (:y size)) (gpt/negate) @@ -52,26 +53,60 @@ vbox (:vbox size) - objects (mf/with-memo [page frame size] - (prepare-objects page frame size)) + fixed-ids (filter :fixed-scroll (vals (:objects page))) - wrapper (mf/with-memo [objects] - (shapes/frame-container-factory objects)) + ;; we have con consider the children if the fixed element is a group + fixed-children-ids (into #{} (mapcat #(cph/get-children-ids (:objects page) (:id %)) fixed-ids)) + + parent-children-ids (->> fixed-ids + (mapcat #(cons (:id %) (cph/get-parent-ids (:objects page) (:id %)))) + (remove #(= % uuid/zero))) + + fixed-ids (concat fixed-children-ids parent-children-ids) + + not-fixed-ids (->> (remove (set fixed-ids) (keys (:objects page))) + (remove #(= % uuid/zero))) + + calculate-objects (fn [ids] (->> ids + (map (d/getf (:objects page))) + (concat [frame]) + (d/index-by :id) + (prepare-objects frame size))) + + wrapper-fixed (mf/with-memo [page frame size] + (shapes/frame-container-factory (calculate-objects fixed-ids))) + + objects-not-fixed (mf/with-memo [page frame size] + (calculate-objects not-fixed-ids)) + + wrapper-not-fixed (mf/with-memo [objects-not-fixed] + (shapes/frame-container-factory objects-not-fixed)) ;; Retrieve frames again with correct modifier - frame (get objects (:id frame)) - base (get objects (:id base))] + frame (get objects-not-fixed (:id frame)) + base (get objects-not-fixed (:id base))] [:& (mf/provider shapes/base-frame-ctx) {:value base} [:& (mf/provider shapes/frame-offset-ctx) {:value offset} - [:svg {:view-box vbox - :width (:width size) - :height (:height size) - :version "1.1" - :xmlnsXlink "http://www.w3.org/1999/xlink" - :xmlns "http://www.w3.org/2000/svg" - :fill "none"} - [:& wrapper {:shape frame :view-box vbox}]]]])) + ;; We have two different svgs for fixed and not fixed elements so we can emulate the sticky css attribute in svg + [:svg.not-fixed {:view-box vbox + :width (:width size) + :height (:height size) + :version "1.1" + :xmlnsXlink "http://www.w3.org/1999/xlink" + :xmlns "http://www.w3.org/2000/svg" + :fill "none"} + [:& wrapper-not-fixed {:shape frame :view-box vbox}]] + [:svg.fixed {:view-box vbox + :width (:width size) + :height (:height size) + :version "1.1" + :xmlnsXlink "http://www.w3.org/1999/xlink" + :xmlns "http://www.w3.org/2000/svg" + :fill "none" + :style {:width (:width size) + :height (:height size)}} + [:& wrapper-fixed {:shape (dissoc frame :fills) :view-box vbox}]]]])) (mf/defc viewport {::mf/wrap [mf/memo] diff --git a/frontend/src/app/main/ui/viewer/shapes.cljs b/frontend/src/app/main/ui/viewer/shapes.cljs index d0609383f..f2c65a450 100644 --- a/frontend/src/app/main/ui/viewer/shapes.cljs +++ b/frontend/src/app/main/ui/viewer/shapes.cljs @@ -7,14 +7,12 @@ (ns app.main.ui.viewer.shapes "The main container for a frame in viewer mode" (:require - [app.common.data :as d] [app.common.geom.shapes :as gsh] [app.common.pages.helpers :as cph] [app.common.types.shape.interactions :as ctsi] [app.main.data.viewer :as dv] [app.main.refs :as refs] [app.main.store :as st] - [app.main.ui.context :as ctx] [app.main.ui.shapes.bool :as bool] [app.main.ui.shapes.circle :as circle] [app.main.ui.shapes.frame :as frame] @@ -223,8 +221,6 @@ childs (unchecked-get props "childs") frame (unchecked-get props "frame") objects (unchecked-get props "objects") - fixed? (unchecked-get props "fixed?") - delta (unchecked-get props "delta") base-frame (mf/use-ctx base-frame-ctx) frame-offset (mf/use-ctx frame-offset-ctx) @@ -269,9 +265,7 @@ :frame frame :childs childs :is-child-selected? true - :objects objects - :fixed? fixed? - :delta delta}] + :objects objects}] [:& interaction {:shape shape :interactions interactions @@ -393,20 +387,6 @@ (let [shape (unchecked-get props "shape") frame (unchecked-get props "frame") - ;; TODO: this watch of scroll position is killing - ;; performance of the viewer. - scroll (mf/use-ctx ctx/current-scroll) - zoom (mf/use-ctx ctx/current-zoom) - - fixed? (mf/with-memo [shape objects] - (->> (cph/get-parent-ids objects (:id shape)) - (map (d/getf objects)) - (concat [shape]) - (some :fixed-scroll))) - - delta {:x (/ (:scroll-left scroll) zoom) - :y (/ (:scroll-top scroll) zoom)} - group-container (mf/with-memo [objects] (group-container-factory objects)) @@ -426,8 +406,7 @@ ] (when (and shape (not (:hidden shape))) (let [shape (-> (gsh/transform-shape shape) - (gsh/translate-to-frame frame) - (cond-> fixed? (gsh/move delta))) + (gsh/translate-to-frame frame)) opts #js {:shape shape :objects objects}] @@ -438,6 +417,6 @@ :path [:> path-wrapper opts] :image [:> image-wrapper opts] :circle [:> circle-wrapper opts] - :group [:> group-container {:shape shape :frame frame :objects objects :fixed? fixed? :delta delta}] + :group [:> group-container {:shape shape :frame frame :objects objects}] :bool [:> bool-container {:shape shape :frame frame :objects objects}] :svg-raw [:> svg-raw-container {:shape shape :frame frame :objects objects}])))))))