Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-01-23 23:18:48 -05:00
Code Issues Activity

✨ Improve logging performance

Browse source 
Delay the message building until it really needed to be
printed.
This commit is contained in:
Andrey Antukh 2022-04-19 15:19:02 +02:00 • committed by Alonso Torres
parent d9d47b2c65
commit 31ec4092ed
1 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
common/src/app/common/logging.cljc
View file

@ -134,10 +134,8 @@
(defn write-log!
[logger level exception message]
(let [message (if (string? message)
message
(str/join ", " message))]
#?(:clj
#?(:clj
(let [message (if (string? message) message (str/join ", " message))]
(if exception
(.log ^Logger logger
^Level level
@ -145,14 +143,17 @@
^Throwable exception)
(.log ^Logger logger
^Level level
^Object message))
:cljs
(when glog/ENABLED
(when-let [l (get-logger logger)]
(let [level (get-level level)
record (glog/LogRecord. level message (.getName ^js l))]
^Object message)))
:cljs
(when glog/ENABLED
(let [logger (get-logger logger)
level (get-level level)]
(when (and logger (glog/isLoggable logger level))
(let [message (if (fn? message) (message) message)
message (if (string? message) message (str/join ", " message))
record (glog/LogRecord. level message (.getName ^js logger))]
(when exception (.setException record exception))
(glog/publishLogRecord l record)))))))
(glog/publishLogRecord logger record)))))))
#?(:clj
(defn enabled?
@ -174,9 +175,8 @@
(defmacro log
[& props]
(if (:ns &env) ; CLJS
(let [{:keys [level cause ::logger ::raw]} props
message (or raw (build-message props))]
`(write-log! ~(or logger (str *ns*)) ~level ~cause (or ~raw (build-message ~(vec props)))))
(let [{:keys [level cause ::logger ::raw]} props]
`(write-log! ~(or logger (str *ns*)) ~level ~cause (or ~raw (fn [] (build-message ~(vec props))))))
(let [{:keys [level cause ::logger ::async ::raw ::context] :or {async true}} props
logger (or logger (str *ns*))