From 8b81f700a54bcf16c5f6a17be44a9ac16a910d6b Mon Sep 17 00:00:00 2001 From: Alejandro Alonso Date: Tue, 11 Jul 2023 07:45:12 +0200 Subject: [PATCH 1/2] :sparkles: Refactor select all on pending numeric input --- .../ui/workspace/sidebar/options/menus/interactions.cljs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/frontend/src/app/main/ui/workspace/sidebar/options/menus/interactions.cljs b/frontend/src/app/main/ui/workspace/sidebar/options/menus/interactions.cljs index eff892981..a672a1f1b 100644 --- a/frontend/src/app/main/ui/workspace/sidebar/options/menus/interactions.cljs +++ b/frontend/src/app/main/ui/workspace/sidebar/options/menus/interactions.cljs @@ -199,9 +199,6 @@ ext-delay-ref (mf/use-ref nil) ext-duration-ref (mf/use-ref nil) - select-text - (fn [ref] (fn [_] (dom/select-text! (mf/ref-val ref)))) - change-event-type (fn [event] (let [value (-> event dom/get-target dom/get-value d/read-string)] @@ -336,7 +333,6 @@ [:span.element-set-subtitle.wide (tr "workspace.options.interaction-delay")] [:div.input-element {:title (tr "workspace.options.interaction-ms")} [:> numeric-input {:ref ext-delay-ref - :on-focus (select-text ext-delay-ref) :on-change change-delay :value (:delay interaction) :title (tr "workspace.options.interaction-ms")}] @@ -523,7 +519,6 @@ [:span.element-set-subtitle.wide (tr "workspace.options.interaction-duration")] [:div.input-element {:title (tr "workspace.options.interaction-ms")} [:> numeric-input {:ref ext-duration-ref - :on-focus (select-text ext-duration-ref) :on-change change-duration :value (-> interaction :animation :duration) :title (tr "workspace.options.interaction-ms")}] From 8007794cba5381d4afcebf191003cba39bd46a0f Mon Sep 17 00:00:00 2001 From: Alejandro Alonso Date: Tue, 11 Jul 2023 07:45:29 +0200 Subject: [PATCH 2/2] :bug: Fix dissolve interaction --- frontend/src/app/main/ui/viewer/interactions.cljs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/src/app/main/ui/viewer/interactions.cljs b/frontend/src/app/main/ui/viewer/interactions.cljs index 1b7a37aeb..6e2e6320e 100644 --- a/frontend/src/app/main/ui/viewer/interactions.cljs +++ b/frontend/src/app/main/ui/viewer/interactions.cljs @@ -245,14 +245,14 @@ :dissolve (do (dom/animate! orig-viewport - [#js {:opacity "100"} + [#js {:opacity "100%"} #js {:opacity "0"}] #js {:duration (:duration animation) :easing (name (:easing animation))} #(st/emit! (dv/complete-animation))) (dom/animate! current-viewport [#js {:opacity "0"} - #js {:opacity "100"}] + #js {:opacity "100%"}] #js {:duration (:duration animation) :easing (name (:easing animation))}))