Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-01-08 07:50:43 -05:00
Code Issues Activity

Merge pull request #4313 from penpot/palba-fix-crash-moving-frame-copy

Browse source 
🐛 Fix Crash on moving a frame with copy outside a component
This commit is contained in:
Alejandro 2024-03-22 08:49:16 +01:00 committed by GitHub
commit 1d726249d0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frontend/src/app/main/data/workspace/transforms.cljs
View file

@ -910,6 +910,11 @@
(mapcat #(cfh/get-children-with-self objects (:id %)))
(map :id))
child-heads
(->> moving-shapes-ids
(mapcat #(ctn/get-child-heads objects %))
(map :id))
changes
(-> (pcb/empty-changes it page-id)
(pcb/with-objects objects)
@ -921,10 +926,7 @@
(pcb/update-shapes moving-shapes-children-ids #(dissoc % :component-root)))
;; Add component-root property when moving a component outside a component
(cond-> (not (ctn/get-instance-root objects frame))
(pcb/update-shapes moving-shapes-ids (fn [shape]
(if (ctk/instance-head? shape)
(assoc shape :component-root true)
shape))))
(pcb/update-shapes child-heads #(assoc % :component-root true)))
(pcb/update-shapes moving-shapes-ids #(cond-> % (cfh/frame-shape? %) (assoc :hide-in-viewer true)))
(pcb/update-shapes shape-ids-to-detach ctk/detach-shape)
(pcb/change-parent frame-id moving-shapes drop-index)