Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-02-10 09:08:31 -05:00
Code Issues Activity

🐛 Fix retrieve unread comment threads extra calls

Browse source
This commit is contained in:
Alejandro Alonso 2023-07-25 14:50:42 +02:00
parent 9a60ac477f
commit 1aa7960863
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frontend/src/app/main/data/comments.cljs
View file

@ -322,7 +322,7 @@
(rx/concat (rx/concat
(rx/of (partial fetched-comments comments)) (rx/of (partial fetched-comments comments))
(->> (rx/from (map :file-id comments)) (->> (rx/from (into #{} (map :file-id) comments))
(rx/merge-map #(rp/cmd! :get-profiles-for-file-comments {:file-id %})) (rx/merge-map #(rp/cmd! :get-profiles-for-file-comments {:file-id %}))
(rx/reduce #(merge %1 (d/index-by :id %2)) {}) (rx/reduce #(merge %1 (d/index-by :id %2)) {})
(rx/map #(partial fetched-users %)))))) (rx/map #(partial fetched-users %))))))

12
frontend/src/app/main/ui/dashboard/comments.cljs
View file

@ -22,17 +22,12 @@
(mf/defc comments-section (mf/defc comments-section
[{:keys [profile team]}] [{:keys [profile team]}]
(mf/use-effect
(mf/deps team)
(fn []
(st/emit! (dcm/retrieve-unread-comment-threads (:id team)))))
(let [show-dropdown? (mf/use-state false) (let [show-dropdown? (mf/use-state false)
show-dropdown (mf/use-fn #(reset! show-dropdown? true)) show-dropdown (mf/use-fn #(reset! show-dropdown? true))
hide-dropdown (mf/use-fn #(reset! show-dropdown? false)) hide-dropdown (mf/use-fn #(reset! show-dropdown? false))
threads-map (mf/deref refs/comment-threads) threads-map (mf/deref refs/comment-threads)
users (mf/deref refs/current-team-comments-users) users (mf/deref refs/current-team-comments-users)
team-id (:id team)
tgroups (->> (vals threads-map) tgroups (->> (vals threads-map)
(sort-by :modified-at) (sort-by :modified-at)
@ -46,6 +41,11 @@
(st/emit! (-> (dwcm/navigate thread) (st/emit! (-> (dwcm/navigate thread)
(with-meta {::ev/origin "dashboard"})))))] (with-meta {::ev/origin "dashboard"})))))]
(mf/use-effect
(mf/deps team-id)
(fn []
(st/emit! (dcm/retrieve-unread-comment-threads team-id))))
(mf/use-effect (mf/use-effect
(mf/deps @show-dropdown?) (mf/deps @show-dropdown?)
(fn [] (fn []