From 166fdbd406587bd88afd25e548c93e671374f617 Mon Sep 17 00:00:00 2001
From: Andrey Antukh <niwi@niwi.nz>
Date: Wed, 7 Apr 2021 19:52:40 +0200
Subject: [PATCH] :bug: Fix incorrect handling of websocket metrics.

---
 backend/src/app/notifications.clj | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/backend/src/app/notifications.clj b/backend/src/app/notifications.clj
index 754502b7c..e41c143b1 100644
--- a/backend/src/app/notifications.clj
+++ b/backend/src/app/notifications.clj
@@ -163,17 +163,21 @@
                   ;; Subscribe to corresponding topics
                   (a/<! (msgbus :sub {:topics [file-id team-id] :chan sub-ch}))
                   (a/<! (handle-connect cfg))
+
+                  ;; when connection is closed
+                  (mtx-aconn :dec)
+                  (mtx-sessions :observe (/ (inst-ms (dt/duration-between created-at (dt/now))) 1000.0))
+
+                  ;; close subscription
                   (a/close! sub-ch))))
 
             (on-error [_conn e]
-              (mtx-aconn :dec)
               (mtx-sessions :observe (/ (inst-ms (dt/duration-between created-at (dt/now))) 1000.0))
               (log/tracef "on-error %s (%s)" (:session-id cfg) (ex-message e))
               (a/close! out-ch)
               (a/close! rcv-ch))
 
             (on-close [_conn _status _reason]
-              (mtx-aconn :dec)
               (mtx-sessions :observe (/ (inst-ms (dt/duration-between created-at (dt/now))) 1000.0))
               (log/tracef "on-close %s" (:session-id cfg))
               (a/close! out-ch)