Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-03-27 15:11:26 -05:00
Code Issues Activity

⚡ Change some verify to asserts

Browse source
This commit is contained in:
alonso.torres 2021-04-28 17:27:43 +02:00 • committed by Andrés Moya
parent ac27d35ff5
commit 0b6c2df5b6
3 changed files with 13 additions and 10 deletions
common/app/common/pages
changes.cljc
frontend/src/app/main/data/workspace
changes.cljsundo.cljs

2
common/app/common/pages/changes.cljc
View file

@ -31,7 +31,7 @@
;; When verify? false we spec the schema validation. Currently used to make just
;; 1 validation even if the changes are applied twice
(when verify?
(us/verify ::spec/changes items))
(us/assert ::spec/changes items))
(let [pages (into #{} (map :page-id) items)
result (->> items

19
frontend/src/app/main/data/workspace/changes.cljs
View file

@ -68,15 +68,18 @@
ptk/WatchEvent
(watch [_ state stream]
(let [page-id (:current-page-id state)
objects (get-in state [:workspace-data :pages-index page-id :objects])]
objects (get-in state [:workspace-data :pages-index page-id :objects])
reg-objects {:type :reg-objects :page-id page-id :shapes (vec ids)}]
(loop [ids (seq ids)
rch []
uch []]
(if (nil? ids)
(rx/of (commit-changes
(cond-> rch reg-objects? (conj {:type :reg-objects :page-id page-id :shapes (vec ids)}))
(cond-> uch reg-objects? (conj {:type :reg-objects :page-id page-id :shapes (vec ids)}))
{:commit-local? true}))
(rx/of (let [has-rch? (not (empty? rch))
has-uch? (not (empty? uch))
rch (cond-> rch (and has-rch? reg-objects?) (conj reg-objects))
uch (cond-> uch (and has-rch? reg-objects?) (conj reg-objects))]
(when (and has-rch? has-uch?)
(commit-changes rch uch {:commit-local? true}))))
(let [id (first ids)
obj1 (get objects id)
@ -161,8 +164,8 @@
:or {save-undo? true
commit-local? false}
:as opts}]
(us/verify ::cp/changes changes)
(us/verify ::cp/changes undo-changes)
(us/assert ::cp/changes changes)
(us/assert ::cp/changes undo-changes)
(log/debug :msg "commit-changes"
:js/changes changes
:js/undo-changes undo-changes)
@ -183,7 +186,7 @@
[:workspace-data]
[:workspace-libraries file-id :data])]
(try
(us/verify ::spec/changes changes)
(us/assert ::spec/changes changes)
(let [state (update-in state path1 cp/process-changes changes false)]
(cond-> state
commit-local? (update-in path2 cp/process-changes changes false)))

2
frontend/src/app/main/data/workspace/undo.cljs
View file

@ -83,7 +83,7 @@
(defn- append-undo
[entry]
(us/verify ::undo-entry entry)
(us/assert ::undo-entry entry)
(ptk/reify ::append-undo
ptk/UpdateEvent
(update [_ state]