Penpot/penpot
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-02-09 08:38:15 -05:00
Code Issues Activity

🐛 Improved performance for text resize

Browse source
This commit is contained in:
alonso.torres 2022-05-13 16:03:35 +02:00
parent 570f038062
commit 080139cd56
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
frontend/src/app/main/ui/workspace/shapes/text/viewport_texts.cljs
View file

@ -110,6 +110,8 @@
::mf/wrap [mf/memo #(mf/deferred % ts/idle-then-raf)]} ::mf/wrap [mf/memo #(mf/deferred % ts/idle-then-raf)]}
[props] [props]
(let [text-shapes (obj/get props "text-shapes") (let [text-shapes (obj/get props "text-shapes")
modifiers (obj/get props "modifiers")
prev-modifiers (hooks/use-previous modifiers)
prev-text-shapes (hooks/use-previous text-shapes) prev-text-shapes (hooks/use-previous text-shapes)
;; A change in position-data won't be a "real" change ;; A change in position-data won't be a "real" change
@ -117,8 +119,10 @@
(fn [id] (fn [id]
(let [old-shape (get prev-text-shapes id) (let [old-shape (get prev-text-shapes id)
new-shape (get text-shapes id)] new-shape (get text-shapes id)]
(and (not (identical? old-shape new-shape)) (or (and (not (identical? old-shape new-shape))
(not= old-shape new-shape)))) (not= old-shape new-shape))
(not= (get modifiers id)
(get prev-modifiers id)))))
changed-texts changed-texts
(mf/use-memo (mf/use-memo
@ -127,12 +131,15 @@
(filter text-change?) (filter text-change?)
(map (d/getf text-shapes)))) (map (d/getf text-shapes))))
handle-update-modifier (mf/use-callback update-text-modifier)
handle-update-shape (mf/use-callback update-text-shape)] handle-update-shape (mf/use-callback update-text-shape)]
[:* [:*
(for [{:keys [id] :as shape} changed-texts] (for [{:keys [id] :as shape} changed-texts]
[:& text-container {:shape (gsh/transform-shape shape) [:& text-container {:shape (gsh/transform-shape shape)
:on-update handle-update-shape :on-update (if (some? (get modifiers (:id shape)))
handle-update-modifier
handle-update-shape)
:key (str (dm/str "text-container-" id))}])])) :key (str (dm/str "text-container-" id))}])]))
(mf/defc viewport-text-editing (mf/defc viewport-text-editing