From 9a8c60c3cf4e8f5c448ff8c13925319df703fbec Mon Sep 17 00:00:00 2001 From: Thomas Brouard Date: Wed, 2 Nov 2016 16:37:05 +0100 Subject: [PATCH] visible option defaults to true --- README.md | 2 +- index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 444e6e6..5980393 100644 --- a/README.md +++ b/README.md @@ -66,7 +66,7 @@ Add a new tab to the tab group and returns a `Tab` instance. * `iconURL`: optional URL to the tab icon. * `closable` (default: `true`): if set to `true` the close button won't be displayed and the user won't be able to close the tab. See also `tab.close()`. * `webviewAttributes`: attributes to add to the webview tag. See [webview documentation](http://electron.atom.io/docs/api/web-view-tag/#tag-attributes). -* `visible` (default: `false`): set this to `true` if you want to display the tab once it is loaded. Otherwise you will need to call `tab.show()`. +* `visible` (default: `true`): set this to `false` if you don't want to display the tab once it is loaded. If set to `false` then you will need to call `tab.show()` to display the tab. * `ready`: a callback function to call once the tab is ready. The `Tab` instance is passed as the only parameter. #### `tabGroup.getTab(id)` diff --git a/index.js b/index.js index 23f7d9e..903a05c 100644 --- a/index.js +++ b/index.js @@ -130,7 +130,7 @@ class Tab extends EventEmitter { this.tabElements = {}; TabPrivate.initTab.bind(this)(); TabPrivate.initWebview.bind(this)(); - if (args.visible) { + if (args.visible !== false) { this.show(); } if (typeof args.ready === "function") {