mirror of
https://github.com/project-zot/zot.git
synced 2025-01-27 23:01:43 -05:00
b80deb9927
unified both local and s3 ImageStore logic into a single ImageStore added a new driver interface for common file/dirs manipulations to be implemented by different storage types refactor(gc): drop umoci dependency, implemented internal gc added retentionDelay config option that specifies the garbage collect delay for images without tags this will also clean manifests which are part of an index image (multiarch) that no longer exist. fix(dedupe): skip blobs under .sync/ directory if startup dedupe is running while also syncing is running ignore blobs under sync's temporary storage fix(storage): do not allow image indexes modifications when deleting a manifest verify that it is not part of a multiarch image and throw a MethodNotAllowed error to the client if it is. we don't want to modify multiarch images Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
1028 lines
31 KiB
Go
1028 lines
31 KiB
Go
//go:build search && userprefs
|
|
|
|
package search_test
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"net/url"
|
|
"os"
|
|
"testing"
|
|
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
"golang.org/x/crypto/bcrypt"
|
|
"gopkg.in/resty.v1"
|
|
|
|
"zotregistry.io/zot/pkg/api"
|
|
"zotregistry.io/zot/pkg/api/config"
|
|
"zotregistry.io/zot/pkg/api/constants"
|
|
"zotregistry.io/zot/pkg/common"
|
|
extconf "zotregistry.io/zot/pkg/extensions/config"
|
|
"zotregistry.io/zot/pkg/extensions/monitoring"
|
|
"zotregistry.io/zot/pkg/log"
|
|
"zotregistry.io/zot/pkg/storage"
|
|
"zotregistry.io/zot/pkg/storage/local"
|
|
. "zotregistry.io/zot/pkg/test"
|
|
)
|
|
|
|
//nolint:dupl
|
|
func TestUserData(t *testing.T) {
|
|
Convey("Test user stars and bookmarks", t, func(c C) {
|
|
port := GetFreePort()
|
|
baseURL := GetBaseURL(port)
|
|
defaultVal := true
|
|
|
|
accessibleRepo := "accessible-repo"
|
|
forbiddenRepo := "forbidden-repo"
|
|
tag := "0.0.1"
|
|
|
|
adminUser := "alice"
|
|
adminPassword := "deepGoesTheRabbitBurrow"
|
|
simpleUser := "test"
|
|
simpleUserPassword := "test123"
|
|
|
|
twoCredTests := fmt.Sprintf("%s\n%s\n\n", getCredString(adminUser, adminPassword),
|
|
getCredString(simpleUser, simpleUserPassword))
|
|
|
|
htpasswdPath := MakeHtpasswdFileFromString(twoCredTests)
|
|
defer os.Remove(htpasswdPath)
|
|
|
|
conf := config.New()
|
|
conf.Storage.RootDirectory = t.TempDir()
|
|
conf.HTTP.Port = port
|
|
conf.HTTP.Auth = &config.AuthConfig{
|
|
HTPasswd: config.AuthHTPasswd{
|
|
Path: htpasswdPath,
|
|
},
|
|
}
|
|
conf.HTTP.AccessControl = &config.AccessControlConfig{
|
|
Repositories: config.Repositories{
|
|
"**": config.PolicyGroup{
|
|
Policies: []config.Policy{
|
|
{
|
|
Users: []string{simpleUser},
|
|
Actions: []string{"read"},
|
|
},
|
|
},
|
|
AnonymousPolicy: []string{"read"},
|
|
DefaultPolicy: []string{},
|
|
},
|
|
forbiddenRepo: config.PolicyGroup{
|
|
Policies: []config.Policy{
|
|
{
|
|
Users: []string{},
|
|
Actions: []string{},
|
|
},
|
|
},
|
|
DefaultPolicy: []string{},
|
|
},
|
|
},
|
|
AdminPolicy: config.Policy{
|
|
Users: []string{adminUser},
|
|
Actions: []string{"read", "create", "update"},
|
|
},
|
|
}
|
|
conf.Extensions = &extconf.ExtensionConfig{}
|
|
conf.Extensions.Search = &extconf.SearchConfig{}
|
|
conf.Extensions.Search.Enable = &defaultVal
|
|
conf.Extensions.Search.CVE = nil
|
|
conf.Extensions.UI = &extconf.UIConfig{}
|
|
conf.Extensions.UI.Enable = &defaultVal
|
|
|
|
ctlr := api.NewController(conf)
|
|
|
|
ctlrManager := NewControllerManager(ctlr)
|
|
ctlrManager.StartAndWait(port)
|
|
defer ctlrManager.StopServer()
|
|
|
|
config, layers, manifest, err := GetImageComponents(100)
|
|
So(err, ShouldBeNil)
|
|
|
|
err = UploadImageWithBasicAuth(
|
|
Image{
|
|
Config: config,
|
|
Layers: layers,
|
|
Manifest: manifest,
|
|
}, baseURL, accessibleRepo, tag,
|
|
adminUser, adminPassword,
|
|
)
|
|
So(err, ShouldBeNil)
|
|
|
|
err = UploadImageWithBasicAuth(
|
|
Image{
|
|
Config: config,
|
|
Layers: layers,
|
|
Manifest: manifest,
|
|
}, baseURL, forbiddenRepo, tag,
|
|
adminUser, adminPassword,
|
|
)
|
|
So(err, ShouldBeNil)
|
|
|
|
userStaredReposQuery := `{
|
|
StarredRepos {
|
|
Results {
|
|
Name StarCount IsStarred
|
|
NewestImage { Tag }
|
|
}
|
|
}
|
|
}`
|
|
|
|
userBookmarkedReposQuery := `{
|
|
BookmarkedRepos {
|
|
Results {
|
|
Name IsBookmarked
|
|
NewestImage { Tag }
|
|
}
|
|
}
|
|
}`
|
|
|
|
userprefsBaseURL := baseURL + constants.FullUserPrefs
|
|
|
|
Convey("Flip starred repo authorized", func(c C) {
|
|
clientHTTP := resty.R().SetBasicAuth(simpleUser, simpleUserPassword)
|
|
|
|
resp, err := clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userStaredReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct := common.StarredReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoStarURL(accessibleRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userStaredReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.StarredReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 1)
|
|
So(responseStruct.Results[0].Name, ShouldEqual, accessibleRepo)
|
|
// need to update RepoSummary according to user settings
|
|
So(responseStruct.Results[0].IsStarred, ShouldEqual, true)
|
|
So(responseStruct.Results[0].StarCount, ShouldEqual, 1)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoStarURL(accessibleRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userStaredReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.StarredReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("Flip starred repo unauthenticated user", func(c C) {
|
|
clientHTTP := resty.R()
|
|
|
|
resp, err := clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userStaredReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct := common.StarredReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoStarURL(accessibleRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusForbidden)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userStaredReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.StarredReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("Flip starred repo unauthorized", func(c C) {
|
|
clientHTTP := resty.R().SetBasicAuth(simpleUser, simpleUserPassword)
|
|
|
|
resp, err := clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userStaredReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct := common.StarredReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoStarURL(forbiddenRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusForbidden)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userStaredReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.StarredReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("Flip starred repo with unauthorized repo and admin user", func(c C) {
|
|
clientHTTP := resty.R().SetBasicAuth(adminUser, adminPassword)
|
|
|
|
resp, err := clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userStaredReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct := common.StarredReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoStarURL(forbiddenRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userStaredReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.StarredReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 1)
|
|
So(responseStruct.Results[0].Name, ShouldEqual, forbiddenRepo)
|
|
// need to update RepoSummary according to user settings
|
|
So(responseStruct.Results[0].IsStarred, ShouldEqual, true)
|
|
So(responseStruct.Results[0].StarCount, ShouldEqual, 1)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoStarURL(forbiddenRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userStaredReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.StarredReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("Flip bookmark repo authorized", func(c C) {
|
|
clientHTTP := resty.R().SetBasicAuth(simpleUser, simpleUserPassword)
|
|
|
|
resp, err := clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userBookmarkedReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct := common.BookmarkedReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoBookmarkURL(accessibleRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userBookmarkedReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.BookmarkedReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 1)
|
|
So(responseStruct.Results[0].Name, ShouldEqual, accessibleRepo)
|
|
// need to update RepoSummary according to user settings
|
|
So(responseStruct.Results[0].IsBookmarked, ShouldEqual, true)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoBookmarkURL(accessibleRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userBookmarkedReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.BookmarkedReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("Flip bookmark repo unauthenticated user", func(c C) {
|
|
clientHTTP := resty.R()
|
|
|
|
resp, err := clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userBookmarkedReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct := common.BookmarkedReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoBookmarkURL(accessibleRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusForbidden)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userBookmarkedReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.BookmarkedReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("Flip bookmark repo unauthorized", func(c C) {
|
|
clientHTTP := resty.R().SetBasicAuth(simpleUser, simpleUserPassword)
|
|
|
|
resp, err := clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userBookmarkedReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct := common.BookmarkedReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoBookmarkURL(forbiddenRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusForbidden)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userBookmarkedReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.BookmarkedReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("Flip bookmarked unauthorized repo and admin user", func(c C) {
|
|
clientHTTP := resty.R().SetBasicAuth(adminUser, adminPassword)
|
|
|
|
resp, err := clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userBookmarkedReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct := common.BookmarkedReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoBookmarkURL(forbiddenRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userBookmarkedReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.BookmarkedReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 1)
|
|
So(responseStruct.Results[0].Name, ShouldEqual, forbiddenRepo)
|
|
// need to update RepoSummary according to user settings
|
|
So(responseStruct.Results[0].IsBookmarked, ShouldEqual, true)
|
|
|
|
resp, err = clientHTTP.Put(userprefsBaseURL + PutRepoBookmarkURL(forbiddenRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
resp, err = clientHTTP.Get(baseURL + constants.FullSearchPrefix +
|
|
"?query=" + url.QueryEscape(userBookmarkedReposQuery))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.BookmarkedReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 0)
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestChangingRepoState(t *testing.T) {
|
|
port := GetFreePort()
|
|
baseURL := GetBaseURL(port)
|
|
defaultVal := true
|
|
|
|
simpleUser := "test"
|
|
simpleUserPassword := "test123"
|
|
|
|
forbiddenRepo := "forbidden"
|
|
accesibleRepo := "accesible"
|
|
|
|
credTests := fmt.Sprintf("%s\n\n", getCredString(simpleUser, simpleUserPassword))
|
|
|
|
htpasswdPath := MakeHtpasswdFileFromString(credTests)
|
|
defer os.Remove(htpasswdPath)
|
|
|
|
conf := config.New()
|
|
conf.Storage.RootDirectory = t.TempDir()
|
|
conf.HTTP.Port = port
|
|
conf.HTTP.Auth = &config.AuthConfig{
|
|
HTPasswd: config.AuthHTPasswd{
|
|
Path: htpasswdPath,
|
|
},
|
|
}
|
|
conf.HTTP.AccessControl = &config.AccessControlConfig{
|
|
Repositories: config.Repositories{
|
|
"**": config.PolicyGroup{
|
|
Policies: []config.Policy{
|
|
{
|
|
Users: []string{simpleUser},
|
|
Actions: []string{"read"},
|
|
},
|
|
},
|
|
AnonymousPolicy: []string{"read"},
|
|
DefaultPolicy: []string{},
|
|
},
|
|
forbiddenRepo: config.PolicyGroup{
|
|
Policies: []config.Policy{
|
|
{
|
|
Users: []string{},
|
|
Actions: []string{},
|
|
},
|
|
},
|
|
DefaultPolicy: []string{},
|
|
},
|
|
},
|
|
}
|
|
conf.Extensions = &extconf.ExtensionConfig{}
|
|
conf.Extensions.Search = &extconf.SearchConfig{}
|
|
conf.Extensions.Search.Enable = &defaultVal
|
|
conf.Extensions.Search.CVE = nil
|
|
conf.Extensions.UI = &extconf.UIConfig{}
|
|
conf.Extensions.UI.Enable = &defaultVal
|
|
|
|
gqlStarredRepos := `
|
|
{
|
|
StarredRepos() {
|
|
Results {
|
|
Name
|
|
StarCount
|
|
IsBookmarked
|
|
IsStarred
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
gqlBookmarkedRepos := `
|
|
{
|
|
BookmarkedRepos() {
|
|
Results {
|
|
Name
|
|
StarCount
|
|
IsBookmarked
|
|
IsStarred
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
ctlr := api.NewController(conf)
|
|
|
|
img, err := GetRandomImage()
|
|
if err != nil {
|
|
t.FailNow()
|
|
}
|
|
|
|
// ------ Create the test repos
|
|
defaultStore := local.NewImageStore(conf.Storage.RootDirectory, false, false, 0, 0, false, false,
|
|
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), nil, nil)
|
|
|
|
err = WriteImageToFileSystem(img, accesibleRepo, "tag", storage.StoreController{
|
|
DefaultStore: defaultStore,
|
|
})
|
|
if err != nil {
|
|
t.FailNow()
|
|
}
|
|
|
|
err = WriteImageToFileSystem(img, forbiddenRepo, "tag", storage.StoreController{
|
|
DefaultStore: defaultStore,
|
|
})
|
|
if err != nil {
|
|
t.FailNow()
|
|
}
|
|
|
|
ctlrManager := NewControllerManager(ctlr)
|
|
|
|
ctlrManager.StartAndWait(port)
|
|
|
|
defer ctlrManager.StopServer()
|
|
|
|
simpleUserClient := resty.R().SetBasicAuth(simpleUser, simpleUserPassword)
|
|
anonynousClient := resty.R()
|
|
|
|
userprefsBaseURL := baseURL + constants.FullUserPrefs
|
|
|
|
Convey("PutStars", t, func() {
|
|
resp, err := simpleUserClient.Put(userprefsBaseURL + PutRepoStarURL(accesibleRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
resp, err = simpleUserClient.Get(baseURL + graphqlQueryPrefix + "?query=" + url.QueryEscape(gqlStarredRepos))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
responseStruct := common.StarredReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 1)
|
|
So(responseStruct.Results[0].IsStarred, ShouldBeTrue)
|
|
So(responseStruct.Results[0].Name, ShouldResemble, accesibleRepo)
|
|
|
|
resp, err = anonynousClient.Put(userprefsBaseURL + PutRepoStarURL(accesibleRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusForbidden)
|
|
})
|
|
//
|
|
Convey("PutBookmark", t, func() {
|
|
resp, err := simpleUserClient.Put(userprefsBaseURL + PutRepoBookmarkURL(accesibleRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
resp, err = simpleUserClient.Get(baseURL + graphqlQueryPrefix + "?query=" + url.QueryEscape(gqlBookmarkedRepos))
|
|
So(err, ShouldBeNil)
|
|
So(resp, ShouldNotBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
|
|
responseStruct := common.BookmarkedReposResponse{}
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
So(err, ShouldBeNil)
|
|
So(len(responseStruct.Results), ShouldEqual, 1)
|
|
So(responseStruct.Results[0].IsBookmarked, ShouldBeTrue)
|
|
So(responseStruct.Results[0].Name, ShouldResemble, accesibleRepo)
|
|
|
|
resp, err = anonynousClient.Put(userprefsBaseURL + PutRepoBookmarkURL(accesibleRepo))
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusForbidden)
|
|
})
|
|
}
|
|
|
|
func TestGlobalSearchWithUserPrefFiltering(t *testing.T) {
|
|
Convey("Bookmarks and Stars filtering", t, func() {
|
|
dir := t.TempDir()
|
|
port := GetFreePort()
|
|
baseURL := GetBaseURL(port)
|
|
conf := config.New()
|
|
conf.HTTP.Port = port
|
|
conf.Storage.RootDirectory = dir
|
|
|
|
simpleUser := "simpleUser"
|
|
simpleUserPassword := "simpleUserPass"
|
|
credTests := fmt.Sprintf("%s\n\n", getCredString(simpleUser, simpleUserPassword))
|
|
|
|
htpasswdPath := MakeHtpasswdFileFromString(credTests)
|
|
defer os.Remove(htpasswdPath)
|
|
|
|
conf.HTTP.Auth = &config.AuthConfig{
|
|
HTPasswd: config.AuthHTPasswd{
|
|
Path: htpasswdPath,
|
|
},
|
|
}
|
|
|
|
conf.HTTP.AccessControl = &config.AccessControlConfig{
|
|
Repositories: config.Repositories{
|
|
"**": config.PolicyGroup{
|
|
Policies: []config.Policy{
|
|
{
|
|
Users: []string{simpleUser},
|
|
Actions: []string{"read", "create"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
defaultVal := true
|
|
conf.Extensions = &extconf.ExtensionConfig{}
|
|
conf.Extensions.Search = &extconf.SearchConfig{}
|
|
conf.Extensions.Search.Enable = &defaultVal
|
|
conf.Extensions.Search.CVE = nil
|
|
conf.Extensions.UI = &extconf.UIConfig{}
|
|
conf.Extensions.UI.Enable = &defaultVal
|
|
|
|
ctlr := api.NewController(conf)
|
|
|
|
ctlrManager := NewControllerManager(ctlr)
|
|
ctlrManager.StartAndWait(port)
|
|
defer ctlrManager.StopServer()
|
|
|
|
preferencesBaseURL := baseURL + constants.FullUserPrefs
|
|
simpleUserClient := resty.R().SetBasicAuth(simpleUser, simpleUserPassword)
|
|
|
|
// ------ Add simple repo
|
|
repo := "repo"
|
|
img, err := GetRandomImage()
|
|
So(err, ShouldBeNil)
|
|
err = UploadImageWithBasicAuth(img, baseURL, repo, "tag", simpleUser, simpleUserPassword)
|
|
So(err, ShouldBeNil)
|
|
|
|
// ------ Add repo and star it
|
|
sRepo := "starred-repo"
|
|
img, err = GetRandomImage()
|
|
So(err, ShouldBeNil)
|
|
err = UploadImageWithBasicAuth(img, baseURL, sRepo, "tag", simpleUser, simpleUserPassword)
|
|
So(err, ShouldBeNil)
|
|
|
|
resp, err := simpleUserClient.Put(preferencesBaseURL + PutRepoStarURL(sRepo))
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
So(err, ShouldBeNil)
|
|
|
|
// ------ Add repo and bookmark it
|
|
bRepo := "bookmarked-repo"
|
|
img, err = GetRandomImage()
|
|
So(err, ShouldBeNil)
|
|
err = UploadImageWithBasicAuth(img, baseURL, bRepo, "tag", simpleUser, simpleUserPassword)
|
|
So(err, ShouldBeNil)
|
|
|
|
resp, err = simpleUserClient.Put(preferencesBaseURL + PutRepoBookmarkURL(bRepo))
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
So(err, ShouldBeNil)
|
|
|
|
// ------ Add repo, star and bookmark it
|
|
sbRepo := "starred-bookmarked-repo"
|
|
img, err = GetRandomImage()
|
|
So(err, ShouldBeNil)
|
|
err = UploadImageWithBasicAuth(img, baseURL, sbRepo, "tag", simpleUser, simpleUserPassword)
|
|
So(err, ShouldBeNil)
|
|
|
|
resp, err = simpleUserClient.Put(preferencesBaseURL + PutRepoStarURL(sbRepo))
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
So(err, ShouldBeNil)
|
|
resp, err = simpleUserClient.Put(preferencesBaseURL + PutRepoBookmarkURL(sbRepo))
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
So(err, ShouldBeNil)
|
|
|
|
// Make global search requests filterin by IsStarred and IsBookmarked
|
|
|
|
query := `{ GlobalSearch(query:"repo", ){ Repos { Name } } }`
|
|
|
|
resp, err = simpleUserClient.Get(baseURL + graphqlQueryPrefix + "?query=" + url.QueryEscape(query))
|
|
So(resp, ShouldNotBeNil)
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct := &common.GlobalSearchResultResp{}
|
|
|
|
err = json.Unmarshal(resp.Body(), responseStruct)
|
|
So(err, ShouldBeNil)
|
|
|
|
foundRepos := responseStruct.Repos
|
|
So(len(foundRepos), ShouldEqual, 4)
|
|
|
|
// Filter by IsStarred = true
|
|
query = `{ GlobalSearch(query:"repo", filter:{ IsStarred:true }) { Repos { Name IsStarred IsBookmarked }}}`
|
|
|
|
resp, err = simpleUserClient.Get(baseURL + graphqlQueryPrefix + "?query=" + url.QueryEscape(query))
|
|
So(resp, ShouldNotBeNil)
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = &common.GlobalSearchResultResp{}
|
|
|
|
err = json.Unmarshal(resp.Body(), responseStruct)
|
|
So(err, ShouldBeNil)
|
|
|
|
foundRepos = responseStruct.Repos
|
|
So(len(foundRepos), ShouldEqual, 2)
|
|
So(foundRepos, ShouldContain, common.RepoSummary{Name: sRepo, IsStarred: true, IsBookmarked: false})
|
|
So(foundRepos, ShouldContain, common.RepoSummary{Name: sbRepo, IsStarred: true, IsBookmarked: true})
|
|
|
|
// Filter by IsStarred = true && IsBookmarked = false
|
|
query = `{
|
|
GlobalSearch(query:"repo", filter:{ IsStarred:true, IsBookmarked:false }) {
|
|
Repos { Name IsStarred IsBookmarked }
|
|
}
|
|
}`
|
|
|
|
resp, err = simpleUserClient.Get(baseURL + graphqlQueryPrefix + "?query=" + url.QueryEscape(query))
|
|
So(resp, ShouldNotBeNil)
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = &common.GlobalSearchResultResp{}
|
|
|
|
err = json.Unmarshal(resp.Body(), responseStruct)
|
|
So(err, ShouldBeNil)
|
|
|
|
foundRepos = responseStruct.Repos
|
|
So(len(foundRepos), ShouldEqual, 1)
|
|
So(foundRepos, ShouldContain, common.RepoSummary{Name: sRepo, IsStarred: true, IsBookmarked: false})
|
|
|
|
// Filter by IsBookmarked = true
|
|
query = `{
|
|
GlobalSearch(query:"repo", filter:{ IsBookmarked:true }) {
|
|
Repos { Name IsStarred IsBookmarked }
|
|
}
|
|
}`
|
|
|
|
resp, err = simpleUserClient.Get(baseURL + graphqlQueryPrefix + "?query=" + url.QueryEscape(query))
|
|
So(resp, ShouldNotBeNil)
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = &common.GlobalSearchResultResp{}
|
|
|
|
err = json.Unmarshal(resp.Body(), responseStruct)
|
|
So(err, ShouldBeNil)
|
|
|
|
foundRepos = responseStruct.Repos
|
|
So(len(foundRepos), ShouldEqual, 2)
|
|
So(foundRepos, ShouldContain, common.RepoSummary{Name: bRepo, IsStarred: false, IsBookmarked: true})
|
|
So(foundRepos, ShouldContain, common.RepoSummary{Name: sbRepo, IsStarred: true, IsBookmarked: true})
|
|
|
|
// Filter by IsBookmarked = true && IsStarred = false
|
|
query = `{
|
|
GlobalSearch(query:"repo", filter:{ IsBookmarked:true, IsStarred:false }) {
|
|
Repos { Name IsStarred IsBookmarked }
|
|
}
|
|
}`
|
|
|
|
resp, err = simpleUserClient.Get(baseURL + graphqlQueryPrefix + "?query=" + url.QueryEscape(query))
|
|
So(resp, ShouldNotBeNil)
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = &common.GlobalSearchResultResp{}
|
|
|
|
err = json.Unmarshal(resp.Body(), responseStruct)
|
|
So(err, ShouldBeNil)
|
|
|
|
foundRepos = responseStruct.Repos
|
|
So(len(foundRepos), ShouldEqual, 1)
|
|
So(foundRepos, ShouldContain, common.RepoSummary{Name: bRepo, IsStarred: false, IsBookmarked: true})
|
|
})
|
|
}
|
|
|
|
func TestExpandedRepoInfoWithUserPrefs(t *testing.T) {
|
|
Convey("ExpandedRepoInfo with User Prefs", t, func() {
|
|
dir := t.TempDir()
|
|
port := GetFreePort()
|
|
baseURL := GetBaseURL(port)
|
|
conf := config.New()
|
|
conf.HTTP.Port = port
|
|
conf.Storage.RootDirectory = dir
|
|
|
|
simpleUser := "simpleUser"
|
|
simpleUserPassword := "simpleUserPass"
|
|
credTests := fmt.Sprintf("%s\n\n", getCredString(simpleUser, simpleUserPassword))
|
|
|
|
htpasswdPath := MakeHtpasswdFileFromString(credTests)
|
|
defer os.Remove(htpasswdPath)
|
|
|
|
conf.HTTP.Auth = &config.AuthConfig{
|
|
HTPasswd: config.AuthHTPasswd{
|
|
Path: htpasswdPath,
|
|
},
|
|
}
|
|
|
|
conf.HTTP.AccessControl = &config.AccessControlConfig{
|
|
Repositories: config.Repositories{
|
|
"**": config.PolicyGroup{
|
|
Policies: []config.Policy{
|
|
{
|
|
Users: []string{simpleUser},
|
|
Actions: []string{"read", "create"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
defaultVal := true
|
|
conf.Extensions = &extconf.ExtensionConfig{}
|
|
conf.Extensions.Search = &extconf.SearchConfig{}
|
|
conf.Extensions.Search.Enable = &defaultVal
|
|
conf.Extensions.Search.CVE = nil
|
|
conf.Extensions.UI = &extconf.UIConfig{}
|
|
conf.Extensions.UI.Enable = &defaultVal
|
|
|
|
ctlr := api.NewController(conf)
|
|
|
|
ctlrManager := NewControllerManager(ctlr)
|
|
ctlrManager.StartAndWait(port)
|
|
defer ctlrManager.StopServer()
|
|
|
|
preferencesBaseURL := baseURL + constants.FullUserPrefs
|
|
simpleUserClient := resty.R().SetBasicAuth(simpleUser, simpleUserPassword)
|
|
|
|
// ------ Add sbrepo and star/bookmark it
|
|
sbrepo := "sbrepo"
|
|
img, err := GetRandomImage()
|
|
So(err, ShouldBeNil)
|
|
err = UploadImageWithBasicAuth(img, baseURL, sbrepo, "tag", simpleUser, simpleUserPassword)
|
|
So(err, ShouldBeNil)
|
|
|
|
resp, err := simpleUserClient.Put(preferencesBaseURL + PutRepoStarURL(sbrepo))
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
So(err, ShouldBeNil)
|
|
|
|
resp, err = simpleUserClient.Put(preferencesBaseURL + PutRepoBookmarkURL(sbrepo))
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
So(err, ShouldBeNil)
|
|
|
|
// ExpandedRepoinfo
|
|
|
|
query := `
|
|
{
|
|
ExpandedRepoInfo(repo:"sbrepo"){
|
|
Summary {
|
|
Name IsStarred IsBookmarked
|
|
}
|
|
}
|
|
}`
|
|
|
|
resp, err = simpleUserClient.Get(baseURL + graphqlQueryPrefix + "?query=" + url.QueryEscape(query))
|
|
So(resp, ShouldNotBeNil)
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct := common.ExpandedRepoInfoResp{}
|
|
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
|
|
repoInfo := responseStruct.RepoInfo
|
|
So(repoInfo.Summary.IsBookmarked, ShouldBeTrue)
|
|
So(repoInfo.Summary.IsStarred, ShouldBeTrue)
|
|
|
|
// ------ Add srepo and star it
|
|
srepo := "srepo"
|
|
img, err = GetRandomImage()
|
|
So(err, ShouldBeNil)
|
|
err = UploadImageWithBasicAuth(img, baseURL, srepo, "tag", simpleUser, simpleUserPassword)
|
|
So(err, ShouldBeNil)
|
|
|
|
resp, err = simpleUserClient.Put(preferencesBaseURL + PutRepoStarURL(srepo))
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
So(err, ShouldBeNil)
|
|
|
|
// ExpandedRepoinfo
|
|
query = `
|
|
{
|
|
ExpandedRepoInfo(repo:"srepo"){
|
|
Summary {
|
|
Name IsStarred IsBookmarked
|
|
}
|
|
}
|
|
}`
|
|
|
|
resp, err = simpleUserClient.Get(baseURL + graphqlQueryPrefix + "?query=" + url.QueryEscape(query))
|
|
So(resp, ShouldNotBeNil)
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.ExpandedRepoInfoResp{}
|
|
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
|
|
repoInfo = responseStruct.RepoInfo
|
|
So(repoInfo.Summary.IsBookmarked, ShouldBeFalse)
|
|
So(repoInfo.Summary.IsStarred, ShouldBeTrue)
|
|
|
|
// ------ Add brepo and bookmark it
|
|
brepo := "brepo"
|
|
img, err = GetRandomImage()
|
|
So(err, ShouldBeNil)
|
|
err = UploadImageWithBasicAuth(img, baseURL, brepo, "tag", simpleUser, simpleUserPassword)
|
|
So(err, ShouldBeNil)
|
|
|
|
resp, err = simpleUserClient.Put(preferencesBaseURL + PutRepoBookmarkURL(brepo))
|
|
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
|
|
So(err, ShouldBeNil)
|
|
|
|
// ExpandedRepoinfo
|
|
query = `
|
|
{
|
|
ExpandedRepoInfo(repo:"brepo"){
|
|
Summary {
|
|
Name IsStarred IsBookmarked
|
|
}
|
|
}
|
|
}`
|
|
|
|
resp, err = simpleUserClient.Get(baseURL + graphqlQueryPrefix + "?query=" + url.QueryEscape(query))
|
|
So(resp, ShouldNotBeNil)
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.ExpandedRepoInfoResp{}
|
|
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
|
|
repoInfo = responseStruct.RepoInfo
|
|
So(repoInfo.Summary.IsBookmarked, ShouldBeTrue)
|
|
So(repoInfo.Summary.IsStarred, ShouldBeFalse)
|
|
|
|
// ------ Add repo without star/bookmark
|
|
repo := "repo"
|
|
img, err = GetRandomImage()
|
|
So(err, ShouldBeNil)
|
|
err = UploadImageWithBasicAuth(img, baseURL, repo, "tag", simpleUser, simpleUserPassword)
|
|
So(err, ShouldBeNil)
|
|
|
|
// ExpandedRepoinfo
|
|
query = `
|
|
{
|
|
ExpandedRepoInfo(repo:"repo"){
|
|
Summary {
|
|
Name IsStarred IsBookmarked
|
|
}
|
|
}
|
|
}`
|
|
|
|
resp, err = simpleUserClient.Get(baseURL + graphqlQueryPrefix + "?query=" + url.QueryEscape(query))
|
|
So(resp, ShouldNotBeNil)
|
|
So(err, ShouldBeNil)
|
|
So(resp.StatusCode(), ShouldEqual, 200)
|
|
|
|
responseStruct = common.ExpandedRepoInfoResp{}
|
|
|
|
err = json.Unmarshal(resp.Body(), &responseStruct)
|
|
So(err, ShouldBeNil)
|
|
|
|
repoInfo = responseStruct.RepoInfo
|
|
So(repoInfo.Summary.IsBookmarked, ShouldBeFalse)
|
|
So(repoInfo.Summary.IsStarred, ShouldBeFalse)
|
|
})
|
|
}
|
|
|
|
func PutRepoStarURL(repo string) string {
|
|
return fmt.Sprintf("?repo=%s&action=toggleStar", repo)
|
|
}
|
|
|
|
func PutRepoBookmarkURL(repo string) string {
|
|
return fmt.Sprintf("?repo=%s&action=toggleBookmark", repo)
|
|
}
|
|
|
|
func getCredString(username, password string) string {
|
|
hash, err := bcrypt.GenerateFromPassword([]byte(password), 10)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
usernameAndHash := fmt.Sprintf("%s:%s", username, string(hash))
|
|
|
|
return usernameAndHash
|
|
}
|