mirror of
https://github.com/project-zot/zot.git
synced 2025-03-11 02:17:43 -05:00
6a83dd47c0
This causes the "fair" scheduler to run it too often in the detriment of other generators. The intention was to run it every 2 hours but the measurement unit for 7200 was not specified. Add more logs, including showing a generator name, in order to troubleshoot this kind of issues easier in the future. Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
90 lines
2.1 KiB
Go
90 lines
2.1 KiB
Go
//go:build scrub
|
|
// +build scrub
|
|
|
|
package extensions
|
|
|
|
import (
|
|
"time"
|
|
|
|
"zotregistry.dev/zot/pkg/api/config"
|
|
"zotregistry.dev/zot/pkg/extensions/scrub"
|
|
"zotregistry.dev/zot/pkg/log"
|
|
"zotregistry.dev/zot/pkg/scheduler"
|
|
"zotregistry.dev/zot/pkg/storage"
|
|
storageTypes "zotregistry.dev/zot/pkg/storage/types"
|
|
)
|
|
|
|
// EnableScrubExtension enables scrub extension.
|
|
func EnableScrubExtension(config *config.Config, log log.Logger, storeController storage.StoreController,
|
|
sch *scheduler.Scheduler,
|
|
) {
|
|
if config.Extensions.Scrub != nil &&
|
|
*config.Extensions.Scrub.Enable {
|
|
minScrubInterval, _ := time.ParseDuration("2h")
|
|
|
|
if config.Extensions.Scrub.Interval < minScrubInterval {
|
|
config.Extensions.Scrub.Interval = minScrubInterval
|
|
|
|
log.Warn().Msg("scrub interval set to too-short interval < 2h, changing scrub duration to 2 hours and continuing.") //nolint:lll // gofumpt conflicts with lll
|
|
}
|
|
|
|
generator := &taskGenerator{
|
|
imgStore: storeController.DefaultStore,
|
|
log: log,
|
|
}
|
|
sch.SubmitGenerator(generator, config.Extensions.Scrub.Interval, scheduler.LowPriority)
|
|
|
|
if config.Storage.SubPaths != nil {
|
|
for route := range config.Storage.SubPaths {
|
|
generator := &taskGenerator{
|
|
imgStore: storeController.SubStore[route],
|
|
log: log,
|
|
}
|
|
sch.SubmitGenerator(generator, config.Extensions.Scrub.Interval, scheduler.LowPriority)
|
|
}
|
|
}
|
|
} else {
|
|
log.Info().Msg("scrub config not provided, skipping scrub")
|
|
}
|
|
}
|
|
|
|
type taskGenerator struct {
|
|
imgStore storageTypes.ImageStore
|
|
log log.Logger
|
|
lastRepo string
|
|
done bool
|
|
}
|
|
|
|
func (gen *taskGenerator) Name() string {
|
|
return "ScrubGenerator"
|
|
}
|
|
|
|
func (gen *taskGenerator) Next() (scheduler.Task, error) {
|
|
repo, err := gen.imgStore.GetNextRepository(gen.lastRepo)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if repo == "" {
|
|
gen.done = true
|
|
|
|
return nil, nil
|
|
}
|
|
|
|
gen.lastRepo = repo
|
|
|
|
return scrub.NewTask(gen.imgStore, repo, gen.log), nil
|
|
}
|
|
|
|
func (gen *taskGenerator) IsDone() bool {
|
|
return gen.done
|
|
}
|
|
|
|
func (gen *taskGenerator) IsReady() bool {
|
|
return true
|
|
}
|
|
|
|
func (gen *taskGenerator) Reset() {
|
|
gen.lastRepo = ""
|
|
gen.done = false
|
|
}
|