mirror of
https://github.com/project-zot/zot.git
synced 2024-12-16 21:56:37 -05:00
e3ac50b2a2
https://github.com/project-zot/zot/issues/1594 - use indent ' ' in the config json https://github.com/project-zot/zot/issues/1593 - add subcommand `zli config remove` Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
467 lines
13 KiB
Go
467 lines
13 KiB
Go
//go:build search
|
|
// +build search
|
|
|
|
package cli //nolint:testpackage
|
|
|
|
import (
|
|
"bytes"
|
|
"log"
|
|
"os"
|
|
"regexp"
|
|
"strings"
|
|
"testing"
|
|
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
|
|
zotErrors "zotregistry.io/zot/errors"
|
|
)
|
|
|
|
func TestConfigCmdBasics(t *testing.T) {
|
|
Convey("Test config help", t, func() {
|
|
args := []string{"--help"}
|
|
configPath := makeConfigFile("showspinner = false")
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(buff.String(), ShouldContainSubstring, "Usage")
|
|
So(err, ShouldBeNil)
|
|
Convey("with the shorthand", func() {
|
|
args[0] = "-h"
|
|
configPath := makeConfigFile("showspinner = false")
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(buff.String(), ShouldContainSubstring, "Usage")
|
|
So(err, ShouldBeNil)
|
|
})
|
|
})
|
|
|
|
Convey("Test config no args", t, func() {
|
|
args := []string{}
|
|
configPath := makeConfigFile("showspinner = false")
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(buff.String(), ShouldContainSubstring, "Usage")
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
}
|
|
|
|
func TestConfigCmdMain(t *testing.T) {
|
|
Convey("Test add config", t, func() {
|
|
args := []string{"add", "configtest1", "https://test-url.com"}
|
|
file := makeConfigFile("")
|
|
defer os.Remove(file)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
_ = cmd.Execute()
|
|
|
|
actual, err := os.ReadFile(file)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
actualStr := string(actual)
|
|
So(actualStr, ShouldContainSubstring, "configtest1")
|
|
So(actualStr, ShouldContainSubstring, "https://test-url.com")
|
|
})
|
|
|
|
Convey("Test error on home directory", t, func() {
|
|
args := []string{"add", "configtest1", "https://test-url.com"}
|
|
file := makeConfigFile("")
|
|
defer os.Remove(file)
|
|
|
|
err := os.Setenv("HOME", "nonExistentDirectory")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err = cmd.Execute()
|
|
So(err, ShouldNotBeNil)
|
|
|
|
home, err := os.UserHomeDir()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
err = os.Setenv("HOME", home)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
})
|
|
|
|
Convey("Test error on home directory at new add config", t, func() {
|
|
args := []string{"add", "configtest1", "https://test-url.com"}
|
|
file := makeConfigFile("")
|
|
defer os.Remove(file)
|
|
|
|
err := os.Setenv("HOME", "nonExistentDirectory")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
cmd := NewConfigAddCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err = cmd.Execute()
|
|
So(err, ShouldNotBeNil)
|
|
|
|
home, err := os.UserHomeDir()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
err = os.Setenv("HOME", home)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
})
|
|
|
|
Convey("Test add config with invalid format", t, func() {
|
|
args := []string{"--list"}
|
|
configPath := makeConfigFile(`{"configs":{"_name":"configtest","url":"https://test-url.com","showspinner":false}}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldEqual, zotErrors.ErrCliBadConfig)
|
|
})
|
|
|
|
Convey("Test add config with invalid URL", t, func() {
|
|
args := []string{"add", "configtest1", "test..com"}
|
|
file := makeConfigFile("")
|
|
defer os.Remove(file)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldNotBeNil)
|
|
So(err, ShouldEqual, zotErrors.ErrInvalidURL)
|
|
})
|
|
|
|
Convey("Test remove config entry successfully", t, func() {
|
|
args := []string{"remove", "configtest"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com","showspinner":false}]}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldBeNil)
|
|
actual, err := os.ReadFile(configPath)
|
|
So(err, ShouldBeNil)
|
|
space := regexp.MustCompile(`\s+`)
|
|
actualString := space.ReplaceAllString(string(actual), " ")
|
|
So(actualString, ShouldEqual, `{ "configs": [] }`)
|
|
})
|
|
|
|
Convey("Test remove missing config entry", t, func() {
|
|
args := []string{"remove", "configtest"}
|
|
configPath := makeConfigFile(`{"configs":[]`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldNotBeNil)
|
|
So(buff.String(), ShouldContainSubstring, "does not exist")
|
|
})
|
|
|
|
Convey("Test remove bad config file content", t, func() {
|
|
args := []string{"remove", "configtest"}
|
|
configPath := makeConfigFile(`{"asdf":[]`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldNotBeNil)
|
|
So(buff.String(), ShouldContainSubstring, "config json is empty")
|
|
})
|
|
|
|
Convey("Test remove bad config file entry", t, func() {
|
|
args := []string{"remove", "configtest"}
|
|
configPath := makeConfigFile(`{"configs":[asdad]`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldNotBeNil)
|
|
So(buff.String(), ShouldContainSubstring, "invalid config")
|
|
})
|
|
|
|
Convey("Test remove config bad permissions", t, func() {
|
|
args := []string{"remove", "configtest"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com","showspinner":false}]}`)
|
|
defer func() {
|
|
_ = os.Chmod(configPath, 0o600)
|
|
os.Remove(configPath)
|
|
}()
|
|
err := os.Chmod(configPath, 0o400) // Read-only, so we fail only on updating the file, not reading
|
|
So(err, ShouldBeNil)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err = cmd.Execute()
|
|
So(err, ShouldNotBeNil)
|
|
So(buff.String(), ShouldContainSubstring, "permission denied")
|
|
})
|
|
|
|
Convey("Test fetch all config", t, func() {
|
|
args := []string{"--list"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com","showspinner":false}]}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(buff.String(), ShouldContainSubstring, "https://test-url.com")
|
|
So(err, ShouldBeNil)
|
|
|
|
Convey("with the shorthand", func() {
|
|
args := []string{"-l"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com","showspinner":false}]}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(buff.String(), ShouldContainSubstring, "https://test-url.com")
|
|
So(err, ShouldBeNil)
|
|
})
|
|
|
|
Convey("From empty file", func() {
|
|
args := []string{"-l"}
|
|
configPath := makeConfigFile(``)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldBeNil)
|
|
So(strings.TrimSpace(buff.String()), ShouldEqual, "")
|
|
})
|
|
})
|
|
|
|
Convey("Test fetch a config", t, func() {
|
|
args := []string{"configtest", "--list"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com","showspinner":false}]}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(buff.String(), ShouldContainSubstring, "url = https://test-url.com")
|
|
So(buff.String(), ShouldContainSubstring, "showspinner = false")
|
|
So(err, ShouldBeNil)
|
|
|
|
Convey("with the shorthand", func() {
|
|
args := []string{"configtest", "-l"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com","showspinner":false}]}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(buff.String(), ShouldContainSubstring, "url = https://test-url.com")
|
|
So(buff.String(), ShouldContainSubstring, "showspinner = false")
|
|
So(err, ShouldBeNil)
|
|
})
|
|
|
|
Convey("From empty file", func() {
|
|
args := []string{"configtest", "-l"}
|
|
configPath := makeConfigFile(``)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldBeNil)
|
|
So(strings.TrimSpace(buff.String()), ShouldEqual, "")
|
|
})
|
|
})
|
|
|
|
Convey("Test fetch a config val", t, func() {
|
|
args := []string{"configtest", "url"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com","showspinner":false}]}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(buff.String(), ShouldEqual, "https://test-url.com\n")
|
|
So(err, ShouldBeNil)
|
|
|
|
Convey("From empty file", func() {
|
|
args := []string{"configtest", "url"}
|
|
configPath := makeConfigFile(``)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldNotBeNil)
|
|
So(buff.String(), ShouldContainSubstring, "does not exist")
|
|
})
|
|
})
|
|
|
|
Convey("Test add a config val", t, func() {
|
|
args := []string{"configtest", "showspinner", "false"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com"}]}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldBeNil)
|
|
|
|
actual, err := os.ReadFile(configPath)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
actualStr := string(actual)
|
|
So(actualStr, ShouldContainSubstring, "https://test-url.com")
|
|
So(actualStr, ShouldContainSubstring, `"showspinner": false`)
|
|
So(buff.String(), ShouldEqual, "")
|
|
|
|
Convey("To an empty file", func() {
|
|
args := []string{"configtest", "showspinner", "false"}
|
|
configPath := makeConfigFile(``)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldNotBeNil)
|
|
So(buff.String(), ShouldContainSubstring, "does not exist")
|
|
})
|
|
})
|
|
|
|
Convey("Test overwrite a config", t, func() {
|
|
args := []string{"configtest", "url", "https://new-url.com"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com","showspinner":false}]}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldBeNil)
|
|
|
|
actual, err := os.ReadFile(configPath)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
actualStr := string(actual)
|
|
So(actualStr, ShouldContainSubstring, `https://new-url.com`)
|
|
So(actualStr, ShouldContainSubstring, `"showspinner": false`)
|
|
So(actualStr, ShouldNotContainSubstring, `https://test-url.com`)
|
|
So(buff.String(), ShouldEqual, "")
|
|
})
|
|
|
|
Convey("Test reset a config val", t, func() {
|
|
args := []string{"configtest", "showspinner", "--reset"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com","showspinner":false}]}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldBeNil)
|
|
|
|
actual, err := os.ReadFile(configPath)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
actualStr := string(actual)
|
|
So(actualStr, ShouldNotContainSubstring, "showspinner")
|
|
So(actualStr, ShouldContainSubstring, `"url": "https://test-url.com"`)
|
|
So(buff.String(), ShouldEqual, "")
|
|
})
|
|
|
|
Convey("Test reset a url", t, func() {
|
|
args := []string{"configtest", "url", "--reset"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com","showspinner":false}]}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldNotBeNil)
|
|
So(buff.String(), ShouldContainSubstring, "cannot reset")
|
|
})
|
|
|
|
Convey("Test add a config with an existing saved name", t, func() {
|
|
args := []string{"add", "configtest", "https://test-url.com/new"}
|
|
configPath := makeConfigFile(`{"configs":[{"_name":"configtest","url":"https://test-url.com","showspinner":false}]}`)
|
|
defer os.Remove(configPath)
|
|
cmd := NewConfigCommand()
|
|
buff := bytes.NewBufferString("")
|
|
cmd.SetOut(buff)
|
|
cmd.SetErr(buff)
|
|
cmd.SetArgs(args)
|
|
err := cmd.Execute()
|
|
So(err, ShouldNotBeNil)
|
|
So(buff.String(), ShouldContainSubstring, "cli config name already added")
|
|
})
|
|
}
|