0
Fork 0
mirror of https://github.com/project-zot/zot.git synced 2024-12-16 21:56:37 -05:00
zot/pkg/cli/server
peusebiu 7642e5af98
fix(scheduler): fix data race (#2085)
* fix(scheduler): data race when pushing new tasks

the problem here is that scheduler can be closed in two ways:
- canceling the context given as argument to scheduler.RunScheduler()
- running scheduler.Shutdown()

because of this shutdown can trigger a data race between calling scheduler.inShutdown()
and actually pushing tasks into the pool workers

solved that by keeping a quit channel and listening on both quit channel and ctx.Done()
and closing the worker chan and scheduler afterwards.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>

* refactor(scheduler): refactor into a single shutdown

before this we could stop scheduler either by closing the context
provided to RunScheduler(ctx) or by running Shutdown().

simplify things by getting rid of the external context in RunScheduler().
keep an internal context in the scheduler itself and pass it down to all tasks.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>

---------

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
2023-12-11 10:00:34 -08:00
..
config_reloader.go fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
config_reloader_test.go refactor(test): add lint rule for messages starting with the component (#2045) 2023-12-08 10:05:02 +02:00
extensions_test.go refactor(test): add lint rule for messages starting with the component (#2045) 2023-12-08 10:05:02 +02:00
root.go fix(scheduler): fix data race (#2085) 2023-12-11 10:00:34 -08:00
root_test.go refactor(log): replace panics with log fatal or log panic functions (#1723) 2023-11-24 00:38:36 -08:00
stress_test.go feat(retention): added image retention policies (#1866) 2023-11-01 09:16:18 -07:00
validate_sync_disabled.go feat(retention): added image retention policies (#1866) 2023-11-01 09:16:18 -07:00
validate_sync_enabled.go feat(retention): added image retention policies (#1866) 2023-11-01 09:16:18 -07:00