mirror of
https://github.com/project-zot/zot.git
synced 2024-12-23 22:27:35 -05:00
16e9822c7f
This commit uses native go fuzzing to fuzz test implementations of storage in storage_fs. moved fuzzing testdata for storage_fs in separate repo added make target and script for importing fuzz data and running all fuzz tests Signed-off-by: Alex Stan <alexandrustan96@yahoo.ro>
2097 lines
57 KiB
Go
2097 lines
57 KiB
Go
package storage_test
|
|
|
|
import (
|
|
"bytes"
|
|
"crypto/rand"
|
|
_ "crypto/sha256"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"io/fs"
|
|
"io/ioutil"
|
|
"math/big"
|
|
"os"
|
|
"path"
|
|
"strings"
|
|
"syscall"
|
|
"testing"
|
|
"time"
|
|
|
|
godigest "github.com/opencontainers/go-digest"
|
|
imeta "github.com/opencontainers/image-spec/specs-go"
|
|
ispec "github.com/opencontainers/image-spec/specs-go/v1"
|
|
artifactspec "github.com/oras-project/artifacts-spec/specs-go/v1"
|
|
"github.com/rs/zerolog"
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
zerr "zotregistry.io/zot/errors"
|
|
"zotregistry.io/zot/pkg/extensions/monitoring"
|
|
"zotregistry.io/zot/pkg/log"
|
|
"zotregistry.io/zot/pkg/storage"
|
|
"zotregistry.io/zot/pkg/test"
|
|
)
|
|
|
|
const (
|
|
tag = "1.0"
|
|
)
|
|
|
|
func TestStorageFSAPIs(t *testing.T) {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true,
|
|
true, log, metrics, nil)
|
|
|
|
Convey("Repo layout", t, func(c C) {
|
|
Convey("Bad image manifest", func() {
|
|
upload, err := imgStore.NewBlobUpload(repoName)
|
|
So(err, ShouldBeNil)
|
|
So(upload, ShouldNotBeEmpty)
|
|
|
|
content := []byte("test-data1")
|
|
buf := bytes.NewBuffer(content)
|
|
buflen := buf.Len()
|
|
digest := godigest.FromBytes(content)
|
|
|
|
blob, err := imgStore.PutBlobChunk(repoName, upload, 0, int64(buflen), buf)
|
|
So(err, ShouldBeNil)
|
|
So(blob, ShouldEqual, buflen)
|
|
|
|
err = imgStore.FinishBlobUpload(repoName, upload, buf, digest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
annotationsMap := make(map[string]string)
|
|
annotationsMap[ispec.AnnotationRefName] = tag
|
|
|
|
cblob, cdigest := test.GetRandomImageConfig()
|
|
_, clen, err := imgStore.FullBlobUpload(repoName, bytes.NewReader(cblob), cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(clen, ShouldEqual, len(cblob))
|
|
hasBlob, _, err := imgStore.CheckBlob(repoName, cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
manifest := ispec.Manifest{
|
|
Config: ispec.Descriptor{
|
|
MediaType: "application/vnd.oci.image.config.v1+json",
|
|
Digest: cdigest,
|
|
Size: int64(len(cblob)),
|
|
},
|
|
Layers: []ispec.Descriptor{
|
|
{
|
|
MediaType: "application/vnd.oci.image.layer.v1.tar",
|
|
Digest: digest,
|
|
Size: int64(buflen),
|
|
},
|
|
},
|
|
Annotations: annotationsMap,
|
|
}
|
|
|
|
manifest.SchemaVersion = 2
|
|
manifestBuf, err := json.Marshal(manifest)
|
|
So(err, ShouldBeNil)
|
|
digest = godigest.FromBytes(manifestBuf)
|
|
|
|
err = os.Chmod(path.Join(imgStore.RootDir(), repoName, "index.json"), 0o000)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
_, err = imgStore.PutImageManifest(repoName, "1.0", ispec.MediaTypeImageManifest, manifestBuf)
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.Chmod(path.Join(imgStore.RootDir(), repoName, "index.json"), 0o755)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
_, err = imgStore.PutImageManifest(repoName, "1.0", ispec.MediaTypeImageManifest, manifestBuf)
|
|
So(err, ShouldBeNil)
|
|
|
|
manifestPath := path.Join(imgStore.RootDir(), repoName, "blobs", digest.Algorithm().String(), digest.Encoded())
|
|
|
|
err = os.Chmod(manifestPath, 0o000)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
_, _, _, err = imgStore.GetImageManifest(repoName, digest.String())
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.Remove(manifestPath)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
_, _, _, err = imgStore.GetImageManifest(repoName, digest.String())
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.Chmod(path.Join(imgStore.RootDir(), repoName), 0o000)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
_, err = imgStore.PutImageManifest(repoName, "2.0", ispec.MediaTypeImageManifest, manifestBuf)
|
|
So(err, ShouldNotBeNil)
|
|
err = os.Chmod(path.Join(imgStore.RootDir(), repoName), 0o755)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
// invalid GetReferrers
|
|
_, err = imgStore.GetReferrers("invalid", "invalid", "invalid")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
_, err = imgStore.GetReferrers(repoName, "invalid", "invalid")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
_, err = imgStore.GetReferrers(repoName, digest.String(), "invalid")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
// invalid DeleteImageManifest
|
|
indexPath := path.Join(imgStore.RootDir(), repoName, "index.json")
|
|
err = os.Chmod(indexPath, 0o000)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
err = imgStore.DeleteImageManifest(repoName, digest.String())
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.RemoveAll(path.Join(imgStore.RootDir(), repoName))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestGetReferrers(t *testing.T) {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, log, metrics, nil)
|
|
|
|
Convey("Get referrers", t, func(c C) {
|
|
err := test.CopyFiles("../../test/data/zot-test", path.Join(dir, "zot-test"))
|
|
So(err, ShouldBeNil)
|
|
body := []byte("this is a blob")
|
|
digest := godigest.FromBytes(body)
|
|
buf := bytes.NewBuffer(body)
|
|
buflen := buf.Len()
|
|
err = ioutil.WriteFile(path.Join(imgStore.RootDir(), //nolint: gosec
|
|
"zot-test", "blobs", digest.Algorithm().String(), digest.Encoded()),
|
|
buf.Bytes(), 0o644)
|
|
So(err, ShouldBeNil)
|
|
_, n, err := imgStore.FullBlobUpload("zot-test", buf, digest.String())
|
|
So(err, ShouldBeNil)
|
|
So(n, ShouldEqual, buflen)
|
|
|
|
artifactManifest := artifactspec.Manifest{}
|
|
artifactManifest.ArtifactType = "signature-example"
|
|
artifactManifest.Subject = artifactspec.Descriptor{
|
|
MediaType: ispec.MediaTypeImageManifest,
|
|
Digest: digest,
|
|
Size: int64(buflen),
|
|
}
|
|
artifactManifest.Blobs = []artifactspec.Descriptor{}
|
|
manBuf, err := json.Marshal(artifactManifest)
|
|
manBufLen := len(manBuf)
|
|
So(err, ShouldBeNil)
|
|
manDigest := godigest.FromBytes(manBuf)
|
|
_, err = imgStore.PutImageManifest("zot-test", manDigest.Encoded(), artifactspec.MediaTypeArtifactManifest, manBuf)
|
|
So(err, ShouldBeNil)
|
|
|
|
So(err, ShouldBeNil)
|
|
descriptors, err := imgStore.GetReferrers("zot-test", digest.String(), "signature-example")
|
|
So(err, ShouldBeNil)
|
|
So(descriptors, ShouldNotBeEmpty)
|
|
So(descriptors[0].ArtifactType, ShouldEqual, "signature-example")
|
|
So(descriptors[0].MediaType, ShouldEqual, artifactspec.MediaTypeArtifactManifest)
|
|
So(descriptors[0].Size, ShouldEqual, manBufLen)
|
|
So(descriptors[0].Digest, ShouldEqual, manDigest)
|
|
})
|
|
}
|
|
|
|
func FuzzNewBlobUpload(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
t.Logf("Input argument is %s", data)
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, log, metrics, nil)
|
|
|
|
_, err := imgStore.NewBlobUpload(data)
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzPutBlobChunk(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
t.Logf("Input argument is %s", data)
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, log, metrics, nil)
|
|
|
|
repoName := data
|
|
uuid, err := imgStore.NewBlobUpload(repoName)
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
|
|
t.Error(err)
|
|
}
|
|
|
|
buf := bytes.NewBuffer([]byte(data))
|
|
buflen := buf.Len()
|
|
_, err = imgStore.PutBlobChunk(repoName, uuid, 0, int64(buflen), buf)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzPutBlobChunkStreamed(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
t.Logf("Input argument is %s", data)
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, log, metrics, nil)
|
|
|
|
repoName := data
|
|
|
|
uuid, err := imgStore.NewBlobUpload(repoName)
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
|
|
t.Error(err)
|
|
}
|
|
|
|
buf := bytes.NewBuffer([]byte(data))
|
|
_, err = imgStore.PutBlobChunkStreamed(repoName, uuid, buf)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzGetBlobUpload(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data1 string, data2 string) {
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, log, metrics, nil)
|
|
|
|
_, err := imgStore.GetBlobUpload(data1, data2)
|
|
if err != nil {
|
|
if errors.Is(err, zerr.ErrUploadNotFound) || isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzTestPutGetImageManifest(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data []byte) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
|
|
cblob, cdigest := test.GetRandomImageConfig()
|
|
|
|
ldigest, lblob, err := newRandomBlobForFuzz(data)
|
|
if err != nil {
|
|
t.Errorf("error occurred while generating random blob, %v", err)
|
|
}
|
|
|
|
_, _, err = imgStore.FullBlobUpload(repoName, bytes.NewReader(cblob), cdigest.String())
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
_, _, err = imgStore.FullBlobUpload(repoName, bytes.NewReader(lblob), ldigest.String())
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
manifest, err := NewRandomImgManifest(data, cdigest, ldigest, cblob, lblob)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
manifestBuf, err := json.Marshal(manifest)
|
|
if err != nil {
|
|
t.Errorf("Error %v occurred while marshaling manifest", err)
|
|
}
|
|
mdigest := godigest.FromBytes(manifestBuf)
|
|
_, err = imgStore.PutImageManifest(repoName, mdigest.String(), ispec.MediaTypeImageManifest, manifestBuf)
|
|
if err != nil && errors.Is(err, zerr.ErrBadManifest) {
|
|
t.Errorf("the error that occurred is %v \n", err)
|
|
}
|
|
_, _, _, err = imgStore.GetImageManifest(repoName, mdigest.String())
|
|
if err != nil {
|
|
t.Errorf("the error that occurred is %v \n", err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzTestPutDeleteImageManifest(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data []byte) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
|
|
cblob, cdigest := test.GetRandomImageConfig()
|
|
|
|
ldigest, lblob, err := newRandomBlobForFuzz(data)
|
|
if err != nil {
|
|
t.Errorf("error occurred while generating random blob, %v", err)
|
|
}
|
|
|
|
_, _, err = imgStore.FullBlobUpload(repoName, bytes.NewReader(cblob), cdigest.String())
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
_, _, err = imgStore.FullBlobUpload(repoName, bytes.NewReader(lblob), ldigest.String())
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
manifest, err := NewRandomImgManifest(data, cdigest, ldigest, cblob, lblob)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
manifestBuf, err := json.Marshal(manifest)
|
|
if err != nil {
|
|
t.Errorf("Error %v occurred while marshaling manifest", err)
|
|
}
|
|
mdigest := godigest.FromBytes(manifestBuf)
|
|
_, err = imgStore.PutImageManifest(repoName, mdigest.String(), ispec.MediaTypeImageManifest, manifestBuf)
|
|
if err != nil && errors.Is(err, zerr.ErrBadManifest) {
|
|
t.Errorf("the error that occurred is %v \n", err)
|
|
}
|
|
|
|
err = imgStore.DeleteImageManifest(repoName, mdigest.String())
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Errorf("the error that occurred is %v \n", err)
|
|
}
|
|
})
|
|
}
|
|
|
|
// no integration with PutImageManifest, just throw fuzz data.
|
|
func FuzzTestDeleteImageManifest(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data []byte) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
|
|
digest, _, err := newRandomBlobForFuzz(data)
|
|
if err != nil {
|
|
return
|
|
}
|
|
err = imgStore.DeleteImageManifest(string(data), digest.String())
|
|
if err != nil {
|
|
if errors.Is(err, zerr.ErrRepoNotFound) || isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzDirExists(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) { //nolint: unusedparams
|
|
_ = storage.DirExists(data)
|
|
})
|
|
}
|
|
|
|
func FuzzInitRepo(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
err := imgStore.InitRepo(data)
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzInitValidateRepo(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
err := imgStore.InitRepo(data)
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
_, err = imgStore.ValidateRepo(data)
|
|
if err != nil {
|
|
if errors.Is(err, zerr.ErrRepoNotFound) || errors.Is(err, zerr.ErrRepoBadVersion) || isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzGetImageTags(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
_, err := imgStore.GetImageTags(data)
|
|
if err != nil {
|
|
if errors.Is(err, zerr.ErrRepoNotFound) || isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzBlobUploadPath(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, repo, uuid string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
|
|
_ = imgStore.BlobUploadPath(repo, uuid)
|
|
})
|
|
}
|
|
|
|
func FuzzBlobUploadInfo(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string, uuid string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
repo := data
|
|
|
|
_, err := imgStore.BlobUploadInfo(repo, uuid)
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzTestGetImageManifest(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, log, metrics, nil)
|
|
|
|
repoName := data
|
|
|
|
digest := godigest.FromBytes([]byte(data))
|
|
|
|
_, _, _, err := imgStore.GetImageManifest(repoName, digest.String())
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzFinishBlobUpload(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, log, metrics, nil)
|
|
|
|
repoName := data
|
|
|
|
upload, err := imgStore.NewBlobUpload(repoName)
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
|
|
content := []byte(data)
|
|
buf := bytes.NewBuffer(content)
|
|
buflen := buf.Len()
|
|
digest := godigest.FromBytes(content)
|
|
|
|
_, err = imgStore.PutBlobChunk(repoName, upload, 0, int64(buflen), buf)
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
|
|
err = imgStore.FinishBlobUpload(repoName, upload, buf, digest.String())
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzFullBlobUpload(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data []byte) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
repoName := "test"
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
|
|
ldigest, lblob, err := newRandomBlobForFuzz(data)
|
|
if err != nil {
|
|
t.Errorf("error occurred while generating random blob, %v", err)
|
|
}
|
|
|
|
_, _, err = imgStore.FullBlobUpload(repoName, bytes.NewReader(lblob), ldigest.String())
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzDedupeBlob(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
|
|
blobDigest := godigest.FromString(data)
|
|
|
|
// replacement for .uploads folder, usually retrieved from BlobUploadPath
|
|
src := path.Join(imgStore.RootDir(), "src")
|
|
blob := bytes.NewReader([]byte(data))
|
|
|
|
_, _, err := imgStore.FullBlobUpload("repoName", blob, blobDigest.String())
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
dst := imgStore.BlobPath("repoName", blobDigest)
|
|
|
|
err = os.MkdirAll(src, 0o755)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
err = imgStore.DedupeBlob(src, blobDigest, dst)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzDeleteBlobUpload(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
repoName := data
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
|
|
uuid, err := imgStore.NewBlobUpload(repoName)
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
|
|
err = imgStore.DeleteBlobUpload(repoName, uuid)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzBlobPath(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
repoName := data
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
digest := godigest.FromString(data)
|
|
|
|
_ = imgStore.BlobPath(repoName, digest)
|
|
})
|
|
}
|
|
|
|
func FuzzCheckBlob(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
repoName := data
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
digest := godigest.FromString(data)
|
|
|
|
_, _, err := imgStore.FullBlobUpload(repoName, bytes.NewReader([]byte(data)), digest.String())
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
_, _, err = imgStore.CheckBlob(repoName, digest.String())
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzGetBlob(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
repoName := data
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
digest := godigest.FromString(data)
|
|
|
|
_, _, err := imgStore.FullBlobUpload(repoName, bytes.NewReader([]byte(data)), digest.String())
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
|
|
_, _, err = imgStore.GetBlob(repoName, digest.String(), "application/vnd.oci.image.layer.v1.tar+gzip")
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzDeleteBlob(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
repoName := data
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
digest := godigest.FromString(data)
|
|
|
|
_, _, err := imgStore.FullBlobUpload(repoName, bytes.NewReader([]byte(data)), digest.String())
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
|
|
err = imgStore.DeleteBlob(repoName, digest.String())
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzGetIndexContent(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
repoName := data
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
digest := godigest.FromString(data)
|
|
|
|
_, _, err := imgStore.FullBlobUpload(repoName, bytes.NewReader([]byte(data)), digest.String())
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
|
|
_, err = imgStore.GetIndexContent(repoName)
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzGetBlobContent(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
repoName := data
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
digest := godigest.FromString(data)
|
|
|
|
_, _, err := imgStore.FullBlobUpload(repoName, bytes.NewReader([]byte(data)), digest.String())
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
|
|
_, err = imgStore.GetBlobContent(repoName, digest.String())
|
|
if err != nil {
|
|
if isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzGetReferrers(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
|
|
err := test.CopyFiles("../../test/data/zot-test", path.Join(dir, "zot-test"))
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
digest := godigest.FromBytes([]byte(data))
|
|
buf := bytes.NewBuffer([]byte(data))
|
|
buflen := buf.Len()
|
|
err = ioutil.WriteFile(path.Join(imgStore.RootDir(), //nolint: gosec
|
|
"zot-test", "blobs", digest.Algorithm().String(), digest.Encoded()),
|
|
buf.Bytes(), 0o644)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
_, _, err = imgStore.FullBlobUpload("zot-test", buf, digest.String())
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
artifactManifest := artifactspec.Manifest{}
|
|
artifactManifest.ArtifactType = data
|
|
artifactManifest.Subject = artifactspec.Descriptor{
|
|
MediaType: ispec.MediaTypeImageManifest,
|
|
Digest: digest,
|
|
Size: int64(buflen),
|
|
}
|
|
artifactManifest.Blobs = []artifactspec.Descriptor{}
|
|
|
|
manBuf, err := json.Marshal(artifactManifest)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
manDigest := godigest.FromBytes(manBuf)
|
|
_, err = imgStore.PutImageManifest("zot-test", manDigest.Encoded(), artifactspec.MediaTypeArtifactManifest, manBuf)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
_, err = imgStore.GetReferrers("zot-test", digest.String(), data)
|
|
if err != nil {
|
|
if errors.Is(err, zerr.ErrManifestNotFound) || isKnownErr(err) {
|
|
return
|
|
}
|
|
t.Error(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func FuzzRunGCRepo(f *testing.F) {
|
|
f.Fuzz(func(t *testing.T, data string) {
|
|
log := &log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, *log)
|
|
dir := t.TempDir()
|
|
defer os.RemoveAll(dir)
|
|
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, *log, metrics, nil)
|
|
|
|
imgStore.RunGCRepo(data)
|
|
})
|
|
}
|
|
|
|
func TestDedupeLinks(t *testing.T) {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay,
|
|
true, true, log, metrics, nil)
|
|
|
|
Convey("Dedupe", t, func(c C) {
|
|
// manifest1
|
|
upload, err := imgStore.NewBlobUpload("dedupe1")
|
|
So(err, ShouldBeNil)
|
|
So(upload, ShouldNotBeEmpty)
|
|
|
|
content := []byte("test-data3")
|
|
buf := bytes.NewBuffer(content)
|
|
buflen := buf.Len()
|
|
digest := godigest.FromBytes(content)
|
|
blob, err := imgStore.PutBlobChunkStreamed("dedupe1", upload, buf)
|
|
So(err, ShouldBeNil)
|
|
So(blob, ShouldEqual, buflen)
|
|
blobDigest1 := strings.Split(digest.String(), ":")[1]
|
|
So(blobDigest1, ShouldNotBeEmpty)
|
|
|
|
err = imgStore.FinishBlobUpload("dedupe1", upload, buf, digest.String())
|
|
So(err, ShouldBeNil)
|
|
So(blob, ShouldEqual, buflen)
|
|
|
|
_, _, err = imgStore.CheckBlob("dedupe1", digest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
_, _, err = imgStore.GetBlob("dedupe1", digest.String(), "application/vnd.oci.image.layer.v1.tar+gzip")
|
|
So(err, ShouldBeNil)
|
|
|
|
cblob, cdigest := test.GetRandomImageConfig()
|
|
_, clen, err := imgStore.FullBlobUpload("dedupe1", bytes.NewReader(cblob), cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(clen, ShouldEqual, len(cblob))
|
|
hasBlob, _, err := imgStore.CheckBlob("dedupe1", cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
manifest := ispec.Manifest{
|
|
Config: ispec.Descriptor{
|
|
MediaType: "application/vnd.oci.image.config.v1+json",
|
|
Digest: cdigest,
|
|
Size: int64(len(cblob)),
|
|
},
|
|
Layers: []ispec.Descriptor{
|
|
{
|
|
MediaType: "application/vnd.oci.image.layer.v1.tar",
|
|
Digest: digest,
|
|
Size: int64(buflen),
|
|
},
|
|
},
|
|
}
|
|
manifest.SchemaVersion = 2
|
|
manifestBuf, err := json.Marshal(manifest)
|
|
So(err, ShouldBeNil)
|
|
digest = godigest.FromBytes(manifestBuf)
|
|
_, err = imgStore.PutImageManifest("dedupe1", digest.String(),
|
|
ispec.MediaTypeImageManifest, manifestBuf)
|
|
So(err, ShouldBeNil)
|
|
|
|
_, _, _, err = imgStore.GetImageManifest("dedupe1", digest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
// manifest2
|
|
upload, err = imgStore.NewBlobUpload("dedupe2")
|
|
So(err, ShouldBeNil)
|
|
So(upload, ShouldNotBeEmpty)
|
|
|
|
content = []byte("test-data3")
|
|
buf = bytes.NewBuffer(content)
|
|
buflen = buf.Len()
|
|
digest = godigest.FromBytes(content)
|
|
blob, err = imgStore.PutBlobChunkStreamed("dedupe2", upload, buf)
|
|
So(err, ShouldBeNil)
|
|
So(blob, ShouldEqual, buflen)
|
|
blobDigest2 := strings.Split(digest.String(), ":")[1]
|
|
So(blobDigest2, ShouldNotBeEmpty)
|
|
|
|
err = imgStore.FinishBlobUpload("dedupe2", upload, buf, digest.String())
|
|
So(err, ShouldBeNil)
|
|
So(blob, ShouldEqual, buflen)
|
|
|
|
_, _, err = imgStore.CheckBlob("dedupe2", digest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
_, _, err = imgStore.GetBlob("dedupe2", digest.String(), "application/vnd.oci.image.layer.v1.tar+gzip")
|
|
So(err, ShouldBeNil)
|
|
|
|
cblob, cdigest = test.GetRandomImageConfig()
|
|
_, clen, err = imgStore.FullBlobUpload("dedupe2", bytes.NewReader(cblob), cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(clen, ShouldEqual, len(cblob))
|
|
hasBlob, _, err = imgStore.CheckBlob("dedupe2", cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
manifest = ispec.Manifest{
|
|
Config: ispec.Descriptor{
|
|
MediaType: "application/vnd.oci.image.config.v1+json",
|
|
Digest: cdigest,
|
|
Size: int64(len(cblob)),
|
|
},
|
|
Layers: []ispec.Descriptor{
|
|
{
|
|
MediaType: "application/vnd.oci.image.layer.v1.tar",
|
|
Digest: digest,
|
|
Size: int64(buflen),
|
|
},
|
|
},
|
|
}
|
|
manifest.SchemaVersion = 2
|
|
manifestBuf, err = json.Marshal(manifest)
|
|
So(err, ShouldBeNil)
|
|
digest = godigest.FromBytes(manifestBuf)
|
|
_, err = imgStore.PutImageManifest("dedupe2", "1.0", ispec.MediaTypeImageManifest, manifestBuf)
|
|
So(err, ShouldBeNil)
|
|
|
|
_, _, _, err = imgStore.GetImageManifest("dedupe2", digest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
// verify that dedupe with hard links happened
|
|
fi1, err := os.Stat(path.Join(dir, "dedupe2", "blobs", "sha256", blobDigest1))
|
|
So(err, ShouldBeNil)
|
|
fi2, err := os.Stat(path.Join(dir, "dedupe2", "blobs", "sha256", blobDigest2))
|
|
So(err, ShouldBeNil)
|
|
So(os.SameFile(fi1, fi2), ShouldBeTrue)
|
|
})
|
|
}
|
|
|
|
func TestDedupe(t *testing.T) {
|
|
Convey("Dedupe", t, func(c C) {
|
|
Convey("Nil ImageStore", func() {
|
|
var is storage.ImageStore
|
|
So(func() { _ = is.DedupeBlob("", "", "") }, ShouldPanic)
|
|
})
|
|
|
|
Convey("Valid ImageStore", func() {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
il := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true, true, log, metrics, nil)
|
|
|
|
So(il.DedupeBlob("", "", ""), ShouldNotBeNil)
|
|
})
|
|
})
|
|
}
|
|
|
|
// nolint: gocyclo
|
|
func TestNegativeCases(t *testing.T) {
|
|
Convey("Invalid root dir", t, func(c C) {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
|
|
So(storage.NewImageStore(dir, true, storage.DefaultGCDelay, true,
|
|
true, log, metrics, nil), ShouldNotBeNil)
|
|
if os.Geteuid() != 0 {
|
|
So(storage.NewImageStore("/deadBEEF", true, storage.DefaultGCDelay,
|
|
true, true, log, metrics, nil), ShouldBeNil)
|
|
}
|
|
})
|
|
|
|
Convey("Invalid init repo", t, func(c C) {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay,
|
|
true, true, log, metrics, nil)
|
|
|
|
err := os.Chmod(dir, 0o000) // remove all perms
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
if os.Geteuid() != 0 {
|
|
err = imgStore.InitRepo("test")
|
|
So(err, ShouldNotBeNil)
|
|
}
|
|
|
|
err = os.Chmod(dir, 0o755)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
// Init repo should fail if repo is a file.
|
|
err = ioutil.WriteFile(path.Join(dir, "file-test"), []byte("this is test file"), 0o755) // nolint:gosec
|
|
So(err, ShouldBeNil)
|
|
err = imgStore.InitRepo("file-test")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.Mkdir(path.Join(dir, "test-dir"), 0o755)
|
|
So(err, ShouldBeNil)
|
|
|
|
err = imgStore.InitRepo("test-dir")
|
|
So(err, ShouldBeNil)
|
|
|
|
// Init repo should fail if repo is invalid UTF-8
|
|
err = imgStore.InitRepo("hi \255")
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("Invalid validate repo", t, func(c C) {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true,
|
|
true, log, metrics, nil)
|
|
|
|
So(imgStore, ShouldNotBeNil)
|
|
So(imgStore.InitRepo("test"), ShouldBeNil)
|
|
|
|
err := os.MkdirAll(path.Join(dir, "invalid-test"), 0o755)
|
|
So(err, ShouldBeNil)
|
|
|
|
err = os.Chmod(path.Join(dir, "invalid-test"), 0o000) // remove all perms
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
_, err = imgStore.ValidateRepo("invalid-test")
|
|
So(err, ShouldNotBeNil)
|
|
So(err, ShouldEqual, zerr.ErrRepoNotFound)
|
|
|
|
err = os.Chmod(path.Join(dir, "invalid-test"), 0o755) // remove all perms
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
err = ioutil.WriteFile(path.Join(dir, "invalid-test", "blobs"), []byte{}, 0o755) // nolint: gosec
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
err = ioutil.WriteFile(path.Join(dir, "invalid-test", "index.json"), []byte{}, 0o755) // nolint: gosec
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
err = ioutil.WriteFile(path.Join(dir, "invalid-test", ispec.ImageLayoutFile), []byte{}, 0o755) // nolint: gosec
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
isValid, err := imgStore.ValidateRepo("invalid-test")
|
|
So(err, ShouldBeNil)
|
|
So(isValid, ShouldEqual, false)
|
|
|
|
err = os.Remove(path.Join(dir, "invalid-test", "blobs"))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
err = os.Mkdir(path.Join(dir, "invalid-test", "blobs"), 0o755)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
isValid, err = imgStore.ValidateRepo("invalid-test")
|
|
So(err, ShouldNotBeNil)
|
|
So(isValid, ShouldEqual, false)
|
|
|
|
err = ioutil.WriteFile(path.Join(dir, "invalid-test", ispec.ImageLayoutFile), []byte("{}"), 0o755) // nolint: gosec
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
isValid, err = imgStore.ValidateRepo("invalid-test")
|
|
So(err, ShouldNotBeNil)
|
|
So(err, ShouldEqual, zerr.ErrRepoBadVersion)
|
|
So(isValid, ShouldEqual, false)
|
|
|
|
files, err := ioutil.ReadDir(path.Join(dir, "test"))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
for _, f := range files {
|
|
os.Remove(path.Join(dir, "test", f.Name()))
|
|
}
|
|
|
|
_, err = imgStore.ValidateRepo("test")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.RemoveAll(path.Join(dir, "test"))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
_, err = imgStore.ValidateRepo("test")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.Chmod(dir, 0o000) // remove all perms
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
if os.Geteuid() != 0 {
|
|
So(func() { _, _ = imgStore.ValidateRepo("test") }, ShouldPanic)
|
|
}
|
|
|
|
err = os.Chmod(dir, 0o755) // remove all perms
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
err = os.RemoveAll(dir)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
_, err = imgStore.GetRepositories()
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("Invalid get image tags", t, func(c C) {
|
|
var ilfs storage.ImageStoreLocal
|
|
_, err := ilfs.GetImageTags("test")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay,
|
|
true, true, log, metrics, nil)
|
|
|
|
So(imgStore, ShouldNotBeNil)
|
|
So(imgStore.InitRepo("test"), ShouldBeNil)
|
|
So(os.Remove(path.Join(dir, "test", "index.json")), ShouldBeNil)
|
|
_, err = imgStore.GetImageTags("test")
|
|
So(err, ShouldNotBeNil)
|
|
So(os.RemoveAll(path.Join(dir, "test")), ShouldBeNil)
|
|
So(imgStore.InitRepo("test"), ShouldBeNil)
|
|
So(ioutil.WriteFile(path.Join(dir, "test", "index.json"), []byte{}, 0o600), ShouldBeNil)
|
|
_, err = imgStore.GetImageTags("test")
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("Invalid get image manifest", t, func(c C) {
|
|
var ilfs storage.ImageStoreLocal
|
|
_, _, _, err := ilfs.GetImageManifest("test", "")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay, true,
|
|
true, log, metrics, nil)
|
|
|
|
So(imgStore, ShouldNotBeNil)
|
|
So(imgStore.InitRepo("test"), ShouldBeNil)
|
|
|
|
err = os.Chmod(path.Join(dir, "test", "index.json"), 0o000)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
_, _, _, err = imgStore.GetImageManifest("test", "")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.Remove(path.Join(dir, "test", "index.json"))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
_, _, _, err = imgStore.GetImageManifest("test", "")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.RemoveAll(path.Join(dir, "test"))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
So(imgStore.InitRepo("test"), ShouldBeNil)
|
|
|
|
err = ioutil.WriteFile(path.Join(dir, "test", "index.json"), []byte{}, 0o600)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
_, _, _, err = imgStore.GetImageManifest("test", "")
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("Invalid new blob upload", t, func(c C) {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay,
|
|
true, true, log, metrics, nil)
|
|
|
|
So(imgStore, ShouldNotBeNil)
|
|
So(imgStore.InitRepo("test"), ShouldBeNil)
|
|
|
|
err := os.Chmod(path.Join(dir, "test", ".uploads"), 0o000)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
_, err = imgStore.NewBlobUpload("test")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.Chmod(path.Join(dir, "test"), 0o000)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
_, err = imgStore.NewBlobUpload("test")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.Chmod(path.Join(dir, "test"), 0o755)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
So(imgStore.InitRepo("test"), ShouldBeNil)
|
|
|
|
_, err = imgStore.NewBlobUpload("test")
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.Chmod(path.Join(dir, "test", ".uploads"), 0o755)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
upload, err := imgStore.NewBlobUpload("test")
|
|
So(err, ShouldBeNil)
|
|
|
|
err = os.Chmod(path.Join(dir, "test", ".uploads"), 0o000)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
t.Cleanup(func() {
|
|
err = os.Chmod(path.Join(dir, "test", ".uploads"), 0o700)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
})
|
|
|
|
content := []byte("test-data3")
|
|
buf := bytes.NewBuffer(content)
|
|
l := buf.Len()
|
|
_, err = imgStore.PutBlobChunkStreamed("test", upload, buf)
|
|
So(err, ShouldNotBeNil)
|
|
|
|
_, err = imgStore.PutBlobChunk("test", upload, 0, int64(l), buf)
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("DirExists call with a filename as argument", t, func(c C) {
|
|
dir := t.TempDir()
|
|
|
|
filePath := path.Join(dir, "file.txt")
|
|
err := ioutil.WriteFile(filePath, []byte("some dummy file content"), 0o644) //nolint: gosec
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
ok := storage.DirExists(filePath)
|
|
So(ok, ShouldBeFalse)
|
|
})
|
|
|
|
Convey("DirExists call with invalid UTF-8 as argument", t, func(c C) {
|
|
dir := t.TempDir()
|
|
|
|
filePath := path.Join(dir, "hi \255")
|
|
ok := storage.DirExists(filePath)
|
|
So(ok, ShouldBeFalse)
|
|
})
|
|
|
|
Convey("DirExists call with name too long as argument", t, func(c C) {
|
|
var builder strings.Builder
|
|
for i := 0; i < 1025; i++ {
|
|
_, err := builder.WriteString("0")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
path := builder.String()
|
|
ok := storage.DirExists(path)
|
|
So(ok, ShouldBeFalse)
|
|
})
|
|
}
|
|
|
|
func TestHardLink(t *testing.T) {
|
|
Convey("Test that ValidateHardLink creates rootDir if it does not exist", t, func() {
|
|
var randomDir string
|
|
|
|
for {
|
|
nBig, err := rand.Int(rand.Reader, big.NewInt(100))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
randomDir = "/tmp/" + randSeq(int(nBig.Int64()))
|
|
|
|
if _, err := os.Stat(randomDir); os.IsNotExist(err) {
|
|
break
|
|
}
|
|
}
|
|
defer os.RemoveAll(randomDir)
|
|
|
|
err := storage.ValidateHardLink(randomDir)
|
|
So(err, ShouldBeNil)
|
|
})
|
|
Convey("Test that ValidateHardLink returns error if rootDir is a file", t, func() {
|
|
dir := t.TempDir()
|
|
|
|
filePath := path.Join(dir, "file.txt")
|
|
err := ioutil.WriteFile(filePath, []byte("some dummy file content"), 0o644) //nolint: gosec
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
err = storage.ValidateHardLink(filePath)
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
Convey("Test if filesystem supports hardlink", t, func() {
|
|
dir := t.TempDir()
|
|
|
|
err := storage.ValidateHardLink(dir)
|
|
So(err, ShouldBeNil)
|
|
|
|
err = ioutil.WriteFile(path.Join(dir, "hardtest.txt"), []byte("testing hard link code"), 0o644) //nolint: gosec
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
err = os.Chmod(dir, 0o400)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
// Allow hardtest.txt to be cleaned up by t.TempDir()
|
|
t.Cleanup(func() {
|
|
err = os.Chmod(dir, 0o700)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
|
|
err = os.Link(path.Join(dir, "hardtest.txt"), path.Join(dir, "duphardtest.txt"))
|
|
So(err, ShouldNotBeNil)
|
|
|
|
err = os.Chmod(dir, 0o644)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestInjectWriteFile(t *testing.T) {
|
|
Convey("writeFile with commit", t, func() {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay,
|
|
true, true, log, metrics, nil)
|
|
|
|
Convey("Failure path1", func() {
|
|
injected := test.InjectFailure(0)
|
|
|
|
err := imgStore.InitRepo("repo1")
|
|
if injected {
|
|
So(err, ShouldNotBeNil)
|
|
} else {
|
|
So(err, ShouldBeNil)
|
|
}
|
|
})
|
|
|
|
Convey("Failure path2", func() {
|
|
injected := test.InjectFailure(1)
|
|
|
|
err := imgStore.InitRepo("repo2")
|
|
if injected {
|
|
So(err, ShouldNotBeNil)
|
|
} else {
|
|
So(err, ShouldBeNil)
|
|
}
|
|
})
|
|
})
|
|
|
|
Convey("writeFile without commit", t, func() {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay,
|
|
true, false, log, metrics, nil)
|
|
|
|
Convey("Failure path not reached", func() {
|
|
err := imgStore.InitRepo("repo1")
|
|
So(err, ShouldBeNil)
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestGarbageCollect(t *testing.T) {
|
|
Convey("Repo layout", t, func(c C) {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
|
|
Convey("Garbage collect with default/long delay", func() {
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay,
|
|
true, true, log, metrics, nil)
|
|
repoName := "gc-long"
|
|
|
|
upload, err := imgStore.NewBlobUpload(repoName)
|
|
So(err, ShouldBeNil)
|
|
So(upload, ShouldNotBeEmpty)
|
|
|
|
content := []byte("test-data1")
|
|
buf := bytes.NewBuffer(content)
|
|
buflen := buf.Len()
|
|
bdigest := godigest.FromBytes(content)
|
|
|
|
blob, err := imgStore.PutBlobChunk(repoName, upload, 0, int64(buflen), buf)
|
|
So(err, ShouldBeNil)
|
|
So(blob, ShouldEqual, buflen)
|
|
|
|
err = imgStore.FinishBlobUpload(repoName, upload, buf, bdigest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
annotationsMap := make(map[string]string)
|
|
annotationsMap[ispec.AnnotationRefName] = tag
|
|
|
|
cblob, cdigest := test.GetRandomImageConfig()
|
|
_, clen, err := imgStore.FullBlobUpload(repoName, bytes.NewReader(cblob), cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(clen, ShouldEqual, len(cblob))
|
|
hasBlob, _, err := imgStore.CheckBlob(repoName, cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
manifest := ispec.Manifest{
|
|
Config: ispec.Descriptor{
|
|
MediaType: "application/vnd.oci.image.config.v1+json",
|
|
Digest: cdigest,
|
|
Size: int64(len(cblob)),
|
|
},
|
|
Layers: []ispec.Descriptor{
|
|
{
|
|
MediaType: "application/vnd.oci.image.layer.v1.tar",
|
|
Digest: bdigest,
|
|
Size: int64(buflen),
|
|
},
|
|
},
|
|
Annotations: annotationsMap,
|
|
}
|
|
|
|
manifest.SchemaVersion = 2
|
|
manifestBuf, err := json.Marshal(manifest)
|
|
So(err, ShouldBeNil)
|
|
digest := godigest.FromBytes(manifestBuf)
|
|
|
|
_, err = imgStore.PutImageManifest(repoName, tag, ispec.MediaTypeImageManifest, manifestBuf)
|
|
So(err, ShouldBeNil)
|
|
|
|
hasBlob, _, err = imgStore.CheckBlob(repoName, bdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
err = imgStore.DeleteImageManifest(repoName, digest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
hasBlob, _, err = imgStore.CheckBlob(repoName, bdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
})
|
|
|
|
Convey("Garbage collect with short delay", func() {
|
|
imgStore := storage.NewImageStore(dir, true, 1*time.Second, true, true, log, metrics, nil)
|
|
repoName := "gc-short"
|
|
|
|
// upload orphan blob
|
|
upload, err := imgStore.NewBlobUpload(repoName)
|
|
So(err, ShouldBeNil)
|
|
So(upload, ShouldNotBeEmpty)
|
|
|
|
content := []byte("test-data1")
|
|
buf := bytes.NewBuffer(content)
|
|
buflen := buf.Len()
|
|
odigest := godigest.FromBytes(content)
|
|
|
|
blob, err := imgStore.PutBlobChunk(repoName, upload, 0, int64(buflen), buf)
|
|
So(err, ShouldBeNil)
|
|
So(blob, ShouldEqual, buflen)
|
|
|
|
err = imgStore.FinishBlobUpload(repoName, upload, buf, odigest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
// sleep so orphan blob can be GC'ed
|
|
time.Sleep(5 * time.Second)
|
|
|
|
// upload blob
|
|
upload, err = imgStore.NewBlobUpload(repoName)
|
|
So(err, ShouldBeNil)
|
|
So(upload, ShouldNotBeEmpty)
|
|
|
|
content = []byte("test-data2")
|
|
buf = bytes.NewBuffer(content)
|
|
buflen = buf.Len()
|
|
bdigest := godigest.FromBytes(content)
|
|
|
|
blob, err = imgStore.PutBlobChunk(repoName, upload, 0, int64(buflen), buf)
|
|
So(err, ShouldBeNil)
|
|
So(blob, ShouldEqual, buflen)
|
|
|
|
err = imgStore.FinishBlobUpload(repoName, upload, buf, bdigest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
annotationsMap := make(map[string]string)
|
|
annotationsMap[ispec.AnnotationRefName] = tag
|
|
|
|
cblob, cdigest := test.GetRandomImageConfig()
|
|
_, clen, err := imgStore.FullBlobUpload(repoName, bytes.NewReader(cblob), cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(clen, ShouldEqual, len(cblob))
|
|
hasBlob, _, err := imgStore.CheckBlob(repoName, cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
manifest := ispec.Manifest{
|
|
Config: ispec.Descriptor{
|
|
MediaType: "application/vnd.oci.image.config.v1+json",
|
|
Digest: cdigest,
|
|
Size: int64(len(cblob)),
|
|
},
|
|
Layers: []ispec.Descriptor{
|
|
{
|
|
MediaType: "application/vnd.oci.image.layer.v1.tar",
|
|
Digest: bdigest,
|
|
Size: int64(buflen),
|
|
},
|
|
},
|
|
Annotations: annotationsMap,
|
|
}
|
|
|
|
manifest.SchemaVersion = 2
|
|
manifestBuf, err := json.Marshal(manifest)
|
|
So(err, ShouldBeNil)
|
|
digest := godigest.FromBytes(manifestBuf)
|
|
|
|
_, err = imgStore.PutImageManifest(repoName, tag, ispec.MediaTypeImageManifest, manifestBuf)
|
|
So(err, ShouldBeNil)
|
|
|
|
hasBlob, _, err = imgStore.CheckBlob(repoName, odigest.String())
|
|
So(err, ShouldNotBeNil)
|
|
So(hasBlob, ShouldEqual, false)
|
|
|
|
hasBlob, _, err = imgStore.CheckBlob(repoName, bdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
// sleep so orphan blob can be GC'ed
|
|
time.Sleep(5 * time.Second)
|
|
|
|
err = imgStore.DeleteImageManifest(repoName, digest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
hasBlob, _, err = imgStore.CheckBlob(repoName, bdigest.String())
|
|
So(err, ShouldNotBeNil)
|
|
So(hasBlob, ShouldEqual, false)
|
|
})
|
|
|
|
Convey("Garbage collect with dedupe", func() {
|
|
// garbage-collect is repo-local and dedupe is global and they can interact in strange ways
|
|
imgStore := storage.NewImageStore(dir, true, 5*time.Second, true, true, log, metrics, nil)
|
|
|
|
// first upload an image to the first repo and wait for GC timeout
|
|
|
|
repo1Name := "gc1"
|
|
|
|
// upload blob
|
|
upload, err := imgStore.NewBlobUpload(repo1Name)
|
|
So(err, ShouldBeNil)
|
|
So(upload, ShouldNotBeEmpty)
|
|
|
|
content := []byte("test-data")
|
|
buf := bytes.NewBuffer(content)
|
|
buflen := buf.Len()
|
|
bdigest := godigest.FromBytes(content)
|
|
tdigest := bdigest
|
|
|
|
blob, err := imgStore.PutBlobChunk(repo1Name, upload, 0, int64(buflen), buf)
|
|
So(err, ShouldBeNil)
|
|
So(blob, ShouldEqual, buflen)
|
|
|
|
err = imgStore.FinishBlobUpload(repo1Name, upload, buf, bdigest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
annotationsMap := make(map[string]string)
|
|
annotationsMap[ispec.AnnotationRefName] = tag
|
|
|
|
cblob, cdigest := test.GetRandomImageConfig()
|
|
_, clen, err := imgStore.FullBlobUpload(repo1Name, bytes.NewReader(cblob), cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(clen, ShouldEqual, len(cblob))
|
|
hasBlob, _, err := imgStore.CheckBlob(repo1Name, cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
manifest := ispec.Manifest{
|
|
Config: ispec.Descriptor{
|
|
MediaType: "application/vnd.oci.image.config.v1+json",
|
|
Digest: cdigest,
|
|
Size: int64(len(cblob)),
|
|
},
|
|
Layers: []ispec.Descriptor{
|
|
{
|
|
MediaType: "application/vnd.oci.image.layer.v1.tar",
|
|
Digest: bdigest,
|
|
Size: int64(buflen),
|
|
},
|
|
},
|
|
Annotations: annotationsMap,
|
|
}
|
|
|
|
manifest.SchemaVersion = 2
|
|
manifestBuf, err := json.Marshal(manifest)
|
|
So(err, ShouldBeNil)
|
|
|
|
_, err = imgStore.PutImageManifest(repo1Name, tag, ispec.MediaTypeImageManifest, manifestBuf)
|
|
So(err, ShouldBeNil)
|
|
|
|
hasBlob, _, err = imgStore.CheckBlob(repo1Name, tdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
// sleep so past GC timeout
|
|
time.Sleep(10 * time.Second)
|
|
|
|
hasBlob, _, err = imgStore.CheckBlob(repo1Name, tdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
// upload another image into a second repo with the same blob contents so dedupe is triggered
|
|
|
|
repo2Name := "gc2"
|
|
|
|
upload, err = imgStore.NewBlobUpload(repo2Name)
|
|
So(err, ShouldBeNil)
|
|
So(upload, ShouldNotBeEmpty)
|
|
|
|
buf = bytes.NewBuffer(content)
|
|
buflen = buf.Len()
|
|
|
|
blob, err = imgStore.PutBlobChunk(repo2Name, upload, 0, int64(buflen), buf)
|
|
So(err, ShouldBeNil)
|
|
So(blob, ShouldEqual, buflen)
|
|
|
|
err = imgStore.FinishBlobUpload(repo2Name, upload, buf, bdigest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
annotationsMap = make(map[string]string)
|
|
annotationsMap[ispec.AnnotationRefName] = tag
|
|
|
|
cblob, cdigest = test.GetRandomImageConfig()
|
|
_, clen, err = imgStore.FullBlobUpload(repo2Name, bytes.NewReader(cblob), cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(clen, ShouldEqual, len(cblob))
|
|
hasBlob, _, err = imgStore.CheckBlob(repo2Name, cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
manifest = ispec.Manifest{
|
|
Config: ispec.Descriptor{
|
|
MediaType: "application/vnd.oci.image.config.v1+json",
|
|
Digest: cdigest,
|
|
Size: int64(len(cblob)),
|
|
},
|
|
Layers: []ispec.Descriptor{
|
|
{
|
|
MediaType: "application/vnd.oci.image.layer.v1.tar",
|
|
Digest: bdigest,
|
|
Size: int64(buflen),
|
|
},
|
|
},
|
|
Annotations: annotationsMap,
|
|
}
|
|
|
|
manifest.SchemaVersion = 2
|
|
manifestBuf, err = json.Marshal(manifest)
|
|
So(err, ShouldBeNil)
|
|
|
|
_, err = imgStore.PutImageManifest(repo2Name, tag, ispec.MediaTypeImageManifest, manifestBuf)
|
|
So(err, ShouldBeNil)
|
|
|
|
hasBlob, _, err = imgStore.CheckBlob(repo2Name, bdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
// immediately upload any other image to second repo which should invoke GC inline, but expect layers to persist
|
|
|
|
upload, err = imgStore.NewBlobUpload(repo2Name)
|
|
So(err, ShouldBeNil)
|
|
So(upload, ShouldNotBeEmpty)
|
|
|
|
content = []byte("test-data-more")
|
|
buf = bytes.NewBuffer(content)
|
|
buflen = buf.Len()
|
|
bdigest = godigest.FromBytes(content)
|
|
|
|
blob, err = imgStore.PutBlobChunk(repo2Name, upload, 0, int64(buflen), buf)
|
|
So(err, ShouldBeNil)
|
|
So(blob, ShouldEqual, buflen)
|
|
|
|
err = imgStore.FinishBlobUpload(repo2Name, upload, buf, bdigest.String())
|
|
So(err, ShouldBeNil)
|
|
|
|
annotationsMap = make(map[string]string)
|
|
annotationsMap[ispec.AnnotationRefName] = tag
|
|
|
|
cblob, cdigest = test.GetRandomImageConfig()
|
|
_, clen, err = imgStore.FullBlobUpload(repo2Name, bytes.NewReader(cblob), cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(clen, ShouldEqual, len(cblob))
|
|
hasBlob, _, err = imgStore.CheckBlob(repo2Name, cdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
manifest = ispec.Manifest{
|
|
Config: ispec.Descriptor{
|
|
MediaType: "application/vnd.oci.image.config.v1+json",
|
|
Digest: cdigest,
|
|
Size: int64(len(cblob)),
|
|
},
|
|
Layers: []ispec.Descriptor{
|
|
{
|
|
MediaType: "application/vnd.oci.image.layer.v1.tar",
|
|
Digest: bdigest,
|
|
Size: int64(buflen),
|
|
},
|
|
},
|
|
Annotations: annotationsMap,
|
|
}
|
|
|
|
manifest.SchemaVersion = 2
|
|
manifestBuf, err = json.Marshal(manifest)
|
|
So(err, ShouldBeNil)
|
|
digest := godigest.FromBytes(manifestBuf)
|
|
|
|
_, err = imgStore.PutImageManifest(repo2Name, tag, ispec.MediaTypeImageManifest, manifestBuf)
|
|
So(err, ShouldBeNil)
|
|
|
|
// original blob should exist
|
|
|
|
hasBlob, _, err = imgStore.CheckBlob(repo2Name, tdigest.String())
|
|
So(err, ShouldBeNil)
|
|
So(hasBlob, ShouldEqual, true)
|
|
|
|
_, _, _, err = imgStore.GetImageManifest(repo2Name, digest.String())
|
|
So(err, ShouldBeNil)
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestGarbageCollectForImageStore(t *testing.T) {
|
|
Convey("Garbage collect for a specific repo from an ImageStore", t, func(c C) {
|
|
dir := t.TempDir()
|
|
|
|
Convey("Garbage collect error for repo with config removed", func() {
|
|
logFile, _ := ioutil.TempFile("", "zot-log*.txt")
|
|
|
|
defer os.Remove(logFile.Name()) // clean up
|
|
|
|
log := log.NewLogger("debug", logFile.Name())
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, 1*time.Second, true, true, log, metrics, nil)
|
|
repoName := "gc-all-repos-short"
|
|
|
|
err := test.CopyFiles("../../test/data/zot-test", path.Join(dir, repoName))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
var manifestDigest godigest.Digest
|
|
manifestDigest, _, _ = test.GetOciLayoutDigests("../../test/data/zot-test")
|
|
err = os.Remove(path.Join(dir, repoName, "blobs/sha256", manifestDigest.Encoded()))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
imgStore.RunGCRepo(repoName)
|
|
|
|
time.Sleep(500 * time.Millisecond)
|
|
|
|
data, err := os.ReadFile(logFile.Name())
|
|
So(err, ShouldBeNil)
|
|
So(string(data), ShouldContainSubstring,
|
|
fmt.Sprintf("error while running GC for %s", path.Join(imgStore.RootDir(), repoName)))
|
|
})
|
|
|
|
Convey("Garbage collect error - not enough permissions to access index.json", func() {
|
|
logFile, _ := ioutil.TempFile("", "zot-log*.txt")
|
|
|
|
defer os.Remove(logFile.Name()) // clean up
|
|
|
|
log := log.NewLogger("debug", logFile.Name())
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, 1*time.Second, true, true, log, metrics, nil)
|
|
repoName := "gc-all-repos-short"
|
|
|
|
err := test.CopyFiles("../../test/data/zot-test", path.Join(dir, repoName))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
So(os.Chmod(path.Join(dir, repoName, "index.json"), 0o000), ShouldBeNil)
|
|
|
|
imgStore.RunGCRepo(repoName)
|
|
|
|
time.Sleep(500 * time.Millisecond)
|
|
|
|
data, err := os.ReadFile(logFile.Name())
|
|
So(err, ShouldBeNil)
|
|
So(string(data), ShouldContainSubstring,
|
|
fmt.Sprintf("error while running GC for %s", path.Join(imgStore.RootDir(), repoName)))
|
|
So(os.Chmod(path.Join(dir, repoName, "index.json"), 0o755), ShouldBeNil)
|
|
})
|
|
})
|
|
}
|
|
|
|
func randSeq(n int) string {
|
|
letters := []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")
|
|
|
|
buf := make([]rune, n)
|
|
for index := range buf {
|
|
nBig, err := rand.Int(rand.Reader, big.NewInt(int64(len(letters))))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
buf[index] = letters[int(nBig.Int64())]
|
|
}
|
|
|
|
return string(buf)
|
|
}
|
|
|
|
func TestInitRepo(t *testing.T) {
|
|
Convey("Get error when creating BlobUploadDir subdir on initRepo", t, func() {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay,
|
|
true, true, log, metrics, nil)
|
|
|
|
err := os.Mkdir(path.Join(dir, "test-dir"), 0o000)
|
|
So(err, ShouldBeNil)
|
|
|
|
err = imgStore.InitRepo("test-dir")
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
}
|
|
|
|
func TestValidateRepo(t *testing.T) {
|
|
Convey("Get error when unable to read directory", t, func() {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay,
|
|
true, true, log, metrics, nil)
|
|
|
|
err := os.Mkdir(path.Join(dir, "test-dir"), 0o000)
|
|
So(err, ShouldBeNil)
|
|
|
|
_, err = imgStore.ValidateRepo("test-dir")
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
}
|
|
|
|
func TestGetRepositoriesError(t *testing.T) {
|
|
Convey("Get error when returning relative path", t, func() {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay,
|
|
true, true, log, metrics, nil,
|
|
)
|
|
|
|
// create valid directory with permissions
|
|
err := os.Mkdir(path.Join(dir, "test-dir"), 0o755)
|
|
So(err, ShouldBeNil)
|
|
|
|
err = ioutil.WriteFile(path.Join(dir, "test-dir/test-file"), []byte("this is test file"), 0o000)
|
|
So(err, ShouldBeNil)
|
|
|
|
_, err = imgStore.GetRepositories()
|
|
So(err, ShouldBeNil)
|
|
})
|
|
}
|
|
|
|
func TestPutBlobChunkStreamed(t *testing.T) {
|
|
Convey("Get error on opening file", t, func() {
|
|
dir := t.TempDir()
|
|
|
|
log := log.Logger{Logger: zerolog.New(os.Stdout)}
|
|
metrics := monitoring.NewMetricsServer(false, log)
|
|
imgStore := storage.NewImageStore(dir, true, storage.DefaultGCDelay,
|
|
true, true, log, metrics, nil)
|
|
|
|
uuid, err := imgStore.NewBlobUpload("test")
|
|
So(err, ShouldBeNil)
|
|
|
|
var reader io.Reader
|
|
blobPath := imgStore.BlobUploadPath("test", uuid)
|
|
err = os.Chmod(blobPath, 0o000)
|
|
So(err, ShouldBeNil)
|
|
|
|
_, err = imgStore.PutBlobChunkStreamed("test", uuid, reader)
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
}
|
|
|
|
func NewRandomImgManifest(data []byte, cdigest, ldigest godigest.Digest, cblob, lblob []byte) (*ispec.Manifest, error) {
|
|
annotationsMap := make(map[string]string)
|
|
|
|
key := string(data)
|
|
val := string(data)
|
|
annotationsMap[key] = val
|
|
|
|
schemaVersion := 2
|
|
|
|
manifest := ispec.Manifest{
|
|
MediaType: "application/vnd.oci.image.manifest.v1+json",
|
|
Config: ispec.Descriptor{
|
|
MediaType: "application/vnd.oci.image.config.v1+json",
|
|
Digest: cdigest,
|
|
Size: int64(len(cblob)),
|
|
},
|
|
Layers: []ispec.Descriptor{
|
|
{
|
|
MediaType: "application/vnd.oci.image.layer.v1.tar",
|
|
Digest: ldigest,
|
|
Size: int64(len(lblob)),
|
|
},
|
|
},
|
|
Annotations: annotationsMap,
|
|
Versioned: imeta.Versioned{
|
|
SchemaVersion: schemaVersion,
|
|
},
|
|
}
|
|
|
|
return &manifest, nil
|
|
}
|
|
|
|
func newRandomBlobForFuzz(data []byte) (godigest.Digest, []byte, error) {
|
|
return godigest.FromBytes(data), data, nil
|
|
}
|
|
|
|
func isKnownErr(err error) bool {
|
|
if errors.Is(err, zerr.ErrInvalidRepositoryName) || errors.Is(err, zerr.ErrManifestNotFound) ||
|
|
errors.Is(err, zerr.ErrRepoNotFound) ||
|
|
errors.Is(err, zerr.ErrBadManifest) {
|
|
return true
|
|
}
|
|
|
|
if err, ok := err.(*fs.PathError); ok && errors.Is(err.Err, syscall.EACCES) || //nolint: errorlint
|
|
errors.Is(err.Err, syscall.ENAMETOOLONG) ||
|
|
errors.Is(err.Err, syscall.EINVAL) ||
|
|
errors.Is(err.Err, syscall.ENOENT) {
|
|
return true
|
|
}
|
|
|
|
return false
|
|
}
|