From 8746a49268debd62c60e4743d1b80ff39170c2a0 Mon Sep 17 00:00:00 2001
From: Ramkumar Chinchani <45800463+rchincha@users.noreply.github.com>
Date: Wed, 23 Nov 2022 00:19:15 -0800
Subject: [PATCH] fix: handle remote cache driver misconfig (#1011)

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
---
 pkg/api/controller.go      | 21 ++++++++++++++++++---
 pkg/api/controller_test.go | 21 +++++++++++++++++++++
 2 files changed, 39 insertions(+), 3 deletions(-)

diff --git a/pkg/api/controller.go b/pkg/api/controller.go
index d7c1c1c1..4db05b67 100644
--- a/pkg/api/controller.go
+++ b/pkg/api/controller.go
@@ -27,7 +27,7 @@ import (
 	"zotregistry.io/zot/pkg/scheduler"
 	"zotregistry.io/zot/pkg/storage"
 	"zotregistry.io/zot/pkg/storage/cache"
-	storageConstants "zotregistry.io/zot/pkg/storage/constants"
+	"zotregistry.io/zot/pkg/storage/constants"
 	"zotregistry.io/zot/pkg/storage/local"
 	"zotregistry.io/zot/pkg/storage/s3"
 )
@@ -437,15 +437,30 @@ func CreateCacheDatabaseDriver(storageConfig config.StorageConfig, log log.Logge
 		if !storageConfig.RemoteCache {
 			params := cache.BoltDBDriverParameters{}
 			params.RootDir = storageConfig.RootDirectory
-			params.Name = storageConstants.BoltdbName
+			params.Name = constants.BoltdbName
 			params.UseRelPaths = getUseRelPaths(&storageConfig)
 
 			driver, _ := storage.Create("boltdb", params, log)
 
 			return driver
 		}
-		// dynamodb
+
+		// remote cache
 		if storageConfig.CacheDriver != nil {
+			name, ok := storageConfig.CacheDriver["name"].(string)
+			if !ok {
+				log.Warn().Msg("remote cache driver name missing!")
+
+				return nil
+			}
+
+			if name != constants.DynamoDBDriverName {
+				log.Warn().Str("driver", name).Msg("remote cache driver unsupported!")
+
+				return nil
+			}
+
+			// dynamodb
 			dynamoParams := cache.DynamoDBDriverParameters{}
 			dynamoParams.Endpoint, _ = storageConfig.CacheDriver["endpoint"].(string)
 			dynamoParams.Region, _ = storageConfig.CacheDriver["region"].(string)
diff --git a/pkg/api/controller_test.go b/pkg/api/controller_test.go
index b9af61ba..397020b5 100644
--- a/pkg/api/controller_test.go
+++ b/pkg/api/controller_test.go
@@ -168,6 +168,27 @@ func TestCreateCacheDatabaseDriver(t *testing.T) {
 
 		driver := api.CreateCacheDatabaseDriver(conf.Storage.StorageConfig, log)
 		So(driver, ShouldNotBeNil)
+
+		// negative test cases
+
+		conf.Storage.CacheDriver = map[string]interface{}{
+			"endpoint":  "http://localhost:4566",
+			"region":    "us-east-2",
+			"tableName": "BlobTable",
+		}
+
+		driver = api.CreateCacheDatabaseDriver(conf.Storage.StorageConfig, log)
+		So(driver, ShouldBeNil)
+
+		conf.Storage.CacheDriver = map[string]interface{}{
+			"name":      "dummy",
+			"endpoint":  "http://localhost:4566",
+			"region":    "us-east-2",
+			"tableName": "BlobTable",
+		}
+
+		driver = api.CreateCacheDatabaseDriver(conf.Storage.StorageConfig, log)
+		So(driver, ShouldBeNil)
 	})
 }