Infrastructure/zot
0
Fork 0
mirror of https://github.com/project-zot/zot.git synced 2024-12-30 22:34:13 -05:00
Code Issues Activity

sync: skip tls verify on /v2/_catalog when a registry is configured with tls-verify false

Browse source 
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
This commit is contained in:
Petu Eusebiu 2021-11-18 13:54:32 +02:00 committed by Ramkumar Chinchani
parent 5f8f61407e
commit 7ada50e9c8
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/extensions/sync/sync.go
View file

@ -106,6 +106,11 @@ func getUpstreamCatalog(regCfg *RegistryConfig, credentials Credentials, log log
client.SetCertificates(cert)
}
// nolint: gosec
if regCfg.TLSVerify != nil && !*regCfg.TLSVerify {
client.SetTLSClientConfig(&tls.Config{InsecureSkipVerify: true})
}
if credentials.Username != "" && credentials.Password != "" {
log.Debug().Msgf("sync: using basic auth")
client.SetBasicAuth(credentials.Username, credentials.Password)

2
pkg/extensions/sync/sync_test.go
View file

@ -2105,7 +2105,7 @@ func TestSyncInvalidCerts(t *testing.T) {
Convey("Test sync on POST request on /sync", func() {
resp, _ := resty.R().Post(destBaseURL + "/sync")
So(resp, ShouldNotBeNil)
So(string(resp.Body()), ShouldContainSubstring, "signed by unknown authority")
So(string(resp.Body()), ShouldContainSubstring, "bad certificate")
So(resp.StatusCode(), ShouldEqual, 500)
})
})