From 65df973f7065812d1cc5a098d18729e3b0e9f942 Mon Sep 17 00:00:00 2001 From: Ramkumar Chinchani <45800463+rchincha@users.noreply.github.com> Date: Mon, 3 Oct 2022 23:56:07 -0700 Subject: [PATCH] fix(ci/cd): update the commit msg checker settings (#846) Update the checker to check for length limits and against all commits. Signed-off-by: Ramkumar Chinchani --- .github/workflows/commit-msg.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/commit-msg.yaml b/.github/workflows/commit-msg.yaml index b240aaca..ec0ef5c4 100644 --- a/.github/workflows/commit-msg.yaml +++ b/.github/workflows/commit-msg.yaml @@ -23,11 +23,16 @@ jobs: pattern: '^((build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)(\(.+\))?(!)?(: (.*\s*)*))' flags: 'gm' error: 'Your first line has to the Conventional Commits specification.' + excludeDescription: 'true' # optional: this excludes the description body of a pull request + excludeTitle: 'true' # optional: this excludes the title of a pull request + checkAllCommitMessages: 'true' + accessToken: ${{ secrets.GITHUB_TOKEN }} - name: Check Line Length uses: gsactions/commit-message-checker@v1 with: - pattern: '^[^#].{74}' + pattern: '^[^#].{1,74}' error: 'The maximum line length of 74 characters is exceeded.' excludeDescription: 'true' # optional: this excludes the description body of a pull request excludeTitle: 'true' # optional: this excludes the title of a pull request - checkAllCommitMessages: 'false' + checkAllCommitMessages: 'true' # optional: this checks all commits associated with a pull request + accessToken: ${{ secrets.GITHUB_TOKEN }} # github access token is only required if checkAllCommitMessages is true