2023-01-09 15:37:44 -05:00
|
|
|
package convert_test
|
|
|
|
|
|
|
|
import (
|
|
|
|
"context"
|
|
|
|
"encoding/json"
|
|
|
|
"errors"
|
|
|
|
"testing"
|
2023-03-29 09:39:15 -05:00
|
|
|
"time"
|
2023-01-09 15:37:44 -05:00
|
|
|
|
|
|
|
"github.com/99designs/gqlgen/graphql"
|
|
|
|
godigest "github.com/opencontainers/go-digest"
|
|
|
|
ispec "github.com/opencontainers/image-spec/specs-go/v1"
|
|
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
|
|
|
|
|
|
"zotregistry.io/zot/pkg/extensions/search/convert"
|
|
|
|
cveinfo "zotregistry.io/zot/pkg/extensions/search/cve"
|
2023-03-29 09:39:15 -05:00
|
|
|
"zotregistry.io/zot/pkg/extensions/search/gql_generated"
|
2023-02-27 14:23:18 -05:00
|
|
|
"zotregistry.io/zot/pkg/log"
|
2023-03-28 12:20:09 -05:00
|
|
|
"zotregistry.io/zot/pkg/meta/bolt"
|
2023-01-09 15:37:44 -05:00
|
|
|
"zotregistry.io/zot/pkg/meta/repodb"
|
2023-03-28 12:20:09 -05:00
|
|
|
boltdb_wrapper "zotregistry.io/zot/pkg/meta/repodb/boltdb-wrapper"
|
2023-01-09 15:37:44 -05:00
|
|
|
"zotregistry.io/zot/pkg/test/mocks"
|
|
|
|
)
|
|
|
|
|
|
|
|
var ErrTestError = errors.New("TestError")
|
|
|
|
|
|
|
|
func TestConvertErrors(t *testing.T) {
|
2023-02-27 14:23:18 -05:00
|
|
|
Convey("Convert Errors", t, func() {
|
2023-03-28 12:20:09 -05:00
|
|
|
params := bolt.DBParameters{
|
2023-01-09 15:37:44 -05:00
|
|
|
RootDir: t.TempDir(),
|
2023-03-28 12:20:09 -05:00
|
|
|
}
|
|
|
|
boltDB, err := bolt.GetBoltDriver(params)
|
|
|
|
So(err, ShouldBeNil)
|
|
|
|
|
|
|
|
repoDB, err := boltdb_wrapper.NewBoltDBWrapper(boltDB, log.NewLogger("debug", ""))
|
2023-01-09 15:37:44 -05:00
|
|
|
So(err, ShouldBeNil)
|
|
|
|
|
|
|
|
configBlob, err := json.Marshal(ispec.Image{})
|
|
|
|
So(err, ShouldBeNil)
|
|
|
|
|
|
|
|
manifestBlob, err := json.Marshal(ispec.Manifest{
|
|
|
|
Layers: []ispec.Descriptor{
|
|
|
|
{
|
|
|
|
MediaType: ispec.MediaTypeImageLayerGzip,
|
|
|
|
Size: 0,
|
|
|
|
Digest: godigest.NewDigestFromEncoded(godigest.SHA256, "digest"),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
So(err, ShouldBeNil)
|
|
|
|
|
|
|
|
repoMeta11 := repodb.ManifestMetadata{
|
|
|
|
ManifestBlob: manifestBlob,
|
|
|
|
ConfigBlob: configBlob,
|
|
|
|
}
|
|
|
|
|
|
|
|
digest11 := godigest.FromString("abc1")
|
|
|
|
err = repoDB.SetManifestMeta("repo1", digest11, repoMeta11)
|
|
|
|
So(err, ShouldBeNil)
|
2023-03-09 13:41:48 -05:00
|
|
|
err = repoDB.SetRepoReference("repo1", "0.1.0", digest11, ispec.MediaTypeImageManifest)
|
2023-01-09 15:37:44 -05:00
|
|
|
So(err, ShouldBeNil)
|
|
|
|
|
2023-02-27 14:23:18 -05:00
|
|
|
repoMetas, manifestMetaMap, _, _, err := repoDB.SearchRepos(context.Background(), "", repodb.Filter{},
|
2023-01-18 17:20:55 -05:00
|
|
|
repodb.PageInput{})
|
2023-01-09 15:37:44 -05:00
|
|
|
So(err, ShouldBeNil)
|
|
|
|
|
|
|
|
ctx := graphql.WithResponseContext(context.Background(),
|
|
|
|
graphql.DefaultErrorPresenter, graphql.DefaultRecover)
|
|
|
|
|
|
|
|
_ = convert.RepoMeta2RepoSummary(
|
|
|
|
ctx,
|
|
|
|
repoMetas[0],
|
|
|
|
manifestMetaMap,
|
2023-02-27 14:23:18 -05:00
|
|
|
map[string]repodb.IndexData{},
|
2023-01-09 15:37:44 -05:00
|
|
|
convert.SkipQGLField{},
|
|
|
|
mocks.CveInfoMock{
|
2023-02-27 14:23:18 -05:00
|
|
|
GetCVESummaryForImageFn: func(repo string, reference string,
|
|
|
|
) (cveinfo.ImageCVESummary, error) {
|
2023-01-09 15:37:44 -05:00
|
|
|
return cveinfo.ImageCVESummary{}, ErrTestError
|
|
|
|
},
|
|
|
|
},
|
|
|
|
)
|
|
|
|
|
|
|
|
So(graphql.GetErrors(ctx).Error(), ShouldContainSubstring, "unable to run vulnerability scan on tag")
|
|
|
|
})
|
2023-02-27 14:23:18 -05:00
|
|
|
|
|
|
|
Convey("ImageIndex2ImageSummary errors", t, func() {
|
|
|
|
ctx := graphql.WithResponseContext(context.Background(),
|
|
|
|
graphql.DefaultErrorPresenter, graphql.DefaultRecover)
|
|
|
|
|
|
|
|
_, _, err := convert.ImageIndex2ImageSummary(
|
|
|
|
ctx,
|
|
|
|
"repo",
|
|
|
|
"tag",
|
|
|
|
godigest.FromString("indexDigest"),
|
|
|
|
true,
|
|
|
|
repodb.RepoMetadata{},
|
|
|
|
repodb.IndexData{
|
|
|
|
IndexBlob: []byte("bad json"),
|
|
|
|
},
|
|
|
|
map[string]repodb.ManifestMetadata{},
|
|
|
|
mocks.CveInfoMock{},
|
|
|
|
)
|
|
|
|
So(err, ShouldNotBeNil)
|
|
|
|
})
|
|
|
|
|
|
|
|
Convey("ImageIndex2ImageSummary cve scanning", t, func() {
|
|
|
|
ctx := graphql.WithResponseContext(context.Background(),
|
|
|
|
graphql.DefaultErrorPresenter, graphql.DefaultRecover)
|
|
|
|
|
|
|
|
_, _, err := convert.ImageIndex2ImageSummary(
|
|
|
|
ctx,
|
|
|
|
"repo",
|
|
|
|
"tag",
|
|
|
|
godigest.FromString("indexDigest"),
|
|
|
|
false,
|
|
|
|
repodb.RepoMetadata{},
|
|
|
|
repodb.IndexData{
|
|
|
|
IndexBlob: []byte("{}"),
|
|
|
|
},
|
|
|
|
map[string]repodb.ManifestMetadata{},
|
|
|
|
mocks.CveInfoMock{
|
|
|
|
GetCVESummaryForImageFn: func(repo, reference string,
|
|
|
|
) (cveinfo.ImageCVESummary, error) {
|
|
|
|
return cveinfo.ImageCVESummary{}, ErrTestError
|
|
|
|
},
|
|
|
|
},
|
|
|
|
)
|
|
|
|
So(err, ShouldBeNil)
|
|
|
|
})
|
|
|
|
|
|
|
|
Convey("ImageManifest2ImageSummary", t, func() {
|
|
|
|
ctx := graphql.WithResponseContext(context.Background(),
|
|
|
|
graphql.DefaultErrorPresenter, graphql.DefaultRecover)
|
2023-03-21 12:16:00 -05:00
|
|
|
configBlob, err := json.Marshal(ispec.Image{
|
|
|
|
Platform: ispec.Platform{
|
|
|
|
OS: "os",
|
|
|
|
Architecture: "arch",
|
|
|
|
Variant: "var",
|
|
|
|
},
|
|
|
|
})
|
|
|
|
So(err, ShouldBeNil)
|
2023-02-27 14:23:18 -05:00
|
|
|
|
2023-03-21 12:16:00 -05:00
|
|
|
_, _, err = convert.ImageManifest2ImageSummary(
|
2023-02-27 14:23:18 -05:00
|
|
|
ctx,
|
|
|
|
"repo",
|
|
|
|
"tag",
|
|
|
|
godigest.FromString("manifestDigest"),
|
|
|
|
false,
|
|
|
|
repodb.RepoMetadata{},
|
|
|
|
repodb.ManifestMetadata{
|
|
|
|
ManifestBlob: []byte("{}"),
|
2023-03-21 12:16:00 -05:00
|
|
|
ConfigBlob: configBlob,
|
2023-02-27 14:23:18 -05:00
|
|
|
},
|
|
|
|
mocks.CveInfoMock{
|
|
|
|
GetCVESummaryForImageFn: func(repo, reference string,
|
|
|
|
) (cveinfo.ImageCVESummary, error) {
|
|
|
|
return cveinfo.ImageCVESummary{}, ErrTestError
|
|
|
|
},
|
|
|
|
},
|
|
|
|
)
|
|
|
|
So(err, ShouldBeNil)
|
|
|
|
})
|
|
|
|
|
|
|
|
Convey("ImageManifest2ManifestSummary", t, func() {
|
|
|
|
ctx := graphql.WithResponseContext(context.Background(),
|
|
|
|
graphql.DefaultErrorPresenter, graphql.DefaultRecover)
|
|
|
|
|
|
|
|
// with bad config json, error while unmarshaling
|
|
|
|
_, _, err := convert.ImageManifest2ManifestSummary(
|
|
|
|
ctx,
|
|
|
|
"repo",
|
|
|
|
"tag",
|
|
|
|
ispec.Descriptor{
|
|
|
|
Digest: "dig",
|
|
|
|
MediaType: ispec.MediaTypeImageManifest,
|
|
|
|
},
|
|
|
|
false,
|
2023-03-21 12:16:00 -05:00
|
|
|
repodb.RepoMetadata{
|
|
|
|
Tags: map[string]repodb.Descriptor{},
|
|
|
|
Statistics: map[string]repodb.DescriptorStatistics{},
|
|
|
|
Signatures: map[string]repodb.ManifestSignatures{},
|
|
|
|
Referrers: map[string][]repodb.ReferrerInfo{},
|
|
|
|
},
|
2023-02-27 14:23:18 -05:00
|
|
|
repodb.ManifestMetadata{
|
|
|
|
ManifestBlob: []byte("{}"),
|
|
|
|
ConfigBlob: []byte("bad json"),
|
|
|
|
},
|
2023-03-20 11:14:17 -05:00
|
|
|
nil,
|
2023-02-27 14:23:18 -05:00
|
|
|
mocks.CveInfoMock{
|
|
|
|
GetCVESummaryForImageFn: func(repo, reference string,
|
|
|
|
) (cveinfo.ImageCVESummary, error) {
|
|
|
|
return cveinfo.ImageCVESummary{}, ErrTestError
|
|
|
|
},
|
|
|
|
},
|
|
|
|
)
|
|
|
|
So(err, ShouldNotBeNil)
|
|
|
|
|
|
|
|
// CVE scan using platform
|
|
|
|
configBlob, err := json.Marshal(ispec.Image{
|
|
|
|
Platform: ispec.Platform{
|
|
|
|
OS: "os",
|
|
|
|
Architecture: "arch",
|
2023-03-21 12:16:00 -05:00
|
|
|
Variant: "var",
|
2023-02-27 14:23:18 -05:00
|
|
|
},
|
|
|
|
})
|
|
|
|
So(err, ShouldBeNil)
|
|
|
|
|
|
|
|
_, _, err = convert.ImageManifest2ManifestSummary(
|
|
|
|
ctx,
|
|
|
|
"repo",
|
|
|
|
"tag",
|
|
|
|
ispec.Descriptor{
|
|
|
|
Digest: "dig",
|
|
|
|
MediaType: ispec.MediaTypeImageManifest,
|
|
|
|
},
|
|
|
|
false,
|
2023-03-21 12:16:00 -05:00
|
|
|
repodb.RepoMetadata{
|
|
|
|
Tags: map[string]repodb.Descriptor{},
|
|
|
|
Statistics: map[string]repodb.DescriptorStatistics{},
|
|
|
|
Signatures: map[string]repodb.ManifestSignatures{"dig": {"cosine": []repodb.SignatureInfo{{}}}},
|
|
|
|
Referrers: map[string][]repodb.ReferrerInfo{},
|
|
|
|
},
|
2023-02-27 14:23:18 -05:00
|
|
|
repodb.ManifestMetadata{
|
|
|
|
ManifestBlob: []byte("{}"),
|
|
|
|
ConfigBlob: configBlob,
|
|
|
|
},
|
2023-03-20 11:14:17 -05:00
|
|
|
nil,
|
2023-02-27 14:23:18 -05:00
|
|
|
mocks.CveInfoMock{
|
|
|
|
GetCVESummaryForImageFn: func(repo, reference string,
|
|
|
|
) (cveinfo.ImageCVESummary, error) {
|
|
|
|
return cveinfo.ImageCVESummary{}, ErrTestError
|
|
|
|
},
|
|
|
|
},
|
|
|
|
)
|
|
|
|
So(err, ShouldBeNil)
|
|
|
|
})
|
|
|
|
|
|
|
|
Convey("RepoMeta2ExpandedRepoInfo", t, func() {
|
|
|
|
ctx := graphql.WithResponseContext(context.Background(),
|
|
|
|
graphql.DefaultErrorPresenter, graphql.DefaultRecover)
|
|
|
|
|
|
|
|
// with bad config json, error while unmarshaling
|
|
|
|
_, imageSummaries := convert.RepoMeta2ExpandedRepoInfo(
|
|
|
|
ctx,
|
|
|
|
repodb.RepoMetadata{
|
|
|
|
Tags: map[string]repodb.Descriptor{
|
|
|
|
"tag1": {Digest: "dig", MediaType: ispec.MediaTypeImageManifest},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
map[string]repodb.ManifestMetadata{
|
|
|
|
"dig": {
|
|
|
|
ManifestBlob: []byte("{}"),
|
|
|
|
ConfigBlob: []byte("bad json"),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
map[string]repodb.IndexData{},
|
|
|
|
convert.SkipQGLField{
|
|
|
|
Vulnerabilities: false,
|
|
|
|
},
|
|
|
|
mocks.CveInfoMock{
|
|
|
|
GetCVESummaryForImageFn: func(repo, reference string,
|
|
|
|
) (cveinfo.ImageCVESummary, error) {
|
|
|
|
return cveinfo.ImageCVESummary{}, ErrTestError
|
|
|
|
},
|
|
|
|
}, log.NewLogger("debug", ""),
|
|
|
|
)
|
|
|
|
So(len(imageSummaries), ShouldEqual, 0)
|
2023-03-21 12:16:00 -05:00
|
|
|
|
|
|
|
// cveInfo present no error
|
|
|
|
_, imageSummaries = convert.RepoMeta2ExpandedRepoInfo(
|
|
|
|
ctx,
|
|
|
|
repodb.RepoMetadata{
|
|
|
|
Tags: map[string]repodb.Descriptor{
|
|
|
|
"tag1": {Digest: "dig", MediaType: ispec.MediaTypeImageManifest},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
map[string]repodb.ManifestMetadata{
|
|
|
|
"dig": {
|
|
|
|
ManifestBlob: []byte("{}"),
|
|
|
|
ConfigBlob: []byte("{}"),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
map[string]repodb.IndexData{},
|
|
|
|
convert.SkipQGLField{
|
|
|
|
Vulnerabilities: false,
|
|
|
|
},
|
|
|
|
mocks.CveInfoMock{
|
|
|
|
GetCVESummaryForImageFn: func(repo, reference string,
|
|
|
|
) (cveinfo.ImageCVESummary, error) {
|
|
|
|
return cveinfo.ImageCVESummary{}, ErrTestError
|
|
|
|
},
|
|
|
|
}, log.NewLogger("debug", ""),
|
|
|
|
)
|
|
|
|
So(len(imageSummaries), ShouldEqual, 1)
|
2023-02-27 14:23:18 -05:00
|
|
|
})
|
2023-01-09 15:37:44 -05:00
|
|
|
}
|
2023-01-23 12:45:11 -05:00
|
|
|
|
2023-03-29 09:39:15 -05:00
|
|
|
func TestUpdateLastUpdatedTimestam(t *testing.T) {
|
|
|
|
Convey("Image summary is the first image checked for the repo", t, func() {
|
|
|
|
before := time.Time{}
|
|
|
|
after := time.Date(2023, time.April, 1, 11, 0, 0, 0, time.UTC)
|
|
|
|
img := convert.UpdateLastUpdatedTimestamp(
|
|
|
|
&before,
|
|
|
|
&gql_generated.ImageSummary{LastUpdated: &before},
|
|
|
|
&gql_generated.ImageSummary{LastUpdated: &after},
|
|
|
|
)
|
|
|
|
|
|
|
|
So(*img.LastUpdated, ShouldResemble, after)
|
|
|
|
})
|
|
|
|
|
|
|
|
Convey("Image summary is updated after the current latest image", t, func() {
|
|
|
|
before := time.Date(2022, time.April, 1, 11, 0, 0, 0, time.UTC)
|
|
|
|
after := time.Date(2023, time.April, 1, 11, 0, 0, 0, time.UTC)
|
|
|
|
img := convert.UpdateLastUpdatedTimestamp(
|
|
|
|
&before,
|
|
|
|
&gql_generated.ImageSummary{LastUpdated: &before},
|
|
|
|
&gql_generated.ImageSummary{LastUpdated: &after},
|
|
|
|
)
|
|
|
|
|
|
|
|
So(*img.LastUpdated, ShouldResemble, after)
|
|
|
|
})
|
|
|
|
|
|
|
|
Convey("Image summary is updated before the current latest image", t, func() {
|
|
|
|
before := time.Date(2022, time.April, 1, 11, 0, 0, 0, time.UTC)
|
|
|
|
after := time.Date(2023, time.April, 1, 11, 0, 0, 0, time.UTC)
|
|
|
|
img := convert.UpdateLastUpdatedTimestamp(
|
|
|
|
&after,
|
|
|
|
&gql_generated.ImageSummary{LastUpdated: &after},
|
|
|
|
&gql_generated.ImageSummary{LastUpdated: &before},
|
|
|
|
)
|
|
|
|
|
|
|
|
So(*img.LastUpdated, ShouldResemble, after)
|
|
|
|
})
|
|
|
|
}
|
2023-04-18 13:07:47 -05:00
|
|
|
|
|
|
|
func TestLabels(t *testing.T) {
|
|
|
|
Convey("Test labels", t, func() {
|
|
|
|
// Test various labels
|
|
|
|
labels := make(map[string]string)
|
|
|
|
|
|
|
|
desc := convert.GetDescription(labels)
|
|
|
|
So(desc, ShouldEqual, "")
|
|
|
|
|
|
|
|
license := convert.GetLicenses(labels)
|
|
|
|
So(license, ShouldEqual, "")
|
|
|
|
|
|
|
|
vendor := convert.GetVendor(labels)
|
|
|
|
So(vendor, ShouldEqual, "")
|
|
|
|
|
|
|
|
categories := convert.GetCategories(labels)
|
|
|
|
So(categories, ShouldEqual, "")
|
|
|
|
|
|
|
|
labels[ispec.AnnotationVendor] = "zot"
|
|
|
|
labels[ispec.AnnotationDescription] = "zot-desc"
|
|
|
|
labels[ispec.AnnotationLicenses] = "zot-license"
|
|
|
|
labels[convert.AnnotationLabels] = "zot-labels"
|
|
|
|
|
|
|
|
desc = convert.GetDescription(labels)
|
|
|
|
So(desc, ShouldEqual, "zot-desc")
|
|
|
|
|
|
|
|
license = convert.GetLicenses(labels)
|
|
|
|
So(license, ShouldEqual, "zot-license")
|
|
|
|
|
|
|
|
vendor = convert.GetVendor(labels)
|
|
|
|
So(vendor, ShouldEqual, "zot")
|
|
|
|
|
|
|
|
categories = convert.GetCategories(labels)
|
|
|
|
So(categories, ShouldEqual, "zot-labels")
|
|
|
|
|
|
|
|
labels = make(map[string]string)
|
|
|
|
|
|
|
|
// Use diff key
|
|
|
|
labels[convert.LabelAnnotationVendor] = "zot-vendor"
|
|
|
|
labels[convert.LabelAnnotationDescription] = "zot-label-desc"
|
|
|
|
labels[ispec.AnnotationLicenses] = "zot-label-license"
|
|
|
|
|
|
|
|
desc = convert.GetDescription(labels)
|
|
|
|
So(desc, ShouldEqual, "zot-label-desc")
|
|
|
|
|
|
|
|
license = convert.GetLicenses(labels)
|
|
|
|
So(license, ShouldEqual, "zot-label-license")
|
|
|
|
|
|
|
|
vendor = convert.GetVendor(labels)
|
|
|
|
So(vendor, ShouldEqual, "zot-vendor")
|
|
|
|
})
|
|
|
|
}
|