fix: improve support for fs promises older nodejs (#3570)

* fix: improve support for fs promises older nodejs

* second try with fallback for nodejs18

.changeset/chatty-pillows-perform.md

@@ -0,0 +1,18 @@
+---
+'@verdaccio/api': minor
+'@verdaccio/config': minor
+'@verdaccio/core': minor
+'@verdaccio/file-locking': minor
+'@verdaccio/tarball': minor
+'@verdaccio/types': minor
+'@verdaccio/url': minor
+'@verdaccio/hooks': minor
+'@verdaccio/loaders': minor
+'@verdaccio/logger': minor
+'@verdaccio/logger-prettify': minor
+'@verdaccio/local-storage': minor
+'@verdaccio/utils': minor
+'verdaccio': minor
+---
+
+feat: improve support for fs promises older nodejs

packages/api/test/integration/_helper.ts

@@ -16,7 +16,7 @@ import { buildToken, generateRandomHexString } from '@verdaccio/utils';
 
 import apiMiddleware from '../../src';
 
-setup();
+setup({});
 
 export const getConf = (conf) => {
   const configPath = path.join(__dirname, 'config', conf);

packages/config/package.json

@@ -26,8 +26,7 @@
     "verdaccio"
   ],
   "engines": {
-    "node": ">=14",
+    "node": ">=12"
-    "npm": ">=6"
   },
   "scripts": {
     "clean": "rimraf ./build",

packages/config/test/config-parsing.spec.ts

@@ -1,4 +1,4 @@
-import { writeFile } from 'fs/promises';
+import fs from 'fs';
 import path from 'path';
 
 import { fileUtils } from '@verdaccio/core';
@@ -6,6 +6,8 @@ import { fileUtils } from '@verdaccio/core';
 import { fromJStoYAML, parseConfigFile } from '../src';
 import { parseConfigurationFile } from './utils';
 
+const { writeFile } = fs.promises ? fs.promises : require('fs/promises');
+
 describe('parse', () => {
   describe('parseConfigFile', () => {
     describe('JSON format', () => {

packages/core/core/package.json

@@ -19,8 +19,7 @@
   "license": "MIT",
   "homepage": "https://verdaccio.org",
   "engines": {
-    "node": ">=14",
+    "node": ">=12"
-    "npm": ">=6"
   },
   "repository": {
     "type": "https",

packages/core/core/src/file-utils.ts

@@ -1,4 +1,4 @@
-import { mkdir, mkdtemp } from 'fs/promises';
+import fs from 'fs';
 import os from 'os';
 import path from 'path';
 
@@ -6,6 +6,8 @@ export const Files = {
   DatabaseName: '.verdaccio-db.json',
 };
 
+const { mkdir, mkdtemp } = fs.promises ? fs.promises : require('fs/promises');
+
 /**
  * Create a temporary folder.
  * @param prefix The prefix of the folder name.

packages/core/file-locking/package.json

@@ -17,8 +17,7 @@
   "license": "MIT",
   "homepage": "https://verdaccio.org",
   "engines": {
-    "node": ">=14",
+    "node": ">=12"
-    "npm": ">=6"
   },
   "repository": {
     "type": "https",

packages/core/file-locking/src/utils.ts

@@ -1,10 +1,12 @@
-import fs from 'fs/promises';
+import fs from 'fs';
 import locker from 'lockfile';
 import path from 'path';
 import { promisify } from 'util';
 
-export const readFile = fs.readFile;
+const fsP = fs.promises ? fs.promises : require('fs/promises');
-const statPromise = fs.stat;
+
+export const readFile = fsP.readFile;
+const statPromise = fsP.stat;
 // https://github.com/npm/lockfile/issues/33
 const lfLock = promisify(locker.lock);
 const lfUnlock = promisify(locker.unlock);

packages/core/tarball/package.json

@@ -19,8 +19,7 @@
   "license": "MIT",
   "homepage": "https://verdaccio.org",
   "engines": {
-    "node": ">=14",
+    "node": ">=12"
-    "npm": ">=6"
   },
   "repository": {
     "type": "https",

packages/core/types/package.json

@@ -17,8 +17,7 @@
   "license": "MIT",
   "homepage": "https://verdaccio.org",
   "engines": {
-    "node": ">=14",
+    "node": ">=12"
-    "npm": ">=6"
   },
   "repository": {
     "type": "https",

packages/core/url/package.json

@@ -19,8 +19,7 @@
   "license": "MIT",
   "homepage": "https://verdaccio.org",
   "engines": {
-    "node": ">=14",
+    "node": ">=12"
-    "npm": ">=6"
   },
   "repository": {
     "type": "https",

packages/hooks/package.json

@@ -26,8 +26,7 @@
     "verdaccio"
   ],
   "engines": {
-    "node": ">=14",
+    "node": ">=16"
-    "npm": ">=6"
   },
   "dependencies": {
     "@verdaccio/core": "workspace:6.0.0-6-next.53",

packages/loaders/package.json

@@ -38,8 +38,7 @@
     "verdaccio"
   ],
   "engines": {
-    "node": ">=14",
+    "node": ">=12"
-    "npm": ">=6"
   },
   "license": "MIT",
   "scripts": {

packages/loaders/src/plugin-async-loader.ts

@@ -1,5 +1,5 @@
 import buildDebug from 'debug';
-import { lstat } from 'fs/promises';
+import fs from 'fs';
 import { dirname, isAbsolute, join, resolve } from 'path';
 
 import { pluginUtils } from '@verdaccio/core';
@@ -10,6 +10,8 @@ import { PluginType, isES6, isValid, tryLoad } from './utils';
 
 const debug = buildDebug('verdaccio:plugin:loader:async');
 
+const { lstat } = fs.promises ? fs.promises : require('fs/promises');
+
 async function isDirectory(pathFolder: string) {
   const stat = await lstat(pathFolder);
   return stat.isDirectory();

packages/logger-prettify/package.json

@@ -26,8 +26,7 @@
     "verdaccio"
   ],
   "engines": {
-    "node": ">=14",
+    "node": ">=12"
-    "npm": ">=6"
   },
   "scripts": {
     "clean": "rimraf ./build",

packages/logger/package.json

@@ -26,8 +26,7 @@
     "verdaccio"
   ],
   "engines": {
-    "node": ">=14",
+    "node": ">=12"
-    "npm": ">=6"
   },
   "scripts": {
     "clean": "rimraf ./build",

packages/plugins/local-storage/src/fs.ts

@@ -1,16 +1,18 @@
 import fsCallback from 'fs';
-import fs from 'fs/promises';
+import fs from 'fs';
 
-const readFile = fs.readFile;
+const fsP = fs.promises ? fs.promises : require('fs/promises');
-const mkdirPromise = fs.mkdir;
+
-const accessPromise = fs.access;
+const readFile = fsP.readFile;
-const writeFilePromise = fs.writeFile;
+const mkdirPromise = fsP.mkdir;
-const readdirPromise = fs.readdir;
+const accessPromise = fsP.access;
-const statPromise = fs.stat;
+const writeFilePromise = fsP.writeFile;
-const unlinkPromise = fs.unlink;
+const readdirPromise = fsP.readdir;
-const rmdirPromise = fs.rmdir;
+const statPromise = fsP.stat;
-const renamePromise = fs.rename;
+const unlinkPromise = fsP.unlink;
-const openPromise = fs.open;
+const rmdirPromise = fsP.rmdir;
+const renamePromise = fsP.rename;
+const openPromise = fsP.open;
 
 const readFilePromise = async (path) => {
   return await readFile(path, 'utf8');

packages/utils/package.json

@@ -26,8 +26,7 @@
     "verdaccio"
   ],
   "engines": {
-    "node": ">=14",
+    "node": ">=12"
-    "npm": ">=6"
   },
   "dependencies": {
     "@verdaccio/core": "workspace:6.0.0-6-next.53",

packages/verdaccio/src/server/registry.ts

@@ -1,6 +1,6 @@
 import { ChildProcess, fork } from 'child_process';
 import buildDebug from 'debug';
-import { writeFile } from 'fs/promises';
+import fs from 'fs';
 import getPort from 'get-port';
 import path from 'path';
 
@@ -11,6 +11,8 @@ import { buildToken } from '@verdaccio/utils';
 
 import { ServerQuery } from './request';
 
+const { writeFile } = fs.promises ? fs.promises : require('fs/promises');
+
 const buildAuthHeader = (token: string): string => {
   return buildToken(TOKEN_BEARER, token);
 };