From e5624e173c07dc149d231a64534f4fa0ad3f5d23 Mon Sep 17 00:00:00 2001
From: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Date: Thu, 30 May 2024 18:10:13 +0200
Subject: [PATCH] chore: fix types for some store tests (#4657)

* chore: fix types for some store tests

* add changeset
---
 .changeset/big-cameras-invent.md          | 5 +++++
 packages/store/test/storage-utils.spec.ts | 1 +
 packages/store/test/storage.spec.ts       | 6 +++---
 packages/store/test/versions.spec.ts      | 5 +++++
 4 files changed, 14 insertions(+), 3 deletions(-)
 create mode 100644 .changeset/big-cameras-invent.md

diff --git a/.changeset/big-cameras-invent.md b/.changeset/big-cameras-invent.md
new file mode 100644
index 000000000..28b683e38
--- /dev/null
+++ b/.changeset/big-cameras-invent.md
@@ -0,0 +1,5 @@
+---
+'@verdaccio/store': patch
+---
+
+chore: fix types for some store tests
diff --git a/packages/store/test/storage-utils.spec.ts b/packages/store/test/storage-utils.spec.ts
index 0fbd9e473..86b34569b 100644
--- a/packages/store/test/storage-utils.spec.ts
+++ b/packages/store/test/storage-utils.spec.ts
@@ -225,6 +225,7 @@ describe('Storage Utils', () => {
         _uplinks: {},
         name: '',
         versions: {},
+        time: {},
         [DIST_TAGS]: {},
       };
       const mergedPkg = mergeUplinkTimeIntoLocal(pkg1, pkg2);
diff --git a/packages/store/test/storage.spec.ts b/packages/store/test/storage.spec.ts
index 4be29e8b4..2ee31f1f7 100644
--- a/packages/store/test/storage.spec.ts
+++ b/packages/store/test/storage.spec.ts
@@ -772,7 +772,7 @@ describe('storage', () => {
     test('should serve fetch tarball from upstream without dist info local', (done) => {
       const pkgName = 'upstream';
       const upstreamManifest = addNewVersion(
-        generateRemotePackageMetadata(pkgName, '1.0.0'),
+        generateRemotePackageMetadata(pkgName, '1.0.0') as Manifest,
         '1.0.1'
       );
       nock('https://registry.verdaccio.org').get(`/${pkgName}`).reply(201, upstreamManifest);
@@ -832,7 +832,7 @@ describe('storage', () => {
     test('should serve fetch tarball from upstream without with info local', (done) => {
       const pkgName = 'upstream';
       const upstreamManifest = addNewVersion(
-        addNewVersion(generateRemotePackageMetadata(pkgName, '1.0.0'), '1.0.1'),
+        addNewVersion(generateRemotePackageMetadata(pkgName, '1.0.0') as Manifest, '1.0.1'),
         '1.0.2'
       );
       nock('https://registry.verdaccio.org')
@@ -1014,7 +1014,7 @@ describe('storage', () => {
         const storage = new Storage(config);
         await storage.init(config);
         const [manifest] = await storage.syncUplinksMetadata(fooManifest.name, fooManifest, {
-          retry: 0,
+          retry: { limit: 0 },
         });
         expect(manifest).toBe(fooManifest);
       });
diff --git a/packages/store/test/versions.spec.ts b/packages/store/test/versions.spec.ts
index d2c9ad786..30c37f573 100644
--- a/packages/store/test/versions.spec.ts
+++ b/packages/store/test/versions.spec.ts
@@ -41,12 +41,16 @@ describe('versions-utils', () => {
     });
 
     test('should return nothing on get invalid versions', () => {
+      // @ts-ignore
       expect(getVersion({ ...metadata } as any, undefined)).toBeUndefined();
+      // @ts-ignore
       expect(getVersion({ ...metadata } as any, null)).toBeUndefined();
+      // @ts-ignore
       expect(getVersion({ ...metadata } as any, 8)).toBeUndefined();
     });
 
     test('should handle no versions', () => {
+      // @ts-ignore
       expect(getVersion(undefined, undefined)).toBeUndefined();
     });
   });
@@ -60,6 +64,7 @@ describe('versions-utils', () => {
       ]);
     });
     test('should sort versions and filter out invalid', () => {
+      // @ts-ignore
       expect(sortVersionsAndFilterInvalid(['1.0.0', '5.0.0', '2.0.0', '', null])).toEqual([
         '1.0.0',
         '2.0.0',