From 0dddb134620f0e1bd3c1140690b0031f2cafd03e Mon Sep 17 00:00:00 2001 From: "Juan Picado @jotadeveloper" Date: Wed, 25 Apr 2018 07:04:40 +0200 Subject: [PATCH 1/2] chore(build): update circleci to node 10 --- circle.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/circle.yml b/circle.yml index 09da5ce59..759667986 100644 --- a/circle.yml +++ b/circle.yml @@ -15,6 +15,7 @@ dependencies: fi - nvm install 6 - nvm install 8 + - nvm install 10 cache_directories: - ~/.yarn @@ -31,6 +32,8 @@ test: - yarn run test - nvm alias default 9 - yarn run test + - nvm alias default 10 + - yarn run test - yarn run test:e2e - yarn run coverage:publish - echo "machine github.com login verdacciobot password $GITHUB_TOKEN" > ~/.netrc From cee2564ac2d8b456d8d661e0e822426138e1fbe6 Mon Sep 17 00:00:00 2001 From: "Juan Picado @jotadeveloper" Date: Sun, 20 May 2018 21:46:54 +0200 Subject: [PATCH 2/2] feat: add node 10 support for test and docker update Docker to Node 10 we use yarn 1.6.0 as default for build --- Dockerfile | 2 +- circle.yml | 2 +- test/functional/uplink.auth.spec.js | 8 ++++++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/Dockerfile b/Dockerfile index cdf017a41..f4702f79e 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:9.5.0-alpine@sha256:50ae5f22356c5a0b0c0ea76d27a453b0baf577c61633aee25cea93dcacec1630 +FROM node:10.1-alpine LABEL maintainer="https://github.com/verdaccio/verdaccio" RUN apk --no-cache add openssl && \ diff --git a/circle.yml b/circle.yml index 759667986..549f33895 100644 --- a/circle.yml +++ b/circle.yml @@ -1,6 +1,6 @@ machine: environment: - YARN_VERSION: 1.3.2 + YARN_VERSION: 1.6.0 PATH: "${PATH}:${HOME}/.yarn/bin:${HOME}/${CIRCLE_PROJECT_REPONAME}/node_modules/.bin" node: version: 9 diff --git a/test/functional/uplink.auth.spec.js b/test/functional/uplink.auth.spec.js index e3986c44d..a53247ee4 100644 --- a/test/functional/uplink.auth.spec.js +++ b/test/functional/uplink.auth.spec.js @@ -38,7 +38,9 @@ export default function () { }); }; - assert.throws(fnError, 'Auth invalid'); + expect(function ( ) { + fnError(); + }).toThrow(Error('Auth invalid')); }); test('if assigns the header authorization', () => { @@ -100,7 +102,9 @@ export default function () { }) }; - assert.throws(fnError, `Auth type 'null' not allowed`); + expect(function ( ) { + fnError(); + }).toThrow(Error(`Auth type 'null' not allowed`)); }); test('set auth with NPM_TOKEN', () => {