Infrastructure/verdaccio
0
Fork 0
mirror of https://github.com/verdaccio/verdaccio.git synced 2025-02-24 23:55:46 -05:00
Code Issues Activity

fix: runtime dependency missing as explicit dependency (#5101)

Browse source 
* fix: runtime dependency missing as explicit dependency

Currently, when `@verdaccio/signature` is loaded, in particular the `signature.js` file, the `@verdaccio/config` module is being loaded but it's not an explicit dependency. It's just a dev dependency. This is problematic with e.g. pnpm as package manager which intentionally tries to prevent such "leaking"/"escaping" of dependencies.

* lock file

---------

Co-authored-by: Juan Picado <juanpicado19@gmail.com>
This commit is contained in:
Paul Gschwendtner 2025-02-23 12:19:04 +01:00 • committed by GitHub
parent 3711b20816
commit bf0e09a509
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/ninety-geese-do.md Normal file
View file

@ -0,0 +1,5 @@
---
'@verdaccio/config': patch
---
fix: runtime dependency missing as explicit dependency

2
packages/signature/package.json
View file

@ -38,11 +38,11 @@
"build": "pnpm run build:js && pnpm run build:types" "build": "pnpm run build:js && pnpm run build:types"
}, },
"dependencies": { "dependencies": {
"@verdaccio/config": "workspace:8.0.0-next-8.9",
"jsonwebtoken": "9.0.2", "jsonwebtoken": "9.0.2",
"debug": "4.4.0" "debug": "4.4.0"
}, },
"devDependencies": { "devDependencies": {
"@verdaccio/config": "workspace:8.0.0-next-8.9",
"@verdaccio/types": "workspace:13.0.0-next-8.3" "@verdaccio/types": "workspace:13.0.0-next-8.3"
}, },
"funding": { "funding": {

6
pnpm-lock.yaml generated
View file

@ -1610,6 +1610,9 @@ importers:
packages/signature: packages/signature:
dependencies: dependencies:
'@verdaccio/config':
specifier: workspace:8.0.0-next-8.9
version: link:../config
debug: debug:
specifier: 4.4.0 specifier: 4.4.0
version: 4.4.0(supports-color@5.5.0) version: 4.4.0(supports-color@5.5.0)
@ -1617,9 +1620,6 @@ importers:
specifier: 9.0.2 specifier: 9.0.2
version: 9.0.2 version: 9.0.2
devDependencies: devDependencies:
'@verdaccio/config':
specifier: workspace:8.0.0-next-8.9
version: link:../config
'@verdaccio/types': '@verdaccio/types':
specifier: workspace:13.0.0-next-8.3 specifier: workspace:13.0.0-next-8.3
version: link:../core/types version: link:../core/types