lint

lib/local-fs.js

@@ -163,6 +163,7 @@ function lock_and_read(name, callback) {
 
 			var buffer = new Buffer(st.size)
 			fs.read(fd, buffer, 0, st.size, null, function(err, bytesRead, buffer) {
+				if (err) return callback(err)
 				if (bytesRead != st.size) return callback(new Error('st.size != bytesRead'), fd)
 
 				callback(null, fd, buffer)

lib/local-storage.js

@@ -90,7 +90,7 @@ Storage.prototype.remove_package = function(name, callback) {
 			unlinkNext(function() {
 				// try to unlink the directory, but ignore errors because it can fail
 				self.storage(name).rmdir('.', function(err) {
-					callback()
+					callback(err)
 				})
 			})
 		})

lib/up-storage.js

@@ -158,7 +158,11 @@ Storage.prototype.request = function(options, cb) {
 		}
 
 		function do_decode() {
-			if (err) return error = err.message
+			if (err) {
+				error = err.message
+				return
+			}
+
 			if (options.json && res.statusCode < 300) {
 				try {
 					body = JSON.parse(body.toString('utf8'))
@@ -204,7 +208,7 @@ Storage.prototype.request = function(options, cb) {
 			self.status_check(true)
 		}
 	})
-	req.on('error', function(err) {
+	req.on('error', function(_err) {
 		if (!req._sinopia_aborted && !status_called) {
 			status_called = true
 			self.status_check(false)