From a6c8ea8bfc50be3654ca13fad83f4f335c41a08b Mon Sep 17 00:00:00 2001
From: "Juan Picado @jotadeveloper" <juanpicado19@gmail.com>
Date: Sat, 14 Dec 2019 07:53:59 +0100
Subject: [PATCH] build: add node13 to ci checks (#1613)

* chore: add more specific version of nodejs

I want o to be more clear against what we are testing

* chore: coverage as last step

* chore: add codecov

* chore: re-organize the steps
---
 .circleci/config.yml     | 32 +++++++++++++++++++++++---------
 .github/workflows/ci.yml |  2 +-
 codecov.yml              | 29 +++++++++++++++++++++++++++++
 3 files changed, 53 insertions(+), 10 deletions(-)
 create mode 100644 codecov.yml

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 01710e2f9..02f79c2c0 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -6,10 +6,13 @@ executors:
       - image: circleci/node:latest-browsers
   node_latest:
     docker:
-    - image: circleci/node:latest
-  node_lts:
+    - image: circleci/node:13
+  node_lts_12:
     docker:
-      - image: circleci/node:lts
+      - image: circleci/node:12
+  node_lts_10:
+    docker:
+      - image: circleci/node:10
   default_executor: node_latest
 
 aliases:
@@ -87,14 +90,18 @@ jobs:
           key: *coverage_key
           paths:
             - coverage
-
-  test_node_lts:
+  test_node_lts_12:
     <<: *defaults
-    executor: node_lts
+    executor: node_lts_12
+    steps:
+      - restore_repo
+      - run_test
+  test_node_lts_10:
+    <<: *defaults
+    executor: node_lts_10
     steps:
       - restore_repo
       - run_test
-
   test_e2e:
     <<: *defaults
     executor: node_latest_browser
@@ -127,15 +134,22 @@ workflows:
           requires:
             - prepare
           <<: *ignore_non_dev_branches
-      - test_node_lts:
+      - test_node_lts_12:
+          requires:
+            - prepare
+          <<: *ignore_non_dev_branches
+      - test_node_lts_10:
           requires:
             - prepare
           <<: *ignore_non_dev_branches
       - test_e2e:
           requires:
             - prepare
+            - test_node_latest
+            - test_node_lts_10
+            - test_node_lts_12
           <<: *ignore_non_dev_branches
       - coverage:
           requires:
-            - test_node_latest
+            - test_e2e
           <<: *ignore_non_dev_branches
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7f5452f63..6c96465ff 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node_version: [10, 12]
+        node_version: [10, 12, 13]
 
     runs-on: ubuntu-latest
 
diff --git a/codecov.yml b/codecov.yml
new file mode 100644
index 000000000..631140424
--- /dev/null
+++ b/codecov.yml
@@ -0,0 +1,29 @@
+codecov:
+  require_ci_to_pass: yes
+
+coverage:
+  precision: 2
+  round: down
+  range: "80...85"
+
+  status:
+    project:
+      default:
+        target: auto
+        threshold: 1%
+        base: auto
+    patch: no
+    changes: no
+
+parsers:
+  gcov:
+    branch_detection:
+      conditional: yes
+      loop: yes
+      method: no
+      macro: no
+
+comment:
+  layout: "diff,flags,tree"
+  behavior: default
+  require_changes: no
\ No newline at end of file