Infrastructure/verdaccio
0
Fork 0
mirror of https://github.com/verdaccio/verdaccio.git synced 2025-03-11 02:15:57 -05:00
Code Issues Activity

chore: removes verdaccio update banner (#1309)

Browse source
This commit is contained in:
Ayush Sharma 2019-05-12 19:38:32 +02:00 • committed by Juan Picado @jotadeveloper
parent 8e48eea511
commit a588588cf3
3 changed files with 0 additions and 211 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/lib/cli.js
View file

@ -11,7 +11,6 @@ import semver from 'semver';
import { bgYellow, bgRed } from 'kleur';
import {startVerdaccio, listenDefaultCallback} from './bootstrap';
import findConfigFile from './config-path';
import {verdaccioUpdateBanner} from './update-banner';
import { parseConfigFile } from './utils';
if (process.getuid && process.getuid() === 0) {
@ -31,15 +30,9 @@ const logger = require('./logger');
logger.setup(); // default setup
const commander = require('commander');
const pkginfo = require('pkginfo')(module); // eslint-disable-line no-unused-vars
const pkgVersion = module.exports.version;
const pkgName = module.exports.name;
/**
* Checking verdaccio version on NPM
*/
verdaccioUpdateBanner(pkgVersion);
commander
.option('-l, --listen <[host:]port>', 'host:port number to listen on (default: localhost:4873)')
.option('-c, --config <config.yaml>', 'use this configuration file (default: ./config.yaml)')

117
test/unit/api/__snapshots__/update-banner.spec.js.snap
View file

@ -1,117 +0,0 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`Verdaccio update banner should print major update banner 1`] = `
[MockFunction] {
"calls": Array [
Array [
"
A new MAJOR version of Verdaccio is available. 3.0.0 → 4.5.6
Run npm install -g verdaccio to update.
Registry: https://registry.npmjs.org
Changelog: https://github.com/verdaccio/verdaccio/releases/tag/v4.5.6
",
],
],
"results": Array [
Object {
"type": "return",
"value": undefined,
},
],
}
`;
exports[`Verdaccio update banner should print minor update banner 1`] = `
[MockFunction] {
"calls": Array [
Array [
"
A new MINOR version of Verdaccio is available. 4.0.0 → 4.5.6
Run npm install -g verdaccio to update.
Registry: https://registry.npmjs.org
Changelog: https://github.com/verdaccio/verdaccio/releases/tag/v4.5.6
",
],
],
"results": Array [
Object {
"type": "return",
"value": undefined,
},
],
}
`;
exports[`Verdaccio update banner should print patch update banner 1`] = `
[MockFunction] {
"calls": Array [
Array [
"
A new PATCH version of Verdaccio is available. 4.5.0 → 4.5.6
Run npm install -g verdaccio to update.
Registry: https://registry.npmjs.org
Changelog: https://github.com/verdaccio/verdaccio/releases/tag/v4.5.6
",
],
],
"results": Array [
Object {
"type": "return",
"value": undefined,
},
],
}
`;
exports[`Verdaccio update banner when default registry returns with error 1`] = `
[MockFunction] {
"calls": Array [
Array [
"
Unable to check verdaccio version on https://registry.npmjs.org
Error: {\\"message\\":\\"internal server error\\",\\"statusCode\\":500}
",
],
],
"results": Array [
Object {
"type": "return",
"value": undefined,
},
],
}
`;
exports[`create banner should create a major update banner 1`] = `
"
A new MAJOR version of Verdaccio is available. 1.0.0 → 2.0.0
Run npm install -g verdaccio to update.
Registry: https://registry.npmjs.org
Changelog: https://github.com/verdaccio/verdaccio/releases/tag/v2.0.0
"
`;
exports[`create banner should create a minor update banner 1`] = `
"
A new MINOR version of Verdaccio is available. 1.0.0 → 1.1.0
Run npm install -g verdaccio to update.
Registry: https://registry.npmjs.org
Changelog: https://github.com/verdaccio/verdaccio/releases/tag/v1.1.0
"
`;
exports[`create banner should create a patch update banner 1`] = `
"
A new PATCH version of Verdaccio is available. 1.0.0 → 1.0.1
Run npm install -g verdaccio to update.
Registry: https://registry.npmjs.org
Changelog: https://github.com/verdaccio/verdaccio/releases/tag/v1.0.1
"
`;
exports[`createErrorBanner should create an error banner 1`] = `
"
Unable to check verdaccio version on https://registry.npmjs.org
Error: message
"
`;

87
test/unit/api/update-banner.spec.js
View file

@ -1,87 +0,0 @@
// @prettier
// @flow
import {
createBanner,
createErrorBanner
} from '../../../src/lib/update-banner';
import {HTTP_STATUS, API_ERROR} from '../../../src/lib/constants';
jest.resetModules();
jest.doMock('request', () => (url: string, resolver: Function) => {
const response = {
body: JSON.stringify({version: '4.5.6' }),
statusCode: HTTP_STATUS.OK
}
resolver(null, response);
});
const banner = require('../../../src/lib/update-banner');
describe('Verdaccio update banner', () => {
let log;
beforeEach(() => {
// mocking global console.log method
global.console.log = jest.fn();
log = global.console.log
});
test('should print major update banner', () => {
banner.verdaccioUpdateBanner('3.0.0');
expect(log).toMatchSnapshot();
});
test('should print minor update banner', () => {
banner.verdaccioUpdateBanner('4.0.0');
expect(log).toMatchSnapshot();
});
test('should print patch update banner', () => {
banner.verdaccioUpdateBanner('4.5.0');
expect(log).toMatchSnapshot();
});
test('when local version is equals to npm version', () => {
banner.verdaccioUpdateBanner('4.5.6');
expect(log).not.toHaveBeenCalledWith();
});
test('when local version is greater than npm version', () => {
banner.verdaccioUpdateBanner('4.5.7');
expect(log).not.toHaveBeenCalledWith();
});
test('when default registry returns with error', () => {
jest.resetModules();
jest.doMock('request', () => (url: string, resolver: Function) => {
const error = {
message: API_ERROR.INTERNAL_SERVER_ERROR,
statusCode: HTTP_STATUS.INTERNAL_ERROR
}
resolver(error, null);
});
const banner = require('../../../src/lib/update-banner');
banner.verdaccioUpdateBanner('4.5.7');
expect(log).toMatchSnapshot();
})
});
describe('createErrorBanner', () => {
test('should create an error banner', () => {
expect(createErrorBanner('message')).toMatchSnapshot();
});
});
describe('create banner', () => {
test('should create a major update banner', () => {
expect(createBanner('1.0.0', '2.0.0', 'major')).toMatchSnapshot();
});
test('should create a minor update banner', () => {
expect(createBanner('1.0.0', '1.1.0', 'minor')).toMatchSnapshot();
});
test('should create a patch update banner', () => {
expect(createBanner('1.0.0', '1.0.1', 'patch')).toMatchSnapshot();
});
});