From 9c803993d041aa5f6353512546555013f6f5a130 Mon Sep 17 00:00:00 2001
From: Juan Picado <juanpicado19@gmail.com>
Date: Fri, 2 Apr 2021 10:48:51 +0200
Subject: [PATCH] feat: custom protocol header (#2156)

---
 docs/env.variables.md                 | 10 +++++++++-
 src/lib/utils.ts                      |  3 ++-
 test/unit/modules/utils/utils.spec.ts | 16 ++++++++++++++++
 3 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/docs/env.variables.md b/docs/env.variables.md
index dc4bf5209..23a2afa27 100644
--- a/docs/env.variables.md
+++ b/docs/env.variables.md
@@ -15,7 +15,7 @@ Define a specific public url for your server, it overrules the `Host` and `X-For
 
 This is handy in such situations where a dynamic url is required.
 
-eg: 
+eg:
 
 ```
 VERDACCIO_PUBLIC_URL='https://somedomain.org';
@@ -33,3 +33,11 @@ url_prefix: '/second_prefix'
 
 // url -> https://somedomain.org/second_prefix/'
 ```
+
+#### VERDACCIO_FORWARDED_PROTO
+
+The default header to identify the protocol is `X-Forwarded-Proto`, but there are some environments which [uses something different](https://github.com/verdaccio/verdaccio/issues/990), to change it use the variable `VERDACCIO_FORWARDED_PROTO`
+
+```
+$ VERDACCIO_FORWARDED_PROTO=CloudFront-Forwarded-Proto verdaccio --listen 5000
+```
diff --git a/src/lib/utils.ts b/src/lib/utils.ts
index 0d1f406f6..05a29da6b 100644
--- a/src/lib/utils.ts
+++ b/src/lib/utils.ts
@@ -641,7 +641,8 @@ export function getPublicUrl(url_prefix: string = '', req): string {
     if (!isHost(host)) {
       throw new Error('invalid host');
     }
-    const protocol = getWebProtocol(req.get(HEADERS.FORWARDED_PROTO), req.protocol);
+    const protoHeader = process.env.VERDACCIO_FORWARDED_PROTO ?? HEADERS.FORWARDED_PROTO;
+    const protocol = getWebProtocol(req.get(protoHeader), req.protocol);
     const combinedUrl = combineBaseUrl(protocol, host, url_prefix);
     debug('public url by request %o', combinedUrl);
     return combinedUrl;
diff --git a/test/unit/modules/utils/utils.spec.ts b/test/unit/modules/utils/utils.spec.ts
index 17cc44c0e..7808f6540 100644
--- a/test/unit/modules/utils/utils.spec.ts
+++ b/test/unit/modules/utils/utils.spec.ts
@@ -871,5 +871,21 @@ describe('Utilities', () => {
       expect(getPublicUrl(undefined, req)).toEqual('http://some/');
       delete process.env.VERDACCIO_PUBLIC_URL;
     });
+
+    test('with the VERDACCIO_FORWARDED_PROTO to override valid X-Forwarded-Proto https', () => {
+      process.env.VERDACCIO_FORWARDED_PROTO = 'http';
+      const req = httpMocks.createRequest({
+        method: 'GET',
+        headers: {
+          host: 'some.com',
+          'CloudFront-Forwarded-Proto': 'http',
+          [HEADERS.FORWARDED_PROTO]: 'https',
+        },
+        url: '/',
+      });
+
+      expect(getPublicUrl(undefined, req)).toEqual('http://some.com/');
+      delete process.env.VERDACCIO_FORWARDED_PROTO;
+    });
   });
 });