Infrastructure/verdaccio
0
Fork 0
mirror of https://github.com/verdaccio/verdaccio.git synced 2025-04-01 02:42:23 -05:00
Code Issues Activity

chore: performance improvement

Browse source 
two await calls, same method, we save one render.
This commit is contained in:
Juan Picado @jotadeveloper 2019-01-13 13:46:42 +01:00
parent b7b817533b
commit 97a0ae1eab
No known key found for this signature in database
GPG key ID: 18AC54485952D158
1 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/webui/app.js
View file

@ -29,26 +29,18 @@ export default class App extends Component {
}
componentDidMount() {
this.loadLogo();
this.isUserAlreadyLoggedIn();
this.loadPackages();
this.loadOnHandler();
}
// eslint-disable-next-line no-unused-vars
componentDidUpdate(_, prevState) {
const { isUserLoggedIn } = this.state;
if (prevState.isUserLoggedIn !== isUserLoggedIn) {
this.loadPackages();
this.loadOnHandler();
}
}
loadLogo = async () => {
const logoUrl = await logo();
this.setState({
logoUrl,
});
}
isUserAlreadyLoggedIn = () => {
// checks for token validity
const token = storage.getItem('token');
@ -63,10 +55,12 @@ export default class App extends Component {
}
}
loadPackages = async () => {
loadOnHandler = async () => {
try {
const logoUrl = await logo();
this.req = await API.request('packages', 'GET');
this.setState({
logoUrl,
packages: this.req,
isLoading: false,
});