From 9094d0742fac19bce7a09c33d5215d61488a184c Mon Sep 17 00:00:00 2001 From: Alex Kocharin Date: Sun, 15 Dec 2013 03:09:55 +0400 Subject: [PATCH] better error message for incorrect package names --- lib/middleware.js | 5 ++--- lib/utils.js | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/middleware.js b/lib/middleware.js index 1d734344e..99e3e8382 100644 --- a/lib/middleware.js +++ b/lib/middleware.js @@ -4,13 +4,12 @@ var crypto = require('crypto') , Logger = require('./logger') module.exports.validate_name = function validate_name(req, res, next, value, name) { - if (utils.validate_name(req.params.package)) { - req.params.package = String(req.params.package) + if (utils.validate_name(value)) { next() } else { next(new UError({ status: 403, - msg: 'invalid package name', + msg: 'invalid ' + name, })) } } diff --git a/lib/utils.js b/lib/utils.js index ba6c67e57..271343b1a 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -3,6 +3,7 @@ var assert = require('assert') // from normalize-package-data/lib/fixer.js module.exports.validate_name = function(name) { + if (typeof(name) !== 'string') return false name = name.toLowerCase() if ( name.charAt(0) === "." || // ".bin", etc.