From 9041b0f9adaa39b42bdd70fe5bc0fe5914b000bf Mon Sep 17 00:00:00 2001
From: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Date: Sun, 24 Nov 2024 08:01:24 -0500
Subject: [PATCH] chore: add info to log when audit, htpasswd, theme are used
 (#4956)

* chore: add info to log when audit, htpasswd, theme are used

* fix

* fix

* fix logger
---
 .changeset/gold-squids-watch.md       |  8 ++++++++
 packages/auth/src/auth.ts             |  4 ++++
 packages/server/express/src/server.ts | 14 ++++++++++----
 packages/store/src/local-storage.ts   |  4 ++--
 packages/web/src/middleware.ts        | 13 ++++++++++---
 5 files changed, 34 insertions(+), 9 deletions(-)
 create mode 100644 .changeset/gold-squids-watch.md

diff --git a/.changeset/gold-squids-watch.md b/.changeset/gold-squids-watch.md
new file mode 100644
index 000000000..c952ff432
--- /dev/null
+++ b/.changeset/gold-squids-watch.md
@@ -0,0 +1,8 @@
+---
+'@verdaccio/server': patch
+'@verdaccio/store': patch
+'@verdaccio/auth': patch
+'@verdaccio/web': patch
+---
+
+chore: add info to log when audit, htpasswd, theme are used
diff --git a/packages/auth/src/auth.ts b/packages/auth/src/auth.ts
index 47c6ffcbf..277206ffe 100644
--- a/packages/auth/src/auth.ts
+++ b/packages/auth/src/auth.ts
@@ -94,6 +94,10 @@ class Auth implements IAuthMiddleware, TokenEncryption, pluginUtils.IBasicAuth {
         { file: './htpasswd' },
         pluginOptions as any as pluginUtils.PluginOptions
       );
+      this.logger.info(
+        { name: 'verdaccio-htpasswd', pluginCategory: PLUGIN_CATEGORY.AUTHENTICATION },
+        'plugin @{name} successfully loaded (@{pluginCategory})'
+      );
     } catch (error: any) {
       debug('error on loading auth htpasswd plugin stack: %o', error);
       this.logger.info({}, 'no auth plugin has been found');
diff --git a/packages/server/express/src/server.ts b/packages/server/express/src/server.ts
index b96f68de7..848754444 100644
--- a/packages/server/express/src/server.ts
+++ b/packages/server/express/src/server.ts
@@ -78,9 +78,15 @@ const defineAPI = async function (config: IConfig, storage: Storage): Promise<Ex
   );
 
   if (plugins.length === 0) {
-    logger.info('none middleware plugins has been defined, adding audit middleware by default');
-    // @ts-ignore
-    plugins.push(new AuditMiddleware({ enabled: true, strict_ssl: true }, { config, logger }));
+    const auditPlugin = new AuditMiddleware(
+      { enabled: true, strict_ssl: true },
+      { config, logger }
+    );
+    logger.info(
+      { name: 'verdaccio-audit', pluginCategory: PLUGIN_CATEGORY.MIDDLEWARE },
+      'plugin @{name} successfully loaded (@{pluginCategory})'
+    );
+    plugins.push(auditPlugin);
   }
 
   plugins.forEach((plugin: pluginUtils.ExpressMiddleware<IConfig, {}, Auth>) => {
@@ -97,7 +103,7 @@ const defineAPI = async function (config: IConfig, storage: Storage): Promise<Ex
       res.locals.app_version = version ?? '';
       next();
     });
-    const middleware = await webMiddleware(config, auth, storage);
+    const middleware = await webMiddleware(config, auth, storage, logger);
     app.use(middleware);
   } else {
     app.get('/', function (req: $RequestExtend, res: $ResponseExtend, next: $NextFunctionVer) {
diff --git a/packages/store/src/local-storage.ts b/packages/store/src/local-storage.ts
index e748f3ad6..c95576783 100644
--- a/packages/store/src/local-storage.ts
+++ b/packages/store/src/local-storage.ts
@@ -62,8 +62,8 @@ class LocalStorage {
       debug('no custom storage found, loading default storage @verdaccio/local-storage');
       const localStorage = new LocalDatabase(config, logger);
       logger.info(
-        { pluginCategory: PLUGIN_CATEGORY.STORAGE },
-        'plugin @verdaccio/local-storage successfully loaded (@{pluginCategory})'
+        { name: '@verdaccio/local-storage', pluginCategory: PLUGIN_CATEGORY.STORAGE },
+        'plugin @{name} successfully loaded (@{pluginCategory})'
       );
       return localStorage;
     }
diff --git a/packages/web/src/middleware.ts b/packages/web/src/middleware.ts
index ec55f2d4d..614ad1635 100644
--- a/packages/web/src/middleware.ts
+++ b/packages/web/src/middleware.ts
@@ -27,15 +27,22 @@ export async function loadTheme(config: any) {
       PLUGIN_CATEGORY.THEME
     );
     if (plugin.length > 1) {
-      logger.warn('multiple ui themes are not supported , only the first plugin is used used');
+      logger.warn('multiple ui themes are not supported; only the first plugin is used');
     }
 
     return _.head(plugin);
   }
 }
 
-export default async (config, auth, storage) => {
-  const pluginOptions = (await loadTheme(config)) || require('@verdaccio/ui-theme')(config.web);
+export default async (config, auth, storage, logger) => {
+  let pluginOptions = await loadTheme(config);
+  if (!pluginOptions) {
+    pluginOptions = require('@verdaccio/ui-theme')(config.web);
+    logger.info(
+      { name: '@verdaccio/ui-theme', pluginCategory: PLUGIN_CATEGORY.THEME },
+      'plugin @{name} successfully loaded (@{pluginCategory})'
+    );
+  }
 
   // eslint-disable-next-line new-cap
   const router = express.Router();