From 757bded72e6f6878d01dc5bc4648ece71b9faa88 Mon Sep 17 00:00:00 2001 From: Juan Picado Date: Sat, 18 Sep 2021 10:01:22 +0200 Subject: [PATCH] improve ci syn translations --- .github/workflows/ci.yml | 2 +- CONTRIBUTING.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7c9450ae1..a5e1341d9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -226,7 +226,7 @@ jobs: - name: Test run: pnpm test sync-translations: - needs: [ci-e2e-cli, ci-e2e-ui, test-windows] + needs: [ci-e2e-cli, ci-e2e-ui, test-windows, test] runs-on: ubuntu-latest name: synchronize translations if: (github.event_name == 'push' && github.ref == 'refs/heads/master') || github.event_name == 'workflow_dispatch' diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b7a16cc6b..bf906acfc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -208,7 +208,7 @@ For adding a new **language** on the UI follow these steps: 1. Ensure the **language** has been enabled, must be visible in the `crowdin` platform. 2. Find in the explorer the file `en.US.json` in the path `packages/plugins/ui-theme/src/i18n/crowdin/en-US.json` and complete the translations, **not need to find approval on this**. -3. Into the project, add a new field into `packages/plugins/ui-theme/src/i18n/crowdin/en-US.json` file, in the section `lng`, the new language, eg: `{ lng: {korean:"한국인"}}`. (_There is an issue, this string won't be available in crowdin until your PR has been merge_) +3. Into the project, add a new field into `packages/plugins/ui-theme/src/i18n/crowdin/en-US.json` file, in the section `lng`, the new language, eg: `{ lng: {korean:"Korean"}}`. (This file is English based, once the PR has been merged, this string will be available in crowdin for translate to the targeted language). 4. Add the language, [flag icon](https://www.npmjs.com/package/country-flag-icons), and the menu key fort he new language eg: `menuKey: 'lng.korean'` to the file `packages/plugins/ui-theme/src/i18n/enabledLanguages.ts`. 5. For local testing, read `packages/plugins/ui-theme/src/i18n/ABOUT_TRANSLATIONS.md`. 6. Add a `changeset` file, see more info below.