Infrastructure/verdaccio
0
Fork 0
mirror of https://github.com/verdaccio/verdaccio.git synced 2024-12-16 21:56:25 -05:00
Code Issues Activity

test: add unit test for unpublish

Browse source
This commit is contained in:
Juan Picado @jotadeveloper 2019-02-25 08:33:01 +01:00
parent 1d13979a58
commit 6553c6bce1
No known key found for this signature in database
GPG key ID: 18AC54485952D158
2 changed files with 121 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

118
test/unit/api/api.spec.js
View file

@ -11,10 +11,22 @@ import {HEADERS, API_ERROR, HTTP_STATUS, HEADER_TYPE, API_MESSAGE, TOKEN_BEARER}
import {mockServer} from './mock';
import {DOMAIN_SERVERS} from '../../functional/config.functional';
import {buildToken} from '../../../src/lib/utils';
import {getNewToken} from './__api-helper';
require('../../../src/lib/logger').setup([]);
const credentials = { name: 'jota', password: 'secretPass' };
const putPackage = (app, name, publishMetadata) => {
return request(app)
.put(name)
.set(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON)
.send(JSON.stringify(publishMetadata))
.expect(HTTP_STATUS.CREATED)
.set('accept', 'gzip')
.set('accept-encoding', HEADERS.JSON)
.set(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON);
}
describe('endpoint unit test', () => {
let app;
let mockRegistry;
@ -113,7 +125,7 @@ describe('endpoint unit test', () => {
test('should fails on protected endpoint /-/auth-package bad JWT Bearer format', (done) => {
request(app)
.get('/auth-package')
.set('authorization', 'Bearer')
.set('authorization', TOKEN_BEARER)
.expect(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON)
.expect(HTTP_STATUS.FORBIDDEN)
.end(function(err, res) {
@ -126,7 +138,7 @@ describe('endpoint unit test', () => {
test('should fails on protected endpoint /-/auth-package well JWT Bearer', (done) => {
request(app)
.get('/auth-package')
.set('authorization', 'Bearer 12345')
.set('authorization', buildToken(TOKEN_BEARER, '12345'))
.expect(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON)
.expect(HTTP_STATUS.FORBIDDEN)
.end(function(err, res) {
@ -413,13 +425,7 @@ describe('endpoint unit test', () => {
};
test('should set a new tag on jquery', (done) => {
request(app)
.put('/jquery/verdaccio-tag')
.send(JSON.stringify(jqueryVersion))
.set('accept', 'gzip')
.set('accept-encoding', HEADERS.JSON)
.set(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON)
putPackage(app, '/jquery/verdaccio-tag', jqueryVersion)
.expect(HTTP_STATUS.CREATED)
.end(function(err, res) {
if (err) {
@ -535,8 +541,8 @@ describe('endpoint unit test', () => {
});
describe('should test publish api', () => {
test('should publish a new package', (done) => {
describe('should test publish/unpublish api', () => {
test('should publish a new package with no credentials', (done) => {
request(app)
.put('/@scope%2fpk1-test')
.set(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON)
@ -555,11 +561,15 @@ describe('endpoint unit test', () => {
});
});
test('should unpublish a new package', (done) => {
test('should unpublish a new package with credentials', async (done) => {
const credentials = { name: 'jota_unpublish', password: 'secretPass' };
const token = await getNewToken(request(app), credentials);
//FUTURE: for some reason it does not remove the scope folder
request(app)
.del('/@scope%2fpk1-test/-rev/4-6abcdb4efd41a576')
.set(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON)
.set('authorization', buildToken(TOKEN_BEARER, token))
.expect(HTTP_STATUS.CREATED)
.end(function(err, res) {
if (err) {
@ -571,6 +581,90 @@ describe('endpoint unit test', () => {
done();
});
});
test('should fail due non-unpublish nobody can unpublish', async (done) => {
const credentials = { name: 'jota_unpublish_fail', password: 'secretPass' };
const token = await getNewToken(request(app), credentials);
request(app)
.del('/non-unpublish/-rev/4-6abcdb4efd41a576')
.set(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON)
.set('authorization', buildToken(TOKEN_BEARER, token))
.expect(HTTP_STATUS.FORBIDDEN)
.end(function(err, res) {
expect(err).toBeNull();
expect(res.body.error).toBeDefined();
expect(res.body.error).toMatch(/user jota_unpublish_fail is not allowed to unpublish package non-unpublish/);
done();
});
});
test('should be able to publish/unpublish by only super_admin user', async (done) => {
const credentials = { name: 'super_admin', password: 'secretPass' };
const token = await getNewToken(request(app), credentials);
request(app)
.put('/super-admin-can-unpublish')
.set(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON)
.set('authorization', buildToken(TOKEN_BEARER, token))
.send(JSON.stringify(_.assign({}, publishMetadata, {
name: 'super-admin-can-unpublish'
})))
.expect(HTTP_STATUS.CREATED)
.end(function(err, res) {
if (err) {
expect.toBeNull();
return done(err);
}
expect(res.body.ok).toBeDefined();
expect(res.body.success).toBeDefined();
expect(res.body.success).toBeTruthy();
expect(res.body.ok).toMatch(API_MESSAGE.PKG_CREATED);
request(app)
.del('/super-admin-can-unpublish/-rev/4-6abcdb4efd41a576')
.set(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON)
.set('authorization', buildToken(TOKEN_BEARER, token))
.expect(HTTP_STATUS.CREATED)
.end(function(err, res) {
expect(err).toBeNull();
expect(res.body.ok).toBeDefined();
expect(res.body.ok).toMatch(API_MESSAGE.PKG_REMOVED);
done();
});
});
});
test('should be able to publish/unpublish by any user', async (done) => {
const credentials = { name: 'any_user', password: 'secretPass' };
const token = await getNewToken(request(app), credentials);
request(app)
.put('/all-can-unpublish')
.set(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON)
.set('authorization', buildToken(TOKEN_BEARER, token))
.send(JSON.stringify(_.assign({}, publishMetadata, {
name: 'all-can-unpublish'
})))
.expect(HTTP_STATUS.CREATED)
.end(function(err, res) {
if (err) {
expect.toBeNull();
return done(err);
}
expect(res.body.ok).toBeDefined();
expect(res.body.success).toBeDefined();
expect(res.body.success).toBeTruthy();
expect(res.body.ok).toMatch(API_MESSAGE.PKG_CREATED);
request(app)
.del('/all-can-unpublish/-rev/4-6abcdb4efd41a576')
.set(HEADER_TYPE.CONTENT_TYPE, HEADERS.JSON)
.set('authorization', buildToken(TOKEN_BEARER, token))
.expect(HTTP_STATUS.CREATED)
.end(function(err, res) {
expect(err).toBeNull();
expect(res.body.ok).toBeDefined();
expect(res.body.ok).toMatch(API_MESSAGE.PKG_REMOVED);
done();
});
});
});
});
});
});

17
test/unit/partials/config/yaml/api.spec.yaml
View file

@ -6,11 +6,24 @@ packages:
'@*/*':
access: $all
publish: $all
unpublish: $all
unpublish: $authenticated
proxy: npmjs
'auth-package':
access: $authenticated
publish: $authenticated
'non-unpublish':
access: $authenticated
publish: $authenticated
# this is intended, empty block
? unpublish
'super-admin-can-unpublish':
access: $authenticated
publish: super_admin
unpublish: super_admin
'all-can-unpublish':
access: $authenticated
publish: $all
unpublish: $all
'forbidden-place':
access: nobody
publish: $all
@ -28,4 +41,4 @@ packages:
unpublish: xxx
proxy: npmjs
logs:
- { type: stdout, format: pretty, level: error }
- { type: stdout, format: pretty, level: warn }