From 507e55a9a5d7f4be0d10ca8d0c957575084e1b46 Mon Sep 17 00:00:00 2001 From: Juan Picado Date: Mon, 5 Apr 2021 20:48:41 +0200 Subject: [PATCH] chore: remove behindProxy not ready for this release, need more thoughts --- conf/default.yaml | 1 - conf/docker.yaml | 2 -- src/api/index.ts | 3 --- 3 files changed, 6 deletions(-) diff --git a/conf/default.yaml b/conf/default.yaml index 2a1e7a136..a4c5cac5a 100644 --- a/conf/default.yaml +++ b/conf/default.yaml @@ -66,7 +66,6 @@ packages: # WORKAROUND: Through given configuration you can workaround following issue https://github.com/verdaccio/verdaccio/issues/301. Set to 0 in case 60 is not enough. server: keepAliveTimeout: 60 - # behindProxy: false middlewares: audit: diff --git a/conf/docker.yaml b/conf/docker.yaml index 09ad30271..a98043b1d 100644 --- a/conf/docker.yaml +++ b/conf/docker.yaml @@ -71,8 +71,6 @@ packages: # WORKAROUND: Through given configuration you can workaround following issue https://github.com/verdaccio/verdaccio/issues/301. Set to 0 in case 60 is not enough. server: keepAliveTimeout: 60 - # enable this if you run behind a proxy - # behindProxy: false middlewares: audit: diff --git a/src/api/index.ts b/src/api/index.ts index 3b930f36b..c2115f9e8 100644 --- a/src/api/index.ts +++ b/src/api/index.ts @@ -21,9 +21,6 @@ import { log, final, errorReportingMiddleware, serveFavicon } from './middleware const defineAPI = function (config: IConfig, storage: IStorageHandler): any { const auth: IAuth = new Auth(config); const app: Application = express(); - if (config?.server?.behindProxy === true) { - // app.use('trust proxy'); - } // run in production mode by default, just in case // it shouldn't make any difference anyway