diff --git a/packages/cli/src/utils.ts b/packages/cli/src/utils.ts index c991ba0bf..cd6e8752b 100644 --- a/packages/cli/src/utils.ts +++ b/packages/cli/src/utils.ts @@ -1,7 +1,8 @@ import semver from 'semver'; -export const MIN_NODE_VERSION = '14'; +export const MIN_NODE_VERSION = '14.0.0'; -export function isVersionValid(version) { +export function isVersionValid(processVersion) { + const version = processVersion.substr(1); return semver.satisfies(version, `>=${MIN_NODE_VERSION}`); } diff --git a/packages/cli/test/utils.spec.ts b/packages/cli/test/utils.spec.ts index e7c027bd4..fdd3d258f 100644 --- a/packages/cli/test/utils.spec.ts +++ b/packages/cli/test/utils.spec.ts @@ -1,9 +1,16 @@ import { isVersionValid } from '../src/utils'; test('valid version node.js', () => { - expect(isVersionValid('14.0.0')).toBeTruthy(); + expect(isVersionValid('v14.0.0')).toBeTruthy(); + expect(isVersionValid('v15.0.0')).toBeTruthy(); + expect(isVersionValid('v16.0.0')).toBeTruthy(); + expect(isVersionValid('v17.0.0')).toBeTruthy(); }); test('is invalid version node.js', () => { - expect(isVersionValid('13.0.0')).toBeFalsy(); + expect(isVersionValid('v13.0.0')).toBeFalsy(); + expect(isVersionValid('v12.0.0')).toBeFalsy(); + expect(isVersionValid('v8.0.0')).toBeFalsy(); + expect(isVersionValid('v4.0.0')).toBeFalsy(); + expect(isVersionValid('v0.0.10')).toBeFalsy(); }); diff --git a/packages/plugins/ui-theme/package.json b/packages/plugins/ui-theme/package.json index 1d69addcd..e602a65da 100644 --- a/packages/plugins/ui-theme/package.json +++ b/packages/plugins/ui-theme/package.json @@ -19,7 +19,7 @@ "devDependencies": { "@types/react": "17.0.31", "@types/react-autosuggest": "10.1.5", - "@types/react-dom": "17.0.9", + "@types/react-dom": "17.0.10", "@types/react-helmet": "6.1.4", "@types/redux": "3.6.0", "@types/react-router-dom": "5.3.1", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 750385fb7..7df9f05a4 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -726,7 +726,7 @@ importers: '@testing-library/react': 12.1.2 '@types/react': 17.0.31 '@types/react-autosuggest': 10.1.5 - '@types/react-dom': 17.0.9 + '@types/react-dom': 17.0.10 '@types/react-helmet': 6.1.4 '@types/react-router-dom': 5.3.1 '@types/react-virtualized': 9.21.13 @@ -808,7 +808,7 @@ importers: '@testing-library/react': 12.1.2_react-dom@17.0.2+react@17.0.2 '@types/react': 17.0.31 '@types/react-autosuggest': 10.1.5 - '@types/react-dom': 17.0.9 + '@types/react-dom': 17.0.10 '@types/react-helmet': 6.1.4 '@types/react-router-dom': 5.3.1 '@types/react-virtualized': 9.21.13 @@ -6519,8 +6519,8 @@ packages: '@types/react': 17.0.31 dev: true - /@types/react-dom/17.0.9: - resolution: {integrity: sha512-wIvGxLfgpVDSAMH5utdL9Ngm5Owu0VsGmldro3ORLXV8CShrL8awVj06NuEXFQ5xyaYfdca7Sgbk/50Ri1GdPg==} + /@types/react-dom/17.0.10: + resolution: {integrity: sha512-8oz3NAUId2z/zQdFI09IMhQPNgIbiP8Lslhv39DIDamr846/0spjZK0vnrMak0iB8EKb9QFTTIdg2Wj2zH5a3g==} dependencies: '@types/react': 17.0.31 dev: true