Infrastructure/verdaccio
0
Fork 0
mirror of https://github.com/verdaccio/verdaccio.git synced 2025-04-01 02:42:23 -05:00
Code Issues Activity

refactor: add more constants

Browse source
This commit is contained in:
Juan Picado @jotadeveloper 2018-06-24 22:39:35 +02:00
parent 57f0fa7610
commit 4e25f19531
No known key found for this signature in database
GPG key ID: 18AC54485952D158
3 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/api/index.js
View file

@ -1,9 +1,8 @@
// @flow
import express from 'express';
import Error from 'http-errors';
import compression from 'compression';
import _ from 'lodash';
import express from 'express';
import compression from 'compression';
import cors from 'cors';
import Storage from '../lib/storage';
import {loadPlugin} from '../lib/plugin-loader';
@ -14,6 +13,8 @@ import apiEndpoint from './endpoint';
import type {$Application} from 'express';
import type {$ResponseExtend, $RequestExtend, $NextFunctionVer, IStorageHandler, IAuth} from '../../types';
import type {Config as IConfig} from '@verdaccio/types';
import {ErrorCode} from '../lib/utils';
import {API_ERROR, HTTP_STATUS} from '../lib/constants';
const LoggerApp = require('../lib/logger');
const Config = require('../lib/config');
@ -69,18 +70,18 @@ const defineAPI = function(config: Config, storage: IStorageHandler) {
app.use('/-/verdaccio/', require('./web/api')(config, auth, storage));
} else {
app.get('/', function(req: $RequestExtend, res: $ResponseExtend, next: $NextFunctionVer) {
next(Error[404]('Web interface is disabled in the config file'));
next(ErrorCode.getNotFound(API_ERROR.WEB_DISABLED));
});
}
// Catch 404
app.get('/*', function(req: $RequestExtend, res: $ResponseExtend, next: $NextFunctionVer) {
next(Error[404]('File not found'));
next(ErrorCode.getNotFound(API_ERROR.FILE_NOT_FOUND));
});
app.use(function(err, req: $RequestExtend, res: $ResponseExtend, next: $NextFunctionVer) {
if (_.isError(err)) {
if (err.code === 'ECONNABORT' && res.statusCode === 304) {
if (err.code === 'ECONNABORT' && res.statusCode === HTTP_STATUS.NOT_MODIFIED) {
return next();
}
if (_.isFunction(res.report_error) === false) {

6
src/lib/auth.js
View file

@ -148,13 +148,13 @@ class Auth {
let pkg = Object.assign({name: packageName}, this.config.getMatchedPackagesSpec(packageName));
(function next() {
let p = plugins.shift();
const plugin = plugins.shift();
if (typeof(p.allow_access) !== 'function') {
if (typeof(plugin.allow_access) !== 'function') {
return next();
}
p.allow_access(user, pkg, function(err, ok) {
plugin.allow_access(user, pkg, function(err, ok) {
if (err) {
return callback(err);
}

3
src/lib/constants.js
View file

@ -27,6 +27,7 @@ export const HTTP_STATUS = {
OK: 200,
CREATED: 201,
MULTIPLE_CHOICES: 300,
NOT_MODIFIED: 304,
BAD_REQUEST: 400,
UNAUTHORIZED: 401,
FORBIDDEN: 403,
@ -57,6 +58,8 @@ export const API_ERROR = {
NOT_FILE_UPLINK: 'file doesn\'t exist on uplink',
MAX_USERS_REACHED: 'maximum amount of users reached',
VERSION_NOT_EXIST: 'this version doesn\'t exist',
FILE_NOT_FOUND: 'File not found',
WEB_DISABLED: 'Web interface is disabled in the config file',
};
export const DEFAULT_NO_README = 'ERROR: No README data found!';