Infrastructure/verdaccio
0
Fork 0
mirror of https://github.com/verdaccio/verdaccio.git synced 2025-02-03 23:09:17 -05:00
Code Issues Activity

fix: package child components gives undefined in api call

Browse source 
removes ununsed code

packageMeta should be required props
This commit is contained in:
Ayush Sharma 2017-12-14 13:53:21 +05:30 • committed by juanpicado
parent 5b60be0c06
commit 4b8193041b
2 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/webui/src/components/PackageSidebar/index.jsx
View file

@ -47,13 +47,13 @@ export default class PackageSidebar extends React.Component {
render() { render() {
let {packageMeta} = this.state; let {packageMeta} = this.state;
return ( return packageMeta ?
<aside> (<aside>
<LastSync packageMeta={packageMeta} /> <LastSync packageMeta={packageMeta} />
<Maintainers packageMeta={packageMeta} /> <Maintainers packageMeta={packageMeta} />
<Dependencies packageMeta={packageMeta} /> <Dependencies packageMeta={packageMeta} />
{/* Package management module? Help us implement it! */} {/* Package management module? Help us implement it! */}
</aside> </aside>):
); (<aside>Loading package information...</aside>);
} }
} }

6
src/webui/src/components/PackageSidebar/modules/LastSync/index.jsx
View file

@ -6,12 +6,10 @@ import classes from './style.scss';
export default class LastSync extends React.Component { export default class LastSync extends React.Component {
static propTypes = { static propTypes = {
packageMeta: PropTypes.object packageMeta: PropTypes.object.isRequired
}; };
get lastUpdate() { get lastUpdate() {
if (!this.props.packageMeta) return 'Loading...';
let lastUpdate = 0; let lastUpdate = 0;
Object.keys(this.props.packageMeta._uplinks).forEach((upLinkName) => { Object.keys(this.props.packageMeta._uplinks).forEach((upLinkName) => {
const status = this.props.packageMeta._uplinks[upLinkName]; const status = this.props.packageMeta._uplinks[upLinkName];
@ -25,8 +23,6 @@ export default class LastSync extends React.Component {
} }
get recentReleases() { get recentReleases() {
if (!this.props.packageMeta) return [];
let recentReleases = Object.keys(this.props.packageMeta.time).map((version) => { let recentReleases = Object.keys(this.props.packageMeta.time).map((version) => {
return { return {
version, version,