Infrastructure/verdaccio
0
Fork 0
mirror of https://github.com/verdaccio/verdaccio.git synced 2025-02-17 23:45:29 -05:00
Code Issues Activity

logging bad versions

Browse source
This commit is contained in:
Alex Kocharin 2013-12-21 16:09:29 +04:00
parent d29e22ed4b
commit 3b2bd161b7
4 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/logger.js
View file

@ -22,7 +22,7 @@ function getlvl(x) {
module.exports.setup = function(logs) {
var streams = []
if (!logs) logs = [{ type: 'stdout', format: 'pretty', level: 'http' }]
if (logs == null) logs = [{ type: 'stdout', format: 'pretty', level: 'http' }]
logs.forEach(function(target) {
var stream = new Stream()

8
lib/storage.js
View file

@ -563,7 +563,13 @@ Storage._merge_versions = function(local, up) {
// exported for unit tests only
Storage._semver_sort = function semver_sort(array) {
return array
.filter(function(x) { return semver.parse(x, true) != null })
.filter(function(x) {
if (!semver.parse(x, true)) {
Logger.logger.warn({ver: x, sub: 'out'}, 'ignoring bad version @{ver}')
return false
}
return true
})
.sort(semver.compareLoose)
.map(String)
}

2
test/unit/no_proxy.js
View file

@ -1,7 +1,7 @@
var assert = require('assert')
, Storage = require('../../lib/up-storage')
require('../../lib/logger').setup()
require('../../lib/logger').setup([])
function setup(host, config, mainconfig) {
config.url = host

2
test/unit/st_merge.js
View file

@ -2,7 +2,7 @@ var assert = require('assert')
, semver_sort = require('../../lib/storage')._semver_sort
, merge = require('../../lib/storage')._merge_versions
//require('../lib/logger').setup()
require('../../lib/logger').setup([])
describe('Merge', function() {
it('simple', function() {