From 2e5a4096f4e81cc4942499e66348bb0d57b8968b Mon Sep 17 00:00:00 2001
From: jeremy <jeremy.albuixech@gmail.com>
Date: Thu, 2 Aug 2018 12:44:59 -0700
Subject: [PATCH] fix: abort the stream to prevent overwriting existing tarbal

---
 src/lib/local-storage.js            |  1 +
 test/unit/api/local-storage.spec.js | 45 ++++++++++++++---------------
 2 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/src/lib/local-storage.js b/src/lib/local-storage.js
index 4c46686a9..49289a630 100644
--- a/src/lib/local-storage.js
+++ b/src/lib/local-storage.js
@@ -426,6 +426,7 @@ class LocalStorage implements IStorage {
     writeStream.on('error', (err) => {
       if (err.code === fileExist) {
         uploadStream.emit('error', ErrorCode.getConflict());
+        uploadStream.abort();
       } else if (err.code === noSuchFile) {
         // check if package exists to throw an appropriate message
         this.getPackageMetadata(name, function(_err, res) {
diff --git a/test/unit/api/local-storage.spec.js b/test/unit/api/local-storage.spec.js
index e95132bc3..686bb17c8 100644
--- a/test/unit/api/local-storage.spec.js
+++ b/test/unit/api/local-storage.spec.js
@@ -11,7 +11,6 @@ import {readFile} from '../../functional/lib/test.utils';
 import {generatePackageTemplate} from '../../../src/lib/storage-utils';
 import {generateNewVersion} from '../../lib/utils-test';
 
-
 const readMetadata = (fileName: string = 'metadata') => readFile(`../../unit/partials/${fileName}`);
 
 import type {Config, MergeTags} from '@verdaccio/types';
@@ -339,17 +338,18 @@ describe('LocalStorage', () => {
         test('should fails on add a duplicated new tarball ', (done) => {
           const tarballData = JSON.parse(readMetadata('addTarball'));
           const stream = storage.addTarball(pkgName, tarballName);
+          let spy;
+          // $FlowFixMe
+          spy = jest.spyOn(stream &&  stream._readableState && stream._readableState.pipes, 'abort');
           stream.on('error', (err) => {
             expect(err).not.toBeNull();
             expect(err.statusCode).toEqual(HTTP_STATUS.CONFLICT);
-            expect(err.message).toMatch(/this package is already present/);
+            expect(err.message).toMatch(/this package is already present/); 
+          });
+          stream.on('success', function(){
+            expect(spy).toHaveBeenCalled();
             done();
           });
-
-          stream.on('success', function() {
-            done();
-          });
-
           stream.end(new Buffer(tarballData.data, 'base64'));
           stream.done();
         });
@@ -397,26 +397,25 @@ describe('LocalStorage', () => {
           stream.done();
         });
 
-        describe('LocalStorage::removeTarball', () => {
+      });
+      describe('LocalStorage::removeTarball', () => {
 
-          test('should remove a tarball', (done) => {
-            storage.removeTarball(pkgName, tarballName2, 'rev', (err, pkg) => {
-              expect(err).toBeNull();
-              expect(pkg).toBeUndefined();
-              done();
-            });
-          });
-
-          test('should remove a tarball that does not exist', (done) => {
-            storage.removeTarball(pkgName, tarballName2, 'rev', (err) => {
-              expect(err).not.toBeNull();
-              expect(err.statusCode).toEqual(HTTP_STATUS.NOT_FOUND);
-              expect(err.message).toMatch(/no such file available/);
-              done();
-            });
+        test('should remove a tarball', (done) => {
+          storage.removeTarball(pkgName, tarballName2, 'rev', (err, pkg) => {
+            expect(err).toBeNull();
+            expect(pkg).toBeUndefined();
+            done();
           });
         });
 
+        test('should remove a tarball that does not exist', (done) => {
+          storage.removeTarball(pkgName, tarballName2, 'rev', (err) => {
+            expect(err).not.toBeNull();
+            expect(err.statusCode).toEqual(HTTP_STATUS.NOT_FOUND);
+            expect(err.message).toMatch(/no such file available/);
+            done();
+          });
+        });
       });
 
       describe('LocalStorage::getTarball', () => {