Infrastructure/verdaccio
0
Fork 0
mirror of https://github.com/verdaccio/verdaccio.git synced 2024-12-16 21:56:25 -05:00
Code Issues Activity

fix: 🐛 detail page will not load new data after route change

Browse source
This commit is contained in:
Meeeeow 2017-12-02 22:37:03 +08:00 committed by juanpicado
parent f983fa3860
commit 2a69f4e51a
2 changed files with 41 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/webui/src/components/PackageSidebar/index.jsx
View file

@ -23,10 +23,20 @@ export default class PackageSidebar extends React.Component {
}
async componentDidMount() {
await this.loadPackageData(this.props.packageName)
}
async componentWillReceiveProps(newProps) {
if (newProps.packageName !== this.props.packageName) {
await this.loadPackageData(newProps.packageName)
}
}
async loadPackageData(packageName) {
let packageMeta;
try {
packageMeta = (await API.get(`sidebar/${this.props.packageName}`)).data;
packageMeta = (await API.get(`sidebar/${packageName}`)).data;
} catch (err) {
this.setState({
failed: true

24
src/webui/src/modules/detail/index.js → src/webui/src/modules/detail/index.jsx
View file

@ -22,14 +22,32 @@ export default class Detail extends React.Component {
notFound: false,
};
get packageName() {
let params = this.props.match.params;
getPackageName(props = this.props) {
let params = props.match.params;
return `${(params.scope && '@' + params.scope + '/') || ''}${params.package}`;
}
get packageName() {
return this.getPackageName();
}
async componentDidMount() {
await this.loadPackageInfo(this.packageName);
}
async componentWillReceiveProps(newProps) {
let packageName = this.getPackageName(newProps);
if (packageName === this.packageName) return;
await this.loadPackageInfo(packageName);
}
async loadPackageInfo(packageName) {
this.setState({
readMe: ''
});
try {
const resp = await API.get(`package/readme/${this.packageName}`);
const resp = await API.get(`package/readme/${packageName}`);
this.setState({
readMe: resp.data
});